perf test: Basic branch counter support
PATCH v2 1/1 perf test: Basic branch counter support
From: Kan Liang <[email protected]>
Add a basic test for the branch counter feature.
The test verifies that
- The new filter can be successfully applied on the supported platforms.
- The counter value can be outputted via the perf report -D
---
Changes since V2:
- Update the output msg for the skipped case (Ian)
tools/perf/tests/shell/record.sh | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+)
tools/perf/tests/shell/record.sh +30 -0
@@ -11,6 +11,9 @@ err=0 perfdata=$(mktemp /tmp/__perf_test.perf.data.XXXXX) testprog="perf test -w thloop" testsym="test_loop" +cpu_pmu_dir="/sys/bus/event_source/devices/cpu*" +br_cntr_file="/caps/branch_counter_nr" +br_cntr_output="branch stack counters" cleanup() { rm -rf "${perfdata}"
@@ -154,10 +157,37 @@ test_workload() { echo "Basic target workload test [Success]" } +test_branch_counter() { + echo "Basic branch counter test" + # Check if the branch counter feature is supported + for dir in $cpu_pmu_dir + do + if [ ! -e "$dir$br_cntr_file" ] + then + echo "branch counter feature not supported on all core PMUs ($dir) [Skipped]" + return + fi + done + if ! perf record -o "${perfdata}" -j any,counter ${testprog} 2> /dev/null + then + echo "Basic branch counter test [Failed record]" + err=1 + return + fi + if ! perf report -i "${perfdata}" -D -q | grep -q "$br_cntr_output" + then + echo "Basic branch record test [Failed missing output]" + err=1 + return + fi + echo "Basic branch counter test [Success]" +} + test_per_thread test_register_capture test_system_wide test_workload +test_branch_counter cleanup exit $err
Signature · 1 line
2.35.1
Hi Ian,
Quoted 8 lines · On 2023-11-07 1:40 p.m., [email protected] wrote:
From: Kan Liang <[email protected]>
Add a basic test for the branch counter feature.
The test verifies that
- The new filter can be successfully applied on the supported platforms.
- The counter value can be outputted via the perf report -D
Quoted 6 lines
Signed-off-by Kan Liang <[email protected]>---
Changes since V2:
- Update the output msg for the skipped case (Ian)
Any comments for this patch?
Thanks,
Kan
Quoted 55 lines
tools/perf/tests/shell/record.sh | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+)tools/perf/tests/shell/record.sh +30
-0@@ -11,6 +11,9 @@ err=0 perfdata=$(mktemp /tmp/__perf_test.perf.data.XXXXX) testprog="perf test -w thloop" testsym="test_loop" +cpu_pmu_dir="/sys/bus/event_source/devices/cpu*" +br_cntr_file="/caps/branch_counter_nr" +br_cntr_output="branch stack counters" cleanup() { rm -rf "${perfdata}"@@ -154,10 +157,37 @@ test_workload() { echo "Basic target workload test [Success]" } +test_branch_counter() { + echo "Basic branch counter test" + # Check if the branch counter feature is supported + for dir in $cpu_pmu_dir + do + if [ ! -e "$dir$br_cntr_file" ] + then + echo "branch counter feature not supported on all core PMUs ($dir) [Skipped]" + return + fi + done + if ! perf record -o "${perfdata}" -j any,counter ${testprog} 2> /dev/null + then + echo "Basic branch counter test [Failed record]" + err=1 + return + fi + if ! perf report -i "${perfdata}" -D -q | grep -q "$br_cntr_output" + then + echo "Basic branch record test [Failed missing output]" + err=1 + return + fi + echo "Basic branch counter test [Success]" +} + test_per_thread test_register_capture test_system_wide test_workload +test_branch_counter cleanup exit $err
Quoted 12 lines · Kan
Hi Ian,
Quoted 8 lines · On 2023-11-07 1:40 p.m., [email protected] wrote:
From: Kan Liang <[email protected]>
Add a basic test for the branch counter feature.
The test verifies that
- The new filter can be successfully applied on the supported platforms.
- The counter value can be outputted via the perf report -D
Quoted 8 lines
Quoted 6 lines
Signed-off-by Kan Liang <[email protected]>---
Changes since V2:
- Update the output msg for the skipped case (Ian)Any comments for this patch?
Confirmed the wildcard works as expected.
Thanks,
Ian
Quoted 58 lines
Thanks,
KanQuoted 55 lines
tools/perf/tests/shell/record.sh | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+)tools/perf/tests/shell/record.sh +30
-0@@ -11,6 +11,9 @@ err=0 perfdata=$(mktemp /tmp/__perf_test.perf.data.XXXXX) testprog="perf test -w thloop" testsym="test_loop" +cpu_pmu_dir="/sys/bus/event_source/devices/cpu*" +br_cntr_file="/caps/branch_counter_nr" +br_cntr_output="branch stack counters" cleanup() { rm -rf "${perfdata}"@@ -154,10 +157,37 @@ test_workload() { echo "Basic target workload test [Success]" } +test_branch_counter() { + echo "Basic branch counter test" + # Check if the branch counter feature is supported + for dir in $cpu_pmu_dir + do + if [ ! -e "$dir$br_cntr_file" ] + then + echo "branch counter feature not supported on all core PMUs ($dir) [Skipped]" + return + fi + done + if ! perf record -o "${perfdata}" -j any,counter ${testprog} 2> /dev/null + then + echo "Basic branch counter test [Failed record]" + err=1 + return + fi + if ! perf report -i "${perfdata}" -D -q | grep -q "$br_cntr_output" + then + echo "Basic branch record test [Failed missing output]" + err=1 + return + fi + echo "Basic branch counter test [Success]" +} + test_per_thread test_register_capture test_system_wide test_workload +test_branch_counter cleanup exit $err
Em Mon, Nov 20, 2023 at 04:22:24PM -0800, Ian Rogers escreveu:
Quoted 10 lines · Kan
Quoted 8 lines · On 2023-11-07 1:40 p.m., [email protected] wrote:
Quoted 7 lines
From: Kan Liang <[email protected]>
Add a basic test for the branch counter feature.
The test verifies that
- The new filter can be successfully applied on the supported platforms.
- The counter value can be outputted via the perf report -D
Quoted 6 lines
Quoted 3 lines
Quoted 1 line
Signed-off-by Kan Liang <[email protected]>Any comments for this patch?
Confirmed the wildcard works as expected.
Tested-by Ian Rogers <[email protected]>
Thanks, applied to perf-tools-next.
- Arnaldo