Skip to contentSkip to conversation

xfs/146: require fallocate support

PATCH In review Christoph Hellwig 3 participants 3 messages Nov 9, 2023 – Nov 10, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfs/146: require fallocate support

xfs/146 uses the xfs_io falloc subcommand and thus kernel fallocate support. Ensure the support is present.

---
 tests/xfs/146 | 1 +
 1 file changed, 1 insertion(+)
tests/xfs/146 +1 -0
index 123bdff5..c8268a52 100755
@@ -24,6 +24,7 @@ _begin_fstest auto quick rw realtime
 _supported_fs xfs
 _require_scratch
 _require_realtime
+_require_xfs_io_command "falloc"
 _require_test_program "punch-alternating"
 
 # Format filesystem to get the block size
Signature · 1 line
2.39.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Christoph Hellwig

xfs/146 uses the xfs_io falloc subcommand and thus kernel fallocate support. Ensure the support is present.

Ooooops we really ought to get a static checker for this kind of thing. That would be a much better use of engineer time than someone spinning up yet another syzkaller instance... <cough>

--D

Quoted 20 lines
---
 tests/xfs/146 | 1 +
 1 file changed, 1 insertion(+)
tests/xfs/146 +1 -0
index 123bdff5..c8268a52 100755
@@ -24,6 +24,7 @@ _begin_fstest auto quick rw realtime
 _supported_fs xfs
 _require_scratch
 _require_realtime
+_require_xfs_io_command "falloc"
 _require_test_program "punch-alternating"
 
 # Format filesystem to get the block size
Signature · 1 line
2.39.2
Reviewed-by on v1 1/1
#2 lore raw
In reply to Christoph Hellwig
Quoted 13 lines · Christoph Hellwig

xfs/146 uses the xfs_io falloc subcommand and thus kernel fallocate support. Ensure the support is present.

---
 tests/xfs/146 | 1 +
 1 file changed, 1 insertion(+)
tests/xfs/146 +0 -0
index 123bdff5..c8268a52 100755

tests/xfs/146 _begin_fstest auto quick rw realtime · line 27

Quoted 4 lines
tests/xfs/146 +1 -0
@@ -24,6 +24,7 @@ _begin_fstest auto quick rw realtime
 _supported_fs xfs
 _require_scratch
 _require_realtime
+_require_xfs_io_command "falloc"

Thanks, if so, we might need to add this case into "prealloc" group. If you agree that too, I'll add it when I merge it.

Thanks,
Zorro

Quoted 7 lines
tests/xfs/146 +0 -0
 _require_test_program "punch-alternating"
 
 # Format filesystem to get the block size
Signature · 1 line
2.39.2