drm/msm/dsi: use the correct VREG_CTRL_1 value for 4nm cphy
PATCH v2 1/1 drm/msm/dsi: use the correct VREG_CTRL_1 value for 4nm cphy
Use the same value as the downstream driver. This change is needed for CPHY mode to work correctly.
---
v2: fixed the Fixes: line
drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c +1 -1
@@ -918,7 +918,7 @@ static int dsi_7nm_phy_enable(struct msm_dsi_phy *phy,if ((phy->cfg->quirks &DSI_PHY_7NM_QUIRK_V5_2 )) {if (phy->cphy_mode) { vreg_ctrl_0 =0x45 ; - vreg_ctrl_1 =0x45 ; + vreg_ctrl_1 =0x41 ; glbl_rescode_top_ctrl =0x00 ; glbl_rescode_bot_ctrl =0x00 ; }else {
Signature · 1 line
2.26.1
Quoted 11 lines · Jonathan Marek
Use the same value as the downstream driver. This change is needed for CPHY mode to work correctly.
Fixes 8b034e6771113 ("drm/msm/dsi: add support for DSI-PHY on SM8550")Signed-off-by Jonathan Marek <[email protected]>---
v2: fixed the Fixes: linedrivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Good catch !
LGTM
Quoted 13 lines
drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c +1
-1@@ -918,7 +918,7 @@ static int dsi_7nm_phy_enable(struct msm_dsi_phy *phy,if ((phy->cfg->quirks &DSI_PHY_7NM_QUIRK_V5_2 )) {if (phy->cphy_mode) { vreg_ctrl_0 =0x45 ; - vreg_ctrl_1 =0x45 ; + vreg_ctrl_1 =0x41 ; glbl_rescode_top_ctrl =0x00 ; glbl_rescode_bot_ctrl =0x00 ; }else {
Quoted 7 lines · Abhinav Kumar
Quoted 4 lines · Jonathan Marek
Use the same value as the downstream driver. This change is needed for CPHY mode to work correctly.
Fixes 8b034e6771113 ("drm/msm/dsi: add support for DSI-PHY on SM8550")
One error here. We need 12 chars of SHA but you have 13 otherwise checkpatch cries
Will fix this up while applying.
Quoted 28 lines
Quoted 7 lines
Signed-off-by Jonathan Marek <[email protected]>---
v2: fixed the Fixes: line
drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c| 2 +-1 file changed, 1 insertion(+), 1 deletion(-)Good catch !
LGTM
Reviewed-by Abhinav Kumar <[email protected]>Quoted 14 lines
drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c +1
-1@@ -918,7 +918,7 @@ static int dsi_7nm_phy_enable(struct msm_dsi_phy *phy, if ((phy->cfg->quirks & DSI_PHY_7NM_QUIRK_V5_2)) { if (phy->cphy_mode) { vreg_ctrl_0 = 0x45; - vreg_ctrl_1 = 0x45; + vreg_ctrl_1 = 0x41; glbl_rescode_top_ctrl = 0x00; glbl_rescode_bot_ctrl = 0x00;} else {
Abhinav Kumar
AppliedQuoted 4 lines · Jonathan Marek
Use the same value as the downstream driver. This change is needed for CPHY mode to work correctly.
Applied, thanks!
[1/1] drm/msm/dsi: use the correct VREG_CTRL_1 value for 4nm cphy
https://gitlab.freedesktop.org/drm/msm/-/commit/b3e0f94d1570
Best regards,
Signature · 1 line
Abhinav Kumar <[email protected]>