bpf/tests: Remove test for MOVSX32 with offset=32
Subsystems (2)
PATCH 1/1 bpf/tests: Remove test for MOVSX32 with offset=32
MOVSX32 only supports sign extending 8-bit and 16-bit operands into 32 bit operands. The "ALU_MOVSX | BPF_W" test tries to sign extend a 32 bit operand into a 32 bit operand which is equivalent to a normal BPF_MOV.
Remove this test as it tries to run an invalid instruction.
--- lib/test_bpf.c | 16 ---------------- 1 file changed, 16 deletions(-)
lib/test_bpf.c +0 -16
@@ -5144,22 +5144,6 @@ static struct bpf_test tests[] = { { }, { { 0, 0x1 } }, }, - { - "ALU_MOVSX | BPF_W", - .u.insns_int = { -BPF_LD_IMM64 (R2 ,0x00000000deadbeefLL ), -BPF_LD_IMM64 (R3 ,0xdeadbeefdeadbeefLL ), -BPF_MOVSX32_REG (R1 ,R3 ,32 ), -BPF_JMP_REG (BPF_JEQ ,R2 ,R1 ,2 ), -BPF_MOV32_IMM (R0 ,2 ), -BPF_EXIT_INSN (), -BPF_MOV32_IMM (R0 ,1 ), -BPF_EXIT_INSN (), - }, -INTERNAL , - { }, - { { 0, 0x1 } }, - },/* MOVSX64 REG */ { "ALU64_MOVSX | BPF_B",
Signature · 1 line
2.39.2
Quoted 10 lines · Puranjay Mohan
MOVSX32 only supports sign extending 8-bit and 16-bit operands into 32 bit operands. The "
ALU_MOVSX|BPF_W" test tries to sign extend a 32 bit operand into a 32 bit operand which is equivalent to a normalBPF_MOV.Remove this test as it tries to run an invalid instruction.
Fixes daabb2b098e0 ("bpf/tests: add tests for cpuv4 instructions")Signed-off-by Puranjay Mohan <[email protected]>Reported-by kernel test robot <[email protected]>
(based on the fact that emit_movsx_reg doesn't handle 32 bit case under !is64)
Quoted 7 lines · Stanislav Fomichev
Quoted 6 lines · Puranjay Mohan
MOVSX32 only supports sign extending 8-bit and 16-bit operands into 32 bit operands. The "
ALU_MOVSX|BPF_W" test tries to sign extend a 32 bit operand into a 32 bit operand which is equivalent to a normalBPF_MOV.Remove this test as it tries to run an invalid instruction.
Quoted 7 lines
Quoted 4 lines
Fixes daabb2b098e0 ("bpf/tests: add tests for cpuv4 instructions")Signed-off-by Puranjay Mohan <[email protected]>Reported-by kernel test robot <[email protected]>(based on the fact that
emit_movsx_regdoesn't handle 32 bit case under !is64)
The test failure signature is:
#83 ALU_MOVSX | BPF_W jited:1 ret 2 != 1 (0x2 != 0x1)FAIL (1 times)
If the asm code went though verifier, we should get a verification failure. But in test_bpf.ko case, the asm code is directly jited (see jited:1 above), so there is no verification failure.
The current jit does not do error handling and assumes asm code are all legal, so for !is64 case, the size = 32 asm code is silently ignored for x86 side and caused the error. But the test is introduced by arm64 and the test passed for arm64.
Not sure how we could prevent such issues. To handle *all* illegal insns in jit definitely not a good idea. In any case, the change for this patch looks good.
This patch was applied to bpf/bpf-next.git (master) by Alexei Starovoitov <[email protected]>:
Hello:
This patch was applied to bpf/bpf-next.git (master) by Alexei Starovoitov <[email protected]>:
Quoted 4 lines · On Fri, 10 Nov 2023 17:51:50 +0000 you wrote:
MOVSX32 only supports sign extending 8-bit and 16-bit operands into 32 bit operands. The "
ALU_MOVSX|BPF_W" test tries to sign extend a 32 bit operand into a 32 bit operand which is equivalent to a normalBPF_MOV.
Quoted 8 lines
Remove this test as it tries to run an invalid instruction.
Fixes daabb2b098e0 ("bpf/tests: add tests for cpuv4 instructions")Signed-off-by Puranjay Mohan <[email protected]>Reported-by kernel test robot <[email protected]>[...]
Here is the summary with links:
- [bpf] bpf/tests: Remove test for MOVSX32 with offset=32
https://git.kernel.org/bpf/bpf-next/c/5fa201f37c2e
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html