nvme-tcp: only evaluate 'tls' option if TLS is selected
PATCH 1/1 nvme-tcp: only evaluate 'tls' option if TLS is selected
We only need to evaluate the 'tls' connect option if TLS is enabled; otherwise we might be getting a link error.
Reported-by kernel test robot <[email protected]>
Signed-off-by Hannes Reinecke <[email protected]>
--- drivers/nvme/host/tcp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/nvme/host/tcp.c +1 -1
@@ -1916,7 +1916,7 @@ static int nvme_tcp_alloc_admin_queue(struct nvme_ctrl *ctrl)int ret;key_serial_t pskid =0 ; -if (ctrl->opts->tls) { +if (IS_ENABLED (CONFIG_NVME_TCP_TLS ) && ctrl->opts->tls) {if (ctrl->opts->tls_key) pskid =key_serial (ctrl->opts->tls_key);else
Signature · 1 line
2.35.3
Jens Axboe
maintainerQuoted 2 lines · Hannes Reinecke
We only need to evaluate the 'tls' connect option if TLS is enabled; otherwise we might be getting a link error.
As mentioned last time, please include a Fixes line. Don't make the maintainers do this work.
Signature · 1 line
Jens Axboe