pwm: Fix double shift bug
Subsystems (2)
Sasha Levin
maintainerPATCH 1/1 pwm: Fix double shift bug
From: Dan Carpenter <[email protected]>
[ Upstream commit d27abbfd4888d79dd24baf50e774631046ac4732 ]
These enums are passed to set/test_bit(). The set/test_bit() functions take a bit number instead of a shifted value. Passing a shifted value is a double shift bug like doing BIT(BIT(1)). The double shift bug doesn't cause a problem here because we are only checking 0 and 1 but if the value was 5 or above then it can lead to a buffer overflow.
Signed-off-by Dan Carpenter <[email protected]>
Reviewed-by Uwe Kleine-König <[email protected]>
Reviewed-by Sam Protsenko <[email protected]>
Signed-off-by Thierry Reding <[email protected]>
Signed-off-by Sasha Levin <[email protected]>
--- include/linux/pwm.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
include/linux/pwm.h +2 -2
@@ -44,8 +44,8 @@ struct pwm_args { };enum { -PWMF_REQUESTED =1 <<0 , -PWMF_EXPORTED =1 <<1 , +PWMF_REQUESTED =0 , +PWMF_EXPORTED =1 , };/*
Signature · 1 line
2.42.0