pinctrl: npcm7xx: prevent glitch when setting the GPIO to output high
Subsystems (3)
PATCH 1/1 pinctrl: npcm7xx: prevent glitch when setting the GPIO to output high
From: Tomer Maimon <[email protected]>
Enable GPIO output after setting the output value to prevent a glitch when pinctrl driver sets gpio pin to output high and the pin is in the default state (high->low->high).
Signed-off-by Tomer Maimon <[email protected]>
Signed-off-by William A. Kennington III <[email protected]>
--- drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c +1 -1
@@ -1790,8 +1790,8 @@ static int npcm7xx_config_set_one(struct npcm7xx_pinctrl *npcm, bank->direction_input (&bank->gc, pin % bank->gc.ngpio);break ;case PIN_CONFIG_OUTPUT : -iowrite32 (gpio, bank->base +NPCM7XX_GP_N_OES ); bank->direction_output (&bank->gc, pin % bank->gc.ngpio, arg); +iowrite32 (gpio, bank->base +NPCM7XX_GP_N_OES );break ;case PIN_CONFIG_DRIVE_PUSH_PULL :npcm_gpio_clr (&bank->gc, bank->base +NPCM7XX_GP_N_OTYP , gpio);
Signature · 1 line
2.43.0.rc0.421.g78406f8d94-goog
Quoted 8 lines · William A. Kennington III
From: Tomer Maimon <[email protected]>
Enable GPIO output after setting the output value to prevent a glitch when pinctrl driver sets gpio pin to output high and the pin is in the default state (
high->low->high).Signed-off-by Tomer Maimon <[email protected]>Signed-off-by William A. Kennington III <[email protected]>
Patch applied!
Yours,
Linus Walleij