Skip to contentSkip to conversation

iio: light: pa1203001: Drop ACPI_PTR() protection.

PATCH In review Jonathan Cameron 1 participant 2 messages Nov 16, 2023 – Dec 4, 2023 IIO

lore
Share & tools
lore

Jonathan Cameron

author maintainer
#0 lore raw

PATCH 1/1 iio: light: pa1203001: Drop ACPI_PTR() protection.

From: Jonathan Cameron <[email protected]>

The extra cost of always including the acpi_device_id table is trivial vs the complexity of adding guards or __maybe_unused markings so just stop using the ACPI_PTR() macro.

---
 drivers/iio/light/pa12203001.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/light/pa12203001.c +1 -1
index ed241598aefb..636432c45651 100644
@@ -472,7 +472,7 @@ static struct i2c_driver pa12203001_driver = {
 	.driver = {
 		.name = PA12203001_DRIVER_NAME,
 		.pm = &pa12203001_pm_ops,
-		.acpi_match_table = ACPI_PTR(pa12203001_acpi_match),
+		.acpi_match_table = pa12203001_acpi_match,
 	},
 	.probe = pa12203001_probe,
 	.remove = pa12203001_remove,
Signature · 1 line
2.42.1
author maintainer
#1 lore raw
Quoted 9 lines · On Thu, 16 Nov 2023 19:27:11 +0000 Jonathan Cameron <[email protected]> wrote:

From: Jonathan Cameron <[email protected]>

The extra cost of always including the acpi_device_id table is trivial vs the complexity of adding guards or __maybe_unused markings so just stop using the ACPI_PTR() macro.

Meh. Guess not that exciting to review :)

Applied anyway, so hopefully I haven't shot myself in the foot.

Jonathan

Quoted 17 lines
---
 drivers/iio/light/pa12203001.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/light/pa12203001.c +1 -1
index ed241598aefb..636432c45651 100644
@@ -472,7 +472,7 @@ static struct i2c_driver pa12203001_driver = {
 	.driver = {
 		.name = PA12203001_DRIVER_NAME,
 		.pm = &pa12203001_pm_ops,
-		.acpi_match_table = ACPI_PTR(pa12203001_acpi_match),
+		.acpi_match_table = pa12203001_acpi_match,
 	},
 	.probe = pa12203001_probe,
 	.remove = pa12203001_remove,