Skip to contentSkip to conversation

i3c: master: Fix build error

PATCH Applied Jarkko Nikula 3 participants 3 messages Nov 17, 2023 I3C

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 i3c: master: Fix build error

Fix build error caused by commit 2aac0bf4ebc8 ("i3c: Add fallback method for GETMXDS CCC") which incorrectly access the "struct i3c_ccc_cmd_dest dest" as pointer.

drivers/i3c/master.c: In function ‘i3c_master_getmxds_locked’:
drivers/i3c/master.c:1140:21: error: invalid type argument of ‘->’ (have ‘struct i3c_ccc_cmd_dest’)
1140 | dest->payload.len -= 3;
| ^~

Fixes 2aac0bf4ebc8 ("i3c: Add fallback method for GETMXDS CCC")
---
 drivers/i3c/master.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/i3c/master.c +1 -1
index 718b643cb54d..8b729ebae2a6 100644
@@ -1135,7 +1135,7 @@ static int i3c_master_getmxds_locked(struct i3c_master_controller *master,
 		 * Retry when the device does not support max read turnaround
 		 * while expecting shorter length from this CCC command.
 		 */
-		dest->payload.len -= 3;
+		dest.payload.len -= 3;
 		ret = i3c_master_send_ccc_cmd_locked(master, &cmd);
 		if (ret)
 			goto out;
Signature · 7 lines
2.42.0


-- 
linux-i3c mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-i3c
Reviewed-by on v1 1/1
#1 lore raw

Hi Jarkko,

[email protected] wrote on Fri, 17 Nov 2023 13:09:24 +0200:

Quoted 11 lines

Fix build error caused by commit 2aac0bf4ebc8 ("i3c: Add fallback method for GETMXDS CCC") which incorrectly access the "struct i3c_ccc_cmd_dest dest" as pointer.

drivers/i3c/master.c: In function ‘i3c_master_getmxds_locked’:
drivers/i3c/master.c:1140:21: error: invalid type argument of ‘->’ (have ‘struct i3c_ccc_cmd_dest’)
1140 | dest->payload.len -= 3;
| ^~

Fixes 2aac0bf4ebc8 ("i3c: Add fallback method for GETMXDS CCC")
Quoted 9 lines
---
 drivers/i3c/master.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/i3c/master.c +0 -0
index 718b643cb54d..8b729ebae2a6 100644

drivers/i3c/master.c static int i3c_master_getmxds_locked(struct i3c_master_controller *master, · line 1141

Quoted 8 lines
drivers/i3c/master.c +1 -1
@@ -1135,7 +1135,7 @@ static int i3c_master_getmxds_locked(struct i3c_master_controller *master,
 		 * Retry when the device does not support max read turnaround
 		 * while expecting shorter length from this CCC command.
 		 */
-		dest->payload.len -= 3;
+		dest.payload.len -= 3;
 		ret = i3c_master_send_ccc_cmd_locked(master, &cmd);
 		if (ret)
 			goto out;

Thanks,
Miquèl

Signature · 3 lines
linux-i3c mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-i3c
maintainer Applied
#2 lore raw
In reply to Jarkko Nikula
Quoted 10 lines · Jarkko Nikula

Fix build error caused by commit 2aac0bf4ebc8 ("i3c: Add fallback method for GETMXDS CCC") which incorrectly access the "struct i3c_ccc_cmd_dest dest" as pointer.

drivers/i3c/master.c: In function ‘i3c_master_getmxds_locked’:
drivers/i3c/master.c:1140:21: error: invalid type argument of ‘->’ (have ‘struct i3c_ccc_cmd_dest’)
1140 | dest->payload.len -= 3;
| ^~

[...]

Applied, thanks!

[1/1] i3c: master: Fix build error

      commit: b4da37db3e2cfc1c60875b0c10cfc556d5342a3a

Best regards,

Signature · 8 lines
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

-- 
linux-i3c mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-i3c