Skip to contentSkip to conversation

netlink: Add workaround for missing NLM_F_ACK_TLVS and NLM_F_CAPPED

PATCH In review Marcel Holtmann 2 participants 3 messages Nov 21, 2023 – Nov 26, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 netlink: Add workaround for missing NLM_F_ACK_TLVS and NLM_F_CAPPED

The feature for NETLINK_EXT_ACK also adds two additional flags. These are NLM_F_ACK_TLVS and NLM_F_CAPPED and need to be defined as well to be able to used the extended ACK feature.

---
 ell/netlink-private.h | 2 ++
 1 file changed, 2 insertions(+)
ell/netlink-private.h +2 -0
index 0a1b016d8887..fdb584e62652 100644
@@ -27,6 +27,8 @@ enum nlmsgerr_attrs {
 	NLMSGERR_ATTR_MSG,
 	NLMSGERR_ATTR_OFFS,
 };
+#define NLM_F_CAPPED   0x100
+#define NLM_F_ACK_TLVS 0x200
 #endif
 
 bool netlink_parse_ext_ack_error(const struct nlmsghdr *nlmsg,
Signature · 1 line
2.42.0
#1 lore raw

Hi,

Quoted 12 lines

The feature for NETLINK_EXT_ACK also adds two additional flags. These are NLM_F_ACK_TLVS and NLM_F_CAPPED and need to be defined as well to be able to used the extended ACK feature.
---
ell/netlink-private.h | 2 ++

1 file changed, 2 insertions(+)
ell/netlink-private.h +0 -0
index 0a1b016d8887..fdb584e62652 100644

ell/netlink-private.h enum nlmsgerr_attrs { · line 32

Quoted 6 lines
ell/netlink-private.h +2 -0
@@ -27,6 +27,8 @@ enum nlmsgerr_attrs {
 NLMSGERR_ATTR_MSG,
 NLMSGERR_ATTR_OFFS,
 };
+#define NLM_F_CAPPED   0x100
+#define NLM_F_ACK_TLVS 0x200
 #endif

I applied this patch.

Regards

Marcel

#2 lore raw
In reply to Marcel Holtmann
Quoted 4 lines · Marcel Holtmann

The feature for NETLINK_EXT_ACK also adds two additional flags. These are NLM_F_ACK_TLVS and NLM_F_CAPPED and need to be defined as well to be able to used the extended ACK feature.
—

Marcel,

I can confirm that ell-0.61 builds with this final patch against my linux-4.9.212 / glibc-2.32 configuration.

Thank you!

Best,

Grant

Signature · 5 lines
Principal
Nuovations

[email protected]
http://www.nuovations.com/