Skip to contentSkip to conversation

MAINTAINERS: add section MIPS BAIKAL-T1 SOC DRIVERS

PATCH In review Lukas Bulwahn 2 participants 3 messages Nov 22, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 MAINTAINERS: add section MIPS BAIKAL-T1 SOC DRIVERS

In recent years, a number of drivers for the MIPS Baikal-T1 SoC have been added to the kernel tree, but there is no dedicated MAINTAINERS section for this SoC.

As all of the code has been contributed by Serge Semin, let us assume he is still the active maintainer for this code rather than marking it orphan.

Add a new section MIPS BAIKAL-T1 SOC DRIVERS in MAINTAINERS.

---
 MAINTAINERS | 13 +++++++++++++
 1 file changed, 13 insertions(+)
MAINTAINERS +13 -0
index 9613c9c3cc97..820f1ab1ee80 100644
@@ -14474,6 +14474,19 @@ F:	arch/mips/
 F:	drivers/platform/mips/
 F:	include/dt-bindings/mips/
 
+MIPS BAIKAL-T1 SOC DRIVERS
+M:	Serge Semin <[email protected]>
+S:	Maintained
+F:	Documentation/hwmon/bt1-pvt.rst
+F:	drivers/ata/ahci_dwc.c
+F:	drivers/bus/bt1-*.c
+F:	drivers/clk/baikal-t1/
+F:	drivers/hwmon/bt1-pvt.[ch]
+F:	drivers/memory/bt1-l2-ctl.c
+F:	drivers/mtd/maps/physmap-bt1-rom.[ch]
+F:	drivers/pci/controller/dwc/pcie-bt1.c
+F:	drivers/spi/spi-dw-bt1.c
+
 MIPS BOSTON DEVELOPMENT BOARD
 M:	Paul Burton <[email protected]>
 L:	[email protected]
Signature · 1 line
2.17.1
#1 lore raw

Hi Lukas

Quoted 8 lines · Lukas Bulwahn

In recent years, a number of drivers for the MIPS Baikal-T1 SoC have been added to the kernel tree, but there is no dedicated MAINTAINERS section for this SoC.

As all of the code has been contributed by Serge Semin, let us assume he is still the active maintainer for this code rather than marking it orphan.

Add a new section MIPS BAIKAL-T1 SOC DRIVERS in MAINTAINERS.

Thanks for submitting this patch. I was going to send a similar change in the framework of the arch-series which is hanging up in my local repo and alas is still under construction. I know I shouldn't have been waiting (I'm sorry about that), but I didn't expect the entire work would have taken so much time. On a way to finishing it up I had to switch my efforts to the EDAC and network drivers and got sucked by the amount of work there. But I will definitely submit the Baikal-T1 SoC arch patchset when my work on another area is finally over.

Here are several comments about this patch. (Please see my last comment should you be ok with accepting the patches with already fixed notes.)

Quoted 11 lines
---
 MAINTAINERS | 13 +++++++++++++
 1 file changed, 13 insertions(+)
MAINTAINERS +0 -0
index 9613c9c3cc97..820f1ab1ee80 100644

MAINTAINERS F: arch/mips/ · line 14479

Quoted 6 lines
MAINTAINERS +2 -0
@@ -14474,6 +14474,19 @@ F:	arch/mips/
 F:	drivers/platform/mips/
 F:	include/dt-bindings/mips/
 
+MIPS BAIKAL-T1 SOC DRIVERS
 
+M:	Serge Semin <[email protected]>

It's better to change the email to
+M: Serge Semin <[email protected]>
I quicker respond from my private inbox, than from the corporate one. This will also be useful should the corporate email eventually change.

MAINTAINERS F: arch/mips/ · line 14480

Quoted 1 line
MAINTAINERS +1 -0
+S:	Maintained

+F: Documentation/devicetree/bindings/bus/baikal,bt1-*.yaml
+F: Documentation/devicetree/bindings/clock/baikal,bt1-*.yaml

MAINTAINERS F: arch/mips/ · line 14481

Quoted 1 line
MAINTAINERS +1 -0
+F:	Documentation/hwmon/bt1-pvt.rst

I'd prefer this and these -+ being in a separate entry (see the

attached patches), because | the respective device IP-cores have been
re-used in another SoC. So | eventually the entries will be updated to
reflect that.              +---------------------------------+
                                                             |

MAINTAINERS F: arch/mips/ · line 14482

Quoted 1 line
MAINTAINERS +1 -0
+F:	drivers/ata/ahci_dwc.c                               |
                                                             |
I believe this is already listed in the MAINTAINERS file.    |
                                                             |

MAINTAINERS F: arch/mips/ · line 14490

Quoted 8 lines
MAINTAINERS +7 -0
+F:	drivers/bus/bt1-*.c                                  |
+F:	drivers/clk/baikal-t1/                               |
+F:	drivers/hwmon/bt1-pvt.[ch] <-------------------------+
+F:	drivers/memory/bt1-l2-ctl.c                          |
+F:	drivers/mtd/maps/physmap-bt1-rom.[ch]                |
+F:	drivers/pci/controller/dwc/pcie-bt1.c <--------------+
 
+F:	drivers/spi/spi-dw-bt1.c

This is already marked as maintained by me in the framework of the generic DW APB SSI driver (See the "SYNOPSYS DESIGNWARE APB SSI DRIVER" entry in the MAINTAINERS file).

Anyway in order to save your time from editing this patch. I've prepared a series which takes into account all the comments above. If you are ok with it, I can submit it for review. What do you think?

-Serge(y)

Quoted 8 lines
MAINTAINERS +1 -0
+
 MIPS BOSTON DEVELOPMENT BOARD

M: Paul Burton <[email protected]>
L: [email protected]

Signature · 1 line
2.17.1

From 3474717c649d994afade36f8117695a84120ab26 Mon Sep 17 00:00:00 2001
From: Serge Semin <[email protected]>
Date: Fri, 7 Feb 2020 12:37:59 +0300
Subject: [PATCH 1/3] MAINTAINERS: Add maintainer for Baikal-T1 PVT hwmon
driver

Add myself as a maintainer of the Baikal-T1 PVT sensors driver.

---
 MAINTAINERS | 8 ++++++++
 1 file changed, 8 insertions(+)
MAINTAINERS +8 -0
index 97f51d5ec1cf..9e50a77d746e 100644
@@ -3467,6 +3467,14 @@ F:	drivers/video/backlight/
 F:	include/linux/backlight.h
 F:	include/linux/pwm_backlight.h
 
+BAIKAL-T1 PVT HARDWARE MONITOR DRIVER
+M:	Serge Semin <[email protected]>
+L:	[email protected]
+S:	Supported
+F:	Documentation/devicetree/bindings/hwmon/baikal,bt1-pvt.yaml
+F:	Documentation/hwmon/bt1-pvt.rst
+F:	drivers/hwmon/bt1-pvt.[ch]
+
 BARCO P50 GPIO DRIVER
 M:	Santosh Kumar Yadav <[email protected]>
 M:	Peter Korsgaard <[email protected]>
Signature · 1 line
2.42.1

From 460caf4c02f3b9620cf63127a443e05361ff382a Mon Sep 17 00:00:00 2001
From: Serge Semin <[email protected]>
Date: Tue, 22 Mar 2022 23:11:59 +0300
Subject: [PATCH 2/3] MAINTAINERS: Add maintainer for Baikal-T1 PCIe driver

Add myself as a maintainer of the Baikal-T1 PCIe Root Port driver.

---
 MAINTAINERS | 7 +++++++
 1 file changed, 7 insertions(+)
MAINTAINERS +7 -0
index 9e50a77d746e..52ee905c50f4 100644
@@ -16796,6 +16796,13 @@ S:	Maintained
 F:	Documentation/devicetree/bindings/pci/axis,artpec*
 F:	drivers/pci/controller/dwc/*artpec*
 
+PCIE DRIVER FOR BAIKAL-T1
+M:	Serge Semin <[email protected]>
+L:	[email protected]
+S:	Supported
+F:	Documentation/devicetree/bindings/pci/baikal,bt1-pcie.yaml
+F:	drivers/pci/controller/dwc/pcie-bt1.c
+
 PCIE DRIVER FOR CAVIUM THUNDERX
 M:	Robert Richter <[email protected]>
 L:	[email protected]
Signature · 1 line
2.42.1

From 16297c21f443fac69bf1d60924a9ef8602de8a2e Mon Sep 17 00:00:00 2001
From: Serge Semin <[email protected]>
Date: Fri, 7 Feb 2020 12:43:00 +0300
Subject: [PATCH 3/3] MAINTAINERS: Add maintainer for MIPS Baikal-T1 platform
code

Add myself as a maintainer of the MIPS Baikal-T1 platform-specific drivers. The arch-code hasn't been submitted yet, but will be soon enough. Until then it's better to have the already available drivers marked as maintained.

---
 MAINTAINERS | 11 +++++++++++
 1 file changed, 11 insertions(+)
MAINTAINERS +11 -0
index 52ee905c50f4..a56e241608ae 100644
@@ -14491,6 +14491,17 @@ F:	arch/mips/
 F:	drivers/platform/mips/
 F:	include/dt-bindings/mips/
 
+MIPS BAIKAL-T1 PLATFORM
+M:	Serge Semin <[email protected]>
+L:	[email protected]
+S:	Supported
+F:	Documentation/devicetree/bindings/bus/baikal,bt1-*.yaml
+F:	Documentation/devicetree/bindings/clock/baikal,bt1-*.yaml
+F:	drivers/bus/bt1-*.c
+F:	drivers/clk/baikal-t1/
+F:	drivers/memory/bt1-l2-ctl.c
+F:	drivers/mtd/maps/physmap-bt1-rom.[ch]
+
 MIPS BOSTON DEVELOPMENT BOARD
 M:	Paul Burton <[email protected]>
 L:	[email protected]
Signature · 1 line
2.42.1
#2 lore raw
Quoted 74 lines · Serge Semin

Hi Lukas

Quoted 8 lines · Lukas Bulwahn

In recent years, a number of drivers for the MIPS Baikal-T1 SoC have been added to the kernel tree, but there is no dedicated MAINTAINERS section for this SoC.

As all of the code has been contributed by Serge Semin, let us assume he is still the active maintainer for this code rather than marking it orphan.

Add a new section MIPS BAIKAL-T1 SOC DRIVERS in MAINTAINERS.

Thanks for submitting this patch. I was going to send a similar change in the framework of the arch-series which is hanging up in my local repo and alas is still under construction. I know I shouldn't have been waiting (I'm sorry about that), but I didn't expect the entire work would have taken so much time. On a way to finishing it up I had to switch my efforts to the EDAC and network drivers and got sucked by the amount of work there. But I will definitely submit the Baikal-T1 SoC arch patchset when my work on another area is finally over.

Here are several comments about this patch. (Please see my last comment should you be ok with accepting the patches with already fixed notes.)

Quoted 11 lines
---
 MAINTAINERS | 13 +++++++++++++
 1 file changed, 13 insertions(+)
MAINTAINERS +0 -0
index 9613c9c3cc97..820f1ab1ee80 100644

MAINTAINERS F: arch/mips/ · line 14479

Quoted 6 lines
MAINTAINERS +2 -0
@@ -14474,6 +14474,19 @@ F:   arch/mips/
 F:   drivers/platform/mips/
 F:   include/dt-bindings/mips/
 
+MIPS BAIKAL-T1 SOC DRIVERS
 
+M:   Serge Semin <[email protected]>

It's better to change the email to
+M: Serge Semin <[email protected]>
I quicker respond from my private inbox, than from the corporate one. This will also be useful should the corporate email eventually change.

Quoted 1 line
MAINTAINERS +1 -0
+S:   Maintained
MAINTAINERS +2 -0
+F:     Documentation/devicetree/bindings/bus/baikal,bt1-*.yaml
+F:     Documentation/devicetree/bindings/clock/baikal,bt1-*.yaml

MAINTAINERS F: drivers/video/backlight/ · line 3475

Quoted 2 lines
MAINTAINERS +1 -0
+F:   Documentation/hwmon/bt1-pvt.rst

I'd prefer this and these -+ being in a separate entry (see the

attached patches), because | the respective device IP-cores have been
re-used in another SoC. So | eventually the entries will be updated to
reflect that.              +---------------------------------+
                                                             |
> +F:   drivers/ata/ahci_dwc.c                               |
                                                             |
I believe this is already listed in the MAINTAINERS file.    |
                                                             |
> +F:   drivers/bus/bt1-*.c                                  |
> +F:   drivers/clk/baikal-t1/                               |

MAINTAINERS F: arch/mips/ · line 14487

Quoted 6 lines
MAINTAINERS +5 -0
+F:   drivers/hwmon/bt1-pvt.[ch] <-------------------------+
+F:   drivers/memory/bt1-l2-ctl.c                          |
+F:   drivers/mtd/maps/physmap-bt1-rom.[ch]                |
+F:   drivers/pci/controller/dwc/pcie-bt1.c <--------------+
 
+F:   drivers/spi/spi-dw-bt1.c
Quoted 8 lines

This is already marked as maintained by me in the framework of the generic DW APB SSI driver (See the "SYNOPSYS DESIGNWARE APB SSI DRIVER" entry in the MAINTAINERS file).

Anyway in order to save your time from editing this patch. I've prepared a series which takes into account all the comments above. If you are ok with it, I can submit it for review. What do you think?

Sure, go ahead and submit your series. I just wanted to have all files in ./drivers/bus/ have a proper maintainer and then got to look at the BAIKAL T1 files.

Lukas

Quoted 10 lines

-Serge(y)

Quoted 8 lines
MAINTAINERS +1 -1
+
 MIPS BOSTON DEVELOPMENT BOARD
 M:   Paul Burton <[email protected]>
 L:   [email protected]
--

2.17.1