Skip to contentSkip to conversation

dt-bindings: reset: imx-src: Simplify compatible schema and drop unneeded quotes

PATCH Applied Rob Herring 3 participants 3 messages Nov 22, 2023 – Nov 29, 2023

Subsystems (3)
Device tree bindings Arm i.MX and Layerscape Reset controller framework
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: reset: imx-src: Simplify compatible schema and drop unneeded quotes

The compatible schema can be simplified to a single enum for all the cases with "fsl,imx51-src" fallback compatible.

In addition, the compatible strings are redundantly quoted. Drop unneeded quotes over simple string values to fix a soon to be enabled yamllint warning:

[error] string value is redundantly quoted with any quotes (quoted-strings)

Signed-off-by Rob Herring <[email protected]>
---
 .../bindings/reset/fsl,imx-src.yaml           | 31 ++++++-------------
 1 file changed, 10 insertions(+), 21 deletions(-)
Documentation/devicetree/bindings/reset/fsl,imx-src.yaml +10 -21
index b11ac533f914..f5ec1d54aa51 100644
@@ -28,28 +28,17 @@ description: |
 properties:
   compatible:
     oneOf:
-      - const: "fsl,imx51-src"
+      - const: fsl,imx51-src
       - items:
-          - const: "fsl,imx50-src"
-          - const: "fsl,imx51-src"
-      - items:
-          - const: "fsl,imx53-src"
-          - const: "fsl,imx51-src"
-      - items:
-          - const: "fsl,imx6q-src"
-          - const: "fsl,imx51-src"
-      - items:
-          - const: "fsl,imx6sx-src"
-          - const: "fsl,imx51-src"
-      - items:
-          - const: "fsl,imx6sl-src"
-          - const: "fsl,imx51-src"
-      - items:
-          - const: "fsl,imx6ul-src"
-          - const: "fsl,imx51-src"
-      - items:
-          - const: "fsl,imx6sll-src"
-          - const: "fsl,imx51-src"
+          - enum:
+              - fsl,imx50-src
+              - fsl,imx53-src
+              - fsl,imx6q-src
+              - fsl,imx6sx-src
+              - fsl,imx6sl-src
+              - fsl,imx6ul-src
+              - fsl,imx6sll-src
+          - const: fsl,imx51-src
 
   reg:
     maxItems: 1
Signature · 1 line
2.42.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · Rob Herring

The compatible schema can be simplified to a single enum for all the cases with "fsl,imx51-src" fallback compatible.

In addition, the compatible strings are redundantly quoted. Drop unneeded quotes over simple string values to fix a soon to be enabled yamllint warning:

[error] string value is redundantly quoted with any quotes (quoted-strings)

Signed-off-by Rob Herring <[email protected]>
Reviewed-by Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

maintainer Applied
#2 lore raw
In reply to Rob Herring
Quoted 8 lines · Rob Herring

The compatible schema can be simplified to a single enum for all the cases with "fsl,imx51-src" fallback compatible.

In addition, the compatible strings are redundantly quoted. Drop unneeded quotes over simple string values to fix a soon to be enabled yamllint warning:

[...]

Applied to reset/next, thanks!

[1/1] dt-bindings: reset: imx-src: Simplify compatible schema and drop unneeded quotes

      https://git.pengutronix.de/cgit/pza/linux/commit/?id=e4916e791fb6

regards
Philipp