Skip to contentSkip to conversation

leds: syscon: Support 'reg' in addition to 'offset' for register address

PATCH RESEND In review Rob Herring 2 participants 2 messages Nov 22, 2023 – Nov 23, 2023 LED

lore
Share & tools
lore
#0 lore raw

PATCH RESEND v2 1/1 leds: syscon: Support 'reg' in addition to 'offset' for register address

The register-bit-led binding now also supports 'reg' in addition to 'offset' for the register address. Add support to the driver to get the address from 'reg'.

---
The binding change landed, but v2[1] was never applied. The last resend[2] may have missed kernel.org addresses.

[1] https://lore.kernel.org/all/[email protected]/
[2] https://lore.kernel.org/all/[email protected]/

 drivers/leds/leds-syscon.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/leds/leds-syscon.c +2 -1
index 360a376fa738..d633ad519d0c 100644
@@ -81,7 +81,8 @@ static int syscon_led_probe(struct platform_device *pdev)
 
 	sled->map = map;
 
-	if (of_property_read_u32(np, "offset", &sled->offset))
+	if (of_property_read_u32(np, "reg", &sled->offset) &&
+	    of_property_read_u32(np, "offset", &sled->offset))
 		return -EINVAL;
 	if (of_property_read_u32(np, "mask", &sled->mask))
 		return -EINVAL;
Signature · 1 line
2.42.0
maintainer
#1 lore raw
Quoted 10 lines · Rob Herring

The register-bit-led binding now also supports 'reg' in addition to 'offset' for the register address. Add support to the driver to get the address from 'reg'.

---
The binding change landed, but v2[1] was never applied. The last resend[2] may have missed kernel.org addresses.

Quoted 5 lines

[1] https://lore.kernel.org/all/[email protected]/
[2] https://lore.kernel.org/all/[email protected]/

 drivers/leds/leds-syscon.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Looks like I just applied the last one. I'm assuming no additional changes, but please let me know if that's not the case.

Signature · 1 line
Lee Jones [李琼斯]