Couple of fixes to guc_pc tests
cover Couple of fixes to guc_pc tests
Couple of fixes to guc_pc tests
Badal Nilawar (2):
test/intel/xe_guc_pc: Skip freq_*_idle tests on PVC test/intel/xe_guc_pc: Fix freq_low_max test
tests/intel/xe_guc_pc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Signature · 1 line
2.25.1
PATCH 1/2 test/intel/xe_guc_pc: Skip freq_*_idle tests on PVC
PVC does not support RC6 so skip freq_fixed_idle and freq_range_idle tests.
--- tests/intel/xe_guc_pc.c | 2 ++ 1 file changed, 2 insertions(+)
tests/intel/xe_guc_pc.c +2 -0
@@ -295,6 +295,7 @@ igt_main } igt_subtest("freq_fixed_idle") { +igt_require (!IS_PONTEVECCHIO (xe_dev_id (fd)));xe_for_each_gt (fd, gt) {igt_require_f (igt_wait (xe_is_gt_in_c6 (fd, gt),1000 ,10 ),"GT %d should be in C6\n" , gt);
@@ -303,6 +304,7 @@ igt_main } igt_subtest("freq_range_idle") { +igt_require (!IS_PONTEVECCHIO (xe_dev_id (fd)));xe_for_each_gt (fd, gt) {igt_require_f (igt_wait (xe_is_gt_in_c6 (fd, gt),1000 ,10 ),"GT %d should be in C6\n" , gt);
Signature · 1 line
2.25.1
Re: [igt-dev] [PATCH i-g-t 1/2] test/intel/xe_guc_pc: Skip freq_*_idle tests on PVC
Quoted 33 lines
-----Original Message-----
From: igt-dev <[email protected]> On Behalf Of Badal Nilawar
Sent: Friday, November 24, 2023 4:00 PM
To: [email protected]
Subject: [igt-dev] [PATCH i-g-t 1/2] test/intel/xe_guc_pc: Skip freq_*_idle tests on PVCPVC does not support RC6 so skip
freq_fixed_idleandfreq_range_idletests.Signed-off-by Badal Nilawar <[email protected]>---
tests/intel/xe_guc_pc.c| 2 ++1 file changed, 2 insertions(+)tests/intel/xe_guc_pc.c index renamed from tests/intel/xe_guc_pc.c +0
-0
3376e838f..c23017501100644tests/intel/xe_guc_pc.c +1
-0@@ -295,6 +295,7 @@ igt_main } igt_subtest("freq_fixed_idle") { +igt_require (!IS_PONTEVECCHIO (xe_dev_id (fd)));xe_for_each_gt (fd, gt) { igt_require_f(igt_wait(xe_is_gt_in_c6(fd, gt), 1000, 10),"GT %d should be in C6\n", gt); @@ -303,6 +304,7 @@ igt_main } igt_subtest("freq_range_idle") {
tests/intel/xe_guc_pc.c
Quoted 1 line
tests/intel/xe_guc_pc.c +1
-0+igt_require (!IS_PONTEVECCHIO (xe_dev_id (fd)));
LGTM
Quoted 6 lines
xe_for_each_gt(fd, gt) { igt_require_f(igt_wait(xe_is_gt_in_c6(fd, gt), 1000, 10), "GT %d should be in C6\n", gt);--
2.25.1
PATCH 2/2 test/intel/xe_guc_pc: Fix freq_low_max test
In reply to Badal Nilawarfreq_low_max test is intended to validate GuC PC (SLPC) behaviour when max freq set to less than min freq. As workloads are not being run validating cur freq is enough.
--- tests/intel/xe_guc_pc.c | 1 - 1 file changed, 1 deletion(-)
tests/intel/xe_guc_pc.c +0 -1
@@ -220,7 +220,6 @@ static void test_freq_low_max(int fd, int gt_id)igt_assert (set_freq (fd, gt_id,"max" , rpn) >0 );usleep (ACT_FREQ_LATENCY_US );igt_assert (get_freq (fd, gt_id,"cur" ) == rpe); -igt_assert (get_freq (fd, gt_id,"act" ) == rpe); }/**
Signature · 1 line
2.25.1
Re: [igt-dev] [PATCH i-g-t 2/2] test/intel/xe_guc_pc: Fix freq_low_max test
Quoted 14 lines · Badal Nilawar
freq_low_maxtest is intended to validate GuC PC (SLPC) behaviour when max freq set to less than min freq. As workloads are not being run validating cur freq is enough.Signed-off-by Badal Nilawar <[email protected]>--- tests/intel/xe_guc_pc.c | 1 - 1 file changed, 1 deletion(-)tests/intel/xe_guc_pc.c +0
-0
tests/intel/xe_guc_pc.c static void test_freq_low_max(int fd, int gt_id) · line 223
Quoted 4 lines
tests/intel/xe_guc_pc.c +0
-1@@ -220,7 +220,6 @@ static void test_freq_low_max(int fd, int gt_id)igt_assert (set_freq (fd, gt_id,"max" , rpn) >0 );usleep (ACT_FREQ_LATENCY_US );igt_assert (get_freq (fd, gt_id,"cur" ) == rpe); -igt_assert (get_freq (fd, gt_id,"act" ) == rpe);
might be worth keeping this check with if (!in_rc6()). We hardly check for actual frequency, this will be a good way to ensure we can even get efficient freq.
Thanks,
Vinay.
Quoted 3 lines
tests/intel/xe_guc_pc.c +0
-0}/**
Patchwork
CI[igt-dev] ✗ Fi.CI.BAT: failure for Couple of fixes to guc_pc tests
In reply to Badal Nilawar== Series Details ==
== Series Details ==
Series: Couple of fixes to guc_pc tests
URL : https://patchwork.freedesktop.org/series/126869/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13920 -> IGTPW_10265
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_10265 absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_10265, please notify your bug team ([email protected]) to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10265/index.html
Participating hosts (38 -> 38)
------------------------------
Additional (1): fi-bsw-n3050
Missing (1): fi-snb-2520m
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_10265:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@hangcheck:
- bat-dg2-11: [PASS][1] -> [DMESG-FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13920/bat-dg2-11/igt@i915_selftest@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10265/bat-dg2-11/igt@i915_selftest@[email protected]
Known issues
------------
Here are the changes found in IGTPW_10265 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s3@smem:
- fi-rkl-11600: [PASS][3] -> [FAIL][4] ([fdo#103375])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13920/fi-rkl-11600/igt@gem_exec_suspend@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10265/fi-rkl-11600/igt@gem_exec_suspend@[email protected]
* igt@gem_lmem_swapping@random-engines:
- fi-bsw-n3050: NOTRUN -> [SKIP][5] ([fdo#109271]) +14 other tests skip
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10265/fi-bsw-n3050/igt@[email protected]
* igt@i915_selftest@live@hangcheck:
- bat-adls-5: [PASS][6] -> [DMESG-WARN][7] ([i915#5591])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13920/bat-adls-5/igt@i915_selftest@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10265/bat-adls-5/igt@i915_selftest@[email protected]
* igt@kms_hdmi_inject@inject-audio:
- fi-bsw-n3050: NOTRUN -> [FAIL][8] ([IGT#152])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10265/fi-bsw-n3050/igt@[email protected]
* igt@kms_pipe_crc_basic@read-crc-frame-sequence:
- bat-adlp-11: NOTRUN -> [SKIP][9] ([i915#1845] / [i915#3546])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10265/bat-adlp-11/igt@[email protected]
* igt@kms_pipe_crc_basic@read-crc@pipe-d-dp-5:
- bat-adlp-11: [PASS][10] -> [DMESG-WARN][11] ([i915#6868])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13920/bat-adlp-11/igt@kms_pipe_crc_basic@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10265/bat-adlp-11/igt@kms_pipe_crc_basic@[email protected]
#### Possible fixes ####
* igt@i915_selftest@live@gem_contexts:
- bat-mtlp-6: [DMESG-FAIL][12] ([i915#9579]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13920/bat-mtlp-6/igt@i915_selftest@live@gem_contexts.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10265/bat-mtlp-6/igt@i915_selftest@live@gem_contexts.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[IGT#152]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/152
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#5591]: https://gitlab.freedesktop.org/drm/intel/issues/5591
[i915#6868]: https://gitlab.freedesktop.org/drm/intel/issues/6868
[i915#8668]: https://gitlab.freedesktop.org/drm/intel/issues/8668
[i915#9579]: https://gitlab.freedesktop.org/drm/intel/issues/9579
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7601 -> IGTPW_10265
CI-20190529: 20190529
CI_DRM_13920: 278e4673d0a5f5cd5d0b585df88cbcb6d3afd0d8 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_10265: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10265/index.html
IGT_7601: 9c6e7f255724e327627be7c8ed30e23742e97386 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10265/index.html
Patchwork
CI[igt-dev] ✓ CI.xeBAT: success for Couple of fixes to guc_pc tests
In reply to Badal Nilawar== Series Details ==
== Series Details ==
Series: Couple of fixes to guc_pc tests
URL : https://patchwork.freedesktop.org/series/126869/
State : success
== Summary ==
CI Bug Log - changes from XEIGT_7601_BAT -> XEIGTPW_10265_BAT
====================================================
Summary
-------
**WARNING**
Minor unknown changes coming with XEIGTPW_10265_BAT need to be verified manually.
If you think the reported changes have nothing to do with the changes
introduced in XEIGTPW_10265_BAT, please notify your bug team ([email protected]) to allow them to document this new failure mode, which will reduce false positives in CI.
Participating hosts (4 -> 4)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in XEIGTPW_10265_BAT:
### IGT changes ###
#### Warnings ####
* igt@xe_guc_pc@freq_range_idle:
- bat-pvc-2: [SKIP][1] ([Intel XE#533]) -> [SKIP][2] +1 other test skip
[1]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7601/bat-pvc-2/igt@xe_guc_pc@freq_range_idle.html
[2]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10265/bat-pvc-2/igt@xe_guc_pc@freq_range_idle.html
Known issues
------------
Here are the changes found in XEIGTPW_10265_BAT that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_flip@basic-flip-vs-wf_vblank@d-dp3:
- bat-dg2-oem2: [PASS][3] -> [FAIL][4] ([Intel XE#480]) +1 other test fail
[3]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7601/bat-dg2-oem2/igt@kms_flip@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10265/bat-dg2-oem2/igt@kms_flip@[email protected]
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-d-dp-3:
- bat-dg2-oem2: NOTRUN -> [FAIL][5] ([Intel XE#400] / [Intel XE#616])
[5]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10265/bat-dg2-oem2/igt@kms_pipe_crc_basic@[email protected]
* igt@xe_exec_fault_mode@many-basic:
- bat-dg2-oem2: NOTRUN -> [SKIP][6] ([Intel XE#288]) +17 other tests skip
[6]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10265/bat-dg2-oem2/igt@[email protected]
#### Possible fixes ####
* igt@kms_pipe_crc_basic@hang-read-crc:
- bat-dg2-oem2: [INCOMPLETE][7] ([Intel XE#282] / [Intel XE#749]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7601/bat-dg2-oem2/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10265/bat-dg2-oem2/igt@[email protected]
* igt@kms_pipe_crc_basic@hang-read-crc@pipe-a-dp-3:
- bat-dg2-oem2: [INCOMPLETE][9] ([Intel XE#282] / [Intel XE#545]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7601/bat-dg2-oem2/igt@kms_pipe_crc_basic@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10265/bat-dg2-oem2/igt@kms_pipe_crc_basic@[email protected]
#### Warnings ####
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12:
- bat-dg2-oem2: [TIMEOUT][11] ([Intel XE#430] / [Intel XE#530]) -> [FAIL][12] ([Intel XE#400] / [Intel XE#616])
[11]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7601/bat-dg2-oem2/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10265/bat-dg2-oem2/igt@[email protected]
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-b-dp-3:
- bat-dg2-oem2: [TIMEOUT][13] ([Intel XE#530]) -> [FAIL][14] ([Intel XE#400] / [Intel XE#616])
[13]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7601/bat-dg2-oem2/igt@kms_pipe_crc_basic@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10265/bat-dg2-oem2/igt@kms_pipe_crc_basic@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[Intel XE#282]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/282
[Intel XE#288]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/288
[Intel XE#400]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/400
[Intel XE#430]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/430
[Intel XE#480]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/480
[Intel XE#530]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/530
[Intel XE#533]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/533
[Intel XE#545]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/545
[Intel XE#616]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/616
[Intel XE#749]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/749
[Intel XE#929]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/929
Build changes
-------------
* IGT: IGT_7601 -> IGTPW_10265
IGTPW_10265: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10265/index.html
IGT_7601: 9c6e7f255724e327627be7c8ed30e23742e97386 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
xe-518-1832821c7e4c5bd24353183f060f1435b2eb7992: 1832821c7e4c5bd24353183f060f1435b2eb7992
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10265/index.html