btrfs: send: Ensure send_fd is writable
PATCH 1/1 btrfs: send: Ensure send_fd is writable
kernel_write() requires the caller to ensure that the file is writable. Let's do that directly after looking up the ->send_fd.
(We don't need a separate bailout path because the "out" path already does fput() if ->send_filp is non-NULL.)
This has no security impact for two reasons:
- the ioctl requires CAP_SYS_ADMIN
- __kernel_write() bails out on read-only files - but only since 5.8, see commit a01ac27be472 ("fs: check FMODE_WRITE in __kernel_write")
--- fs/btrfs/send.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/btrfs/send.c +1 -1
@@ -8158,7 +8158,7 @@ long btrfs_ioctl_send(struct inode *inode, struct btrfs_ioctl_send_args *arg) } sctx->send_filp =fget (arg->send_fd); -if (!sctx->send_filp) { +if (!sctx->send_filp || !(sctx->send_filp->f_mode &FMODE_WRITE )) { ret = -EBADF ; goto out; }
base-commit: 98b1cc82c4affc16f5598d4fa14b1858671b2263
Signature · 1 line
2.43.0.rc1.413.gea7ed67945-goog
Quoted 12 lines · Jann Horn
kernel_write()requires the caller to ensure that the file is writable. Let's do that directly after looking up the ->send_fd.(We don't need a separate bailout path because the "out" path already does
fput()if ->send_filp is non-NULL.)This has no security impact for two reasons:
- the ioctl requires
CAP_SYS_ADMIN
-__kernel_write()bails out on read-only files - but only since 5.8, see commita01ac27be472("fs: checkFMODE_WRITEin__kernel_write")
Quoted 5 lines
Reported-and-tested-by [email protected]Fixes 31db9f7c23fb ("Btrfs: introduce BTRFS_IOC_SEND for btrfs send/receive")Signed-off-by Jann Horn <[email protected]>
Added to misc-next, thanks.