FAILED: patch "[PATCH] drm/amd/display: Fix encoder disable logic" failed to apply to 6.6-stable tree
[email protected]
maintainerThe patch below does not apply to the 6.6-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
To reproduce the conflict and resubmit, you may use the following commands:
git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.6.y
git checkout FETCH_HEAD
git cherry-pick -x 0ee057e66c4b782809a0a9265cdac5542e646706
# <resolve conflicts, build, test, etc.>
git commit -s
git send-email --to '<[email protected]>' --in-reply-to '2023112431-saga-deflector-404c@gregkh' --subject-prefix 'PATCH 6.6.y' HEAD^..
Possible dependencies:
0ee057e66c4b ("drm/amd/display: Fix encoder disable logic") e0b394a87a11 ("drm/amd/display: Add DCN35 DIO")
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
From 0ee057e66c4b782809a0a9265cdac5542e646706 Mon Sep 17 00:00:00 2001
From: Nicholas Susanto <[email protected]>
Date: Wed, 1 Nov 2023 15:30:10 -0400
Subject: [PATCH] drm/amd/display: Fix encoder disable logic
[WHY]
DENTIST hangs when OTG is off and encoder is on. We were not disabling the encoder properly when switching from extended mode to external monitor only.
[HOW]
Disable the encoder using an existing enable/disable fifo helper instead of enc35_stream_encoder_enable.
drivers/gpu/drm/amd/display/dc/dcn35/dcn35_dio_stream_encoder.c +4 -6
@@ -261,12 +261,6 @@ static void enc35_stream_encoder_enable(/* invalid mode ! */ ASSERT_CRITICAL (false); } - -REG_UPDATE (DIG_FE_CLK_CNTL ,DIG_FE_CLK_EN ,1 ); -REG_UPDATE (DIG_FE_EN_CNTL ,DIG_FE_ENABLE ,1 ); - }else { -REG_UPDATE (DIG_FE_EN_CNTL ,DIG_FE_ENABLE ,0 ); -REG_UPDATE (DIG_FE_CLK_CNTL ,DIG_FE_CLK_EN ,0 ); } }
@@ -436,6 +430,8 @@ static void enc35_disable_fifo(struct stream_encoder *enc)struct dcn10_stream_encoder *enc1 =DCN10STRENC_FROM_STRENC (enc);REG_UPDATE (DIG_FIFO_CTRL0 ,DIG_FIFO_ENABLE ,0 ); +REG_UPDATE (DIG_FE_EN_CNTL ,DIG_FE_ENABLE ,0 ); +REG_UPDATE (DIG_FE_CLK_CNTL ,DIG_FE_CLK_EN ,0 ); }static void enc35_enable_fifo (struct stream_encoder *enc)
@@ -443,6 +439,8 @@ static void enc35_enable_fifo(struct stream_encoder *enc)struct dcn10_stream_encoder *enc1 =DCN10STRENC_FROM_STRENC (enc);REG_UPDATE (DIG_FIFO_CTRL0 ,DIG_FIFO_READ_START_LEVEL ,0x7 ); +REG_UPDATE (DIG_FE_CLK_CNTL ,DIG_FE_CLK_EN ,1 ); +REG_UPDATE (DIG_FE_EN_CNTL ,DIG_FE_ENABLE ,1 );enc35_reset_fifo (enc, true);enc35_reset_fifo (enc, false);