media: chips-media: Remove surplus dev_err() when using platform_get_irq()
Subsystems (2)
PATCH 1/1 media: chips-media: Remove surplus dev_err() when using platform_get_irq()
There is no need to call the dev_err() function directly to print a custom message when handling an error from either the platform_get_irq() or platform_get_irq_byname() functions as both are going to display an appropriate error message in case of a failure.
--- drivers/media/platform/chips-media/wave5/wave5-vpu.c | 1 - 1 file changed, 1 deletion(-)
drivers/media/platform/chips-media/wave5/wave5-vpu.c +0 -1
@@ -209,7 +209,6 @@ static int wave5_vpu_probe(struct platform_device *pdev) dev->irq =platform_get_irq (pdev,0 );if (dev->irq <0 ) { -dev_err (&pdev->dev,"failed to get irq resource\n" ); ret = -ENXIO ; goto err_enc_unreg; }
Signature · 1 line
2.20.1.7.g153144c
Hey Yang,
Thanks for the patch!
The commit subject line should point to the respective driver and you can drop the brackets, so:media: chips-media: wave5: Remove surplus dev_err when using platform_get_irq
Greetings,
Sebastian
Quoted 28 lines · Yang Li
There is no need to call the
dev_err()function directly to print a custom message when handling an error from either theplatform_get_irq()orplatform_get_irq_byname()functions as both are going to display an appropriate error message in case of a failure.Reported-by Abaci Robot <[email protected]>Signed-off-by Yang Li <[email protected]>---
drivers/media/platform/chips-media/wave5/wave5-vpu.c| 1 -1 file changed, 1 deletion(-)drivers/media/platform/chips-media/wave5/wave5-vpu.c +0
-1@@ -209,7 +209,6 @@ static int wave5_vpu_probe(struct platform_device *pdev) dev->irq =platform_get_irq (pdev,0 );if (dev->irq <0 ) { -dev_err (&pdev->dev,"failed to get irq resource\n" ); ret = -ENXIO ; goto err_enc_unreg; }Signature · 1 line
2.20.1.7.g153144c