Skip to contentSkip to conversation

Patch "bpf: Fix dev's rx stats for bpf_redirect_peer traffic" has been added to the 6.6-stable tree

DISCUSSION Peilin Ye 2 participants 2 messages Nov 29, 2023 1 message not in the archive Stable branch

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Peilin Ye

author
#1 lore raw

+Cc: Cong Wang <[email protected]>

Hi all,

Quoted 8 lines · Sasha Levin

This is a note to let you know that I've just added the patch titled

bpf: Fix dev's rx stats for bpf_redirect_peer traffic

to the 6.6-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

Quoted 6 lines

The filename of the patch is:
bpf-fix-dev-s-rx-stats-for-bpf_redirect_peer-traffic.patch
and it can be found in the queue-6.6 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Seems like only patch 1, 2 and 5 in this [1] series are selected? We also need patch 4, upstream commit 6f2684bf2b44 ("veth: Use tstats per-CPU traffic counters"). Otherwise the fix won't work, and the code will be wrong [2] .

We should've included a "Depends on patch..." note for stable in the commit message.

Thanks,
Peilin Ye

[1] https://lore.kernel.org/all/170050562585.4532.1588179408610417971.git-patchwork-notify@kernel.org/
[2] veth still uses @lstats, but patch 5 makes skb_do_redirect() update
it as @tstats.

maintainer
#2 lore raw
Quoted 20 lines · Peilin Ye

+Cc: Cong Wang <[email protected]>

Hi all,

Quoted 8 lines · Sasha Levin

This is a note to let you know that I've just added the patch titled

bpf: Fix dev's rx stats for bpf_redirect_peer traffic

to the 6.6-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

Quoted 6 lines

The filename of the patch is:
bpf-fix-dev-s-rx-stats-for-bpf_redirect_peer-traffic.patch
and it can be found in the queue-6.6 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 7 lines

Seems like only patch 1, 2 and 5 in this [1] series are selected? We also need patch 4, upstream commit 6f2684bf2b44 ("veth: Use tstats per-CPU traffic counters"). Otherwise the fix won't work, and the code will be wrong [2] .

We should've included a "Depends on patch..." note for stable in the commit message.

I'll take it too, thanks!

Signature · 2 lines
Thanks,
Sasha