Add FBC support to PSR/PSR2 tests
cover Add FBC support to PSR/PSR2 tests
Jeevan B (2):
tests/intel/kms_psr: Add FBC support to PSR/PSR2/PR tests tests/intel/kms_psr2_sf: Add FBC support to PSR2 tests
lib/igt_psr.h | 5 + tests/intel/kms_psr.c | 468 +++++++++++++++++++---------- tests/intel/kms_psr2_sf.c | 609 +++++++++++++++++++++----------------- 3 files changed, 657 insertions(+), 425 deletions(-)
Signature · 1 line
2.25.1
PATCH 1/2 tests/intel/kms_psr: Add FBC support to PSR/PSR2/PR tests
For LunarLake (intel_display_ver 20), FBC can be enabled along with PSR/PSR2/PR, thereby adding FBC checks to validate this scenario.
--- lib/igt_psr.h | 5 + tests/intel/kms_psr.c | 468 ++++++++++++++++++++++++++++-------------- 2 files changed, 319 insertions(+), 154 deletions(-)
lib/igt_psr.h +5 -0
@@ -40,6 +40,11 @@ enum psr_mode { PSR_DISABLED, }; +enum fbc_mode { +FBC_ENABLED , +FBC_DISABLED , +}; +bool psr_disabled_check (int debugfs_fd);bool psr2_selective_fetch_check (int debugfs_fd);bool psr_wait_entry (int debugfs_fd,enum psr_mode mode,igt_output_t *output);
tests/intel/kms_psr.c +314 -154
749 lines not on this page · raw message
Signature · 1 line
2.25.1
PATCH 2/2 tests/intel/kms_psr2_sf: Add FBC support to PSR2 tests
In reply to Jeevan BFor LunarLake (intel_display_ver 20), FBC can be enabled along with PSR2, thereby adding FBC checks to validate this scenario.
--- tests/intel/kms_psr2_sf.c | 609 +++++++++++++++++++++----------------- 1 file changed, 338 insertions(+), 271 deletions(-)
tests/intel/kms_psr2_sf.c +338 -271
@@ -37,6 +37,7 @@#include "igt_sysfs.h" #include "igt_psr.h" #include "kms_dsc_helper.h" +#include "i915/intel_fbc.h" #include <errno.h> #include <stdbool.h> #include <stdio.h>
@@ -47,6 +48,10 @@* Description: Test that selective fetch works on moving %arg[1] plane %arg[2] * visible area (no update) * +* SUBTEST: fbc-%s-plane-move-continuous-%s +* Description: Test that fbc with selective fetch works on moving %arg[1] plane %arg[2] +* visible area (no update) +* * arg[1]: * * @cursor: Cursor
@@ -63,24 +68,46 @@* SUBTEST: cursor-plane-update-sf * Description: Test that selective fetch works on cursor plane * +* SUBTEST: fbc-cursor-plane-update-continuous-sf +* Description: Test that fbc with selective fetch works on cursor plane +* * SUBTEST: overlay-plane-update-continuous-sf * Description: Test that selective fetch works on overlay plane * +* SUBTEST: fbc-overlay-plane-update-continuous-sf +* Description: Test that fbc with selective fetch works on overlay plane +* * SUBTEST: overlay-plane-update-sf-dmg-area * Description: Test that selective fetch works on overlay plane * +* SUBTEST: fbc-overlay-plane-update-continuous-sf-dmg-area +* Description: Test that fbc with selective fetch works on overlay plane +* * SUBTEST: overlay-primary-update-sf-dmg-area * Description: Test that selective fetch works on primary plane with blended * overlay plane * +* SUBTEST: fbc-overlay-primary-update-sf-dmg-area +* Description: Test that fbc with selective fetch works on primary plane with blended +* overlay plane +* * SUBTEST: plane-move-sf-dmg-area * Description: Test that selective fetch works on moving overlay plane * +* SUBTEST: fbc-plane-move-sf-dmg-area +* Description: Test that fbc with selective fetch works on moving overlay plane +* * SUBTEST: primary-plane-update-sf-dmg-area * Description: Test that selective fetch works on primary plane * +* SUBTEST: fbc-primary-plane-update-continuous-sf-dmg-area +* Description: Test that fbc with selective fetch works on primary plane +* * SUBTEST: primary-plane-update-sf-dmg-area-big-fb * Description: Test that selective fetch works on primary plane with big fb +* +* SUBTEST: fbc-primary-plane-update-continuous-sf-dmg-area-big-fb +* Description: Test that fbc with selective fetch works on primary plane with big fb */ IGT_TEST_DESCRIPTION("Tests to varify PSR2 selective fetch by sending multiple"
@@ -132,9 +159,11 @@ typedef struct {struct drm_mode_rect cursor_clip;enum operations op;enum plane_move_postion pos; +enum fbc_mode op_fbc_mode;int test_plane_id;igt_plane_t *test_plane;bool big_fb_test; +bool fbc_flag;cairo_t *cr;uint32_t screen_changes;int cur_x, cur_y;
@@ -840,6 +869,11 @@ static void run(data_t *data)igt_assert (psr_wait_entry (data->debugfs_fd,PSR_MODE_2 ,NULL )); +if (data->fbc_flag) +igt_assert_f (intel_fbc_wait_until_enabled (data->drm_fd, + data->pipe), +"FBC still disabled" ); + data->screen_changes =0 ;switch (data->op) {
@@ -942,10 +976,15 @@ igt_main {data_t data = {};igt_output_t *outputs[IGT_MAX_PIPES *IGT_MAX_PIPES ]; -int i, j, k; +int i, j, k, y;int pipes[IGT_MAX_PIPES *IGT_MAX_PIPES ];int n_pipes =0 ;int coexist_features[IGT_MAX_PIPES *IGT_MAX_PIPES ]; +const char *append_fbc_subtest[2 ] = { +"" , +"fbc-" + }; +int fbc_status[] = {FBC_DISABLED ,FBC_ENABLED }; igt_fixture {drmModeResPtr res;
@@ -961,6 +1000,11 @@ igt_maindisplay_init (&data); +if ((intel_display_ver (intel_get_drm_devid (data.drm_fd) ==20 )) && + (intel_fbc_supported_on_chipset (data.drm_fd, data.pipe))) { + data.fbc_flag = true; + } +/* Test if PSR2 can be enabled */ igt_require_f(psr_enable(data.drm_fd, data.debugfs_fd, PSR_MODE_2_SEL_FETCH),
@@ -995,54 +1039,119 @@ igt_main } } -/* Verify primary plane selective fetch */ -igt_describe ("Test that selective fetch works on primary plane" ); - igt_subtest_with_dynamic_f("primary-%s-sf-dmg-area", op_str(data.op)) { -for (i =0 ; i < n_pipes; i++) { -if (!pipe_output_combo_valid (&data.display, pipes[i], outputs[i])) -continue ; +for (y =0 ; y <ARRAY_SIZE (fbc_status); y++) { + data.op_fbc_mode = fbc_status[y]; +if (data.op_fbc_mode ==FBC_DISABLED ) + data.fbc_flag = false; + +/* Verify primary plane selective fetch */ +igt_describe ("Test that selective fetch works on primary plane" ); +igt_subtest_with_dynamic_f ("%sprimary-%s-sf-dmg-area" , append_fbc_subtest[y], + op_str(data.op)) { +for (i =0 ; i < n_pipes; i++) { +if (!pipe_output_combo_valid (&data.display, pipes[i], outputs[i])) +continue ; -for (j =FEATURE_NONE ; j <FEATURE_COUNT ; j++) { -if (j !=FEATURE_NONE && !(coexist_features[i] & j)) +for (j =FEATURE_NONE ; j <FEATURE_COUNT ; j++) { +if (j !=FEATURE_NONE && !(coexist_features[i] & j)) +continue ; +igt_dynamic_f ("pipe-%s-%s%s" ,kmstest_pipe_name (pipes[i]), +igt_output_name (outputs[i]), + coexist_feature_str(j)) { + data.pipe = pipes[i]; + data.output = outputs[i]; + data.test_plane_id =DRM_PLANE_TYPE_PRIMARY ; + data.coexist_feature = j; +for (k =1 ; k <=MAX_DAMAGE_AREAS ; k++) { + data.damage_area_count = k; +prepare (&data); +run (&data); +cleanup (&data); + } + } + } + } + } + +/* Verify primary plane selective fetch with big fb */ + data.big_fb_test =1 ; +igt_describe ("Test that selective fetch works on primary plane with big fb" ); +igt_subtest_with_dynamic_f ("%sprimary-%s-sf-dmg-area-big-fb" , append_fbc_subtest[y], + op_str(data.op)) { +for (i =0 ; i < n_pipes; i++) { +if (!pipe_output_combo_valid (&data.display, pipes[i], outputs[i]))continue ; -igt_dynamic_f ("pipe-%s-%s%s" ,kmstest_pipe_name (pipes[i]), -igt_output_name (outputs[i]), - coexist_feature_str(j)) { - data.pipe = pipes[i]; - data.output = outputs[i]; - data.test_plane_id =DRM_PLANE_TYPE_PRIMARY ; - data.coexist_feature = j; -for (k =1 ; k <=MAX_DAMAGE_AREAS ; k++) { - data.damage_area_count = k; -prepare (&data); -run (&data); -cleanup (&data); + +for (j =FEATURE_NONE ; j <FEATURE_COUNT ; j++) { +if (j !=FEATURE_NONE && !(coexist_features[i] & j)) +continue ; +igt_dynamic_f ("pipe-%s-%s%s" ,kmstest_pipe_name (pipes[i]), +igt_output_name (outputs[i]), + coexist_feature_str(j)) { + data.pipe = pipes[i]; + data.output = outputs[i]; + data.test_plane_id =DRM_PLANE_TYPE_PRIMARY ; + data.coexist_feature = j; +for (k =1 ; k <=MAX_DAMAGE_AREAS ; k++) { + data.damage_area_count = k; +prepare (&data); +run (&data); +cleanup (&data); + } } } } } - } -/* Verify primary plane selective fetch with big fb */ - data.big_fb_test =1 ; -igt_describe ("Test that selective fetch works on primary plane with big fb" ); - igt_subtest_with_dynamic_f("primary-%s-sf-dmg-area-big-fb", op_str(data.op)) { -for (i =0 ; i < n_pipes; i++) { -if (!pipe_output_combo_valid (&data.display, pipes[i], outputs[i])) -continue ; + data.big_fb_test =0 ; +/* Verify overlay plane selective fetch */ +igt_describe ("Test that selective fetch works on overlay plane" ); +igt_subtest_with_dynamic_f ("%soverlay-%s-sf-dmg-area" , append_fbc_subtest[y], + op_str(data.op)) { +for (i =0 ; i < n_pipes; i++) { +if (!pipe_output_combo_valid (&data.display, pipes[i], outputs[i])) +continue ; + +for (j =FEATURE_NONE ; j <FEATURE_COUNT ; j++) { +if (j !=FEATURE_NONE && !(coexist_features[i] & j)) +continue ; +igt_dynamic_f ("pipe-%s-%s%s" ,kmstest_pipe_name (pipes[i]), +igt_output_name (outputs[i]), + coexist_feature_str(j)) { + data.pipe = pipes[i]; + data.output = outputs[i]; + data.test_plane_id =DRM_PLANE_TYPE_OVERLAY ; + data.coexist_feature = j; +for (k =1 ; k <=MAX_DAMAGE_AREAS ; k++) { + data.damage_area_count = k; +prepare (&data); +run (&data); +cleanup (&data); + } + } + } + } + } -for (j =FEATURE_NONE ; j <FEATURE_COUNT ; j++) { -if (j !=FEATURE_NONE && !(coexist_features[i] & j)) + data.damage_area_count =1 ; +/* Verify cursor plane selective fetch */ +igt_describe ("Test that selective fetch works on cursor plane" ); +igt_subtest_with_dynamic_f ("%scursor-%s-sf" , append_fbc_subtest[y], + op_str(data.op)) { +for (i =0 ; i < n_pipes; i++) { +if (!pipe_output_combo_valid (&data.display, pipes[i], outputs[i]))continue ; -igt_dynamic_f ("pipe-%s-%s%s" ,kmstest_pipe_name (pipes[i]), -igt_output_name (outputs[i]), - coexist_feature_str(j)) { - data.pipe = pipes[i]; - data.output = outputs[i]; - data.test_plane_id =DRM_PLANE_TYPE_PRIMARY ; - data.coexist_feature = j; -for (k =1 ; k <=MAX_DAMAGE_AREAS ; k++) { - data.damage_area_count = k; + +for (j =FEATURE_NONE ; j <FEATURE_COUNT ; j++) { +if (j !=FEATURE_NONE && !(coexist_features[i] & j)) +continue ; +igt_dynamic_f ("pipe-%s-%s%s" ,kmstest_pipe_name (pipes[i]), +igt_output_name (outputs[i]), + coexist_feature_str(j)) { + data.pipe = pipes[i]; + data.output = outputs[i]; + data.test_plane_id =DRM_PLANE_TYPE_CURSOR ; + data.coexist_feature = j;prepare (&data);run (&data);cleanup (&data);
@@ -1050,28 +1159,25 @@ igt_main } } } - } - - data.big_fb_test =0 ; -/* Verify overlay plane selective fetch */ -igt_describe ("Test that selective fetch works on overlay plane" ); - igt_subtest_with_dynamic_f("overlay-%s-sf-dmg-area", op_str(data.op)) { -for (i =0 ; i < n_pipes; i++) { -if (!pipe_output_combo_valid (&data.display, pipes[i], outputs[i])) -continue ; -for (j =FEATURE_NONE ; j <FEATURE_COUNT ; j++) { -if (j !=FEATURE_NONE && !(coexist_features[i] & j)) + data.op =PLANE_MOVE_CONTINUOUS ; +igt_describe ("Test that selective fetch works on moving cursor plane (no update)" ); +igt_subtest_with_dynamic_f ("%scursor-%s-sf" , append_fbc_subtest[y], + op_str(data.op)) { +for (i =0 ; i < n_pipes; i++) { +if (!pipe_output_combo_valid (&data.display, pipes[i], outputs[i]))continue ; -igt_dynamic_f ("pipe-%s-%s%s" ,kmstest_pipe_name (pipes[i]), -igt_output_name (outputs[i]), - coexist_feature_str(j)) { - data.pipe = pipes[i]; - data.output = outputs[i]; - data.test_plane_id =DRM_PLANE_TYPE_OVERLAY ; - data.coexist_feature = j; -for (k =1 ; k <=MAX_DAMAGE_AREAS ; k++) { - data.damage_area_count = k; + +for (j =FEATURE_NONE ; j <FEATURE_COUNT ; j++) { +if (j !=FEATURE_NONE && !(coexist_features[i] & j)) +continue ; +igt_dynamic_f ("pipe-%s-%s%s" ,kmstest_pipe_name (pipes[i]), +igt_output_name (outputs[i]), + coexist_feature_str(j)) { + data.pipe = pipes[i]; + data.output = outputs[i]; + data.test_plane_id =DRM_PLANE_TYPE_CURSOR ; + data.coexist_feature = j;prepare (&data);run (&data);cleanup (&data);
@@ -1079,130 +1185,137 @@ igt_main } } } - } - data.damage_area_count =1 ; -/* Verify cursor plane selective fetch */ -igt_describe ("Test that selective fetch works on cursor plane" ); - igt_subtest_with_dynamic_f("cursor-%s-sf", op_str(data.op)) { -for (i =0 ; i < n_pipes; i++) { -if (!pipe_output_combo_valid (&data.display, pipes[i], outputs[i])) -continue ; - -for (j =FEATURE_NONE ; j <FEATURE_COUNT ; j++) { -if (j !=FEATURE_NONE && !(coexist_features[i] & j)) + data.op =PLANE_MOVE_CONTINUOUS_EXCEED ; +igt_describe ("Test that selective fetch works on moving cursor plane exceeding " +"partially visible area (no update)" ); +igt_subtest_with_dynamic_f ("%scursor-%s-sf" , append_fbc_subtest[y], + op_str(data.op)) { +for (i =0 ; i < n_pipes; i++) { +if (!pipe_output_combo_valid (&data.display, pipes[i], outputs[i]))continue ; -igt_dynamic_f ("pipe-%s-%s%s" ,kmstest_pipe_name (pipes[i]), -igt_output_name (outputs[i]), - coexist_feature_str(j)) { - data.pipe = pipes[i]; - data.output = outputs[i]; - data.test_plane_id =DRM_PLANE_TYPE_CURSOR ; - data.coexist_feature = j; -prepare (&data); -run (&data); -cleanup (&data); + +for (j =FEATURE_NONE ; j <FEATURE_COUNT ; j++) { +if (j !=FEATURE_NONE && !(coexist_features[i] & j)) +continue ; +igt_dynamic_f ("pipe-%s-%s%s" ,kmstest_pipe_name (pipes[i]), +igt_output_name (outputs[i]), + coexist_feature_str(j)) { + data.pipe = pipes[i]; + data.output = outputs[i]; + data.test_plane_id =DRM_PLANE_TYPE_CURSOR ; + data.coexist_feature = j; +prepare (&data); +run (&data); +cleanup (&data); + } } } } - } - - data.op =PLANE_MOVE_CONTINUOUS ; -igt_describe ("Test that selective fetch works on moving cursor plane (no update)" ); - igt_subtest_with_dynamic_f("cursor-%s-sf", op_str(data.op)) { -for (i =0 ; i < n_pipes; i++) { -if (!pipe_output_combo_valid (&data.display, pipes[i], outputs[i])) -continue ; -for (j =FEATURE_NONE ; j <FEATURE_COUNT ; j++) { -if (j !=FEATURE_NONE && !(coexist_features[i] & j)) + data.op =PLANE_MOVE_CONTINUOUS_EXCEED_FULLY ; +igt_describe ("Test that selective fetch works on moving cursor plane exceeding " +"fully visible area (no update)" ); +igt_subtest_with_dynamic_f ("%scursor-%s-sf" , append_fbc_subtest[y], + op_str(data.op)) { +for (i =0 ; i < n_pipes; i++) { +if (!pipe_output_combo_valid (&data.display, pipes[i], outputs[i]))continue ; -igt_dynamic_f ("pipe-%s-%s%s" ,kmstest_pipe_name (pipes[i]), -igt_output_name (outputs[i]), - coexist_feature_str(j)) { - data.pipe = pipes[i]; - data.output = outputs[i]; - data.test_plane_id =DRM_PLANE_TYPE_CURSOR ; - data.coexist_feature = j; -prepare (&data); -run (&data); -cleanup (&data); + +for (j =FEATURE_NONE ; j <FEATURE_COUNT ; j++) { +if (j !=FEATURE_NONE && !(coexist_features[i] & j)) +continue ; +igt_dynamic_f ("pipe-%s-%s%s" ,kmstest_pipe_name (pipes[i]), +igt_output_name (outputs[i]), + coexist_feature_str(j)) { + data.pipe = pipes[i]; + data.output = outputs[i]; + data.test_plane_id =DRM_PLANE_TYPE_CURSOR ; + data.coexist_feature = j; +prepare (&data); +run (&data); +cleanup (&data); + } } } } - } - - data.op =PLANE_MOVE_CONTINUOUS_EXCEED ; -igt_describe ("Test that selective fetch works on moving cursor plane exceeding partially visible area (no update)" ); - igt_subtest_with_dynamic_f("cursor-%s-sf", op_str(data.op)) { -for (i =0 ; i < n_pipes; i++) { -if (!pipe_output_combo_valid (&data.display, pipes[i], outputs[i])) -continue ; -for (j =FEATURE_NONE ; j <FEATURE_COUNT ; j++) { -if (j !=FEATURE_NONE && !(coexist_features[i] & j)) +/* Only for overlay plane */ + data.op =PLANE_MOVE ; +/* Verify overlay plane move selective fetch */ +igt_describe ("Test that selective fetch works on moving overlay plane" ); +igt_subtest_with_dynamic_f ("%s%s-sf-dmg-area" , append_fbc_subtest[y], + op_str(data.op)) { +for (i =0 ; i < n_pipes; i++) { +if (!pipe_output_combo_valid (&data.display, pipes[i], outputs[i]))continue ; -igt_dynamic_f ("pipe-%s-%s%s" ,kmstest_pipe_name (pipes[i]), -igt_output_name (outputs[i]), - coexist_feature_str(j)) { - data.pipe = pipes[i]; - data.output = outputs[i]; - data.test_plane_id =DRM_PLANE_TYPE_CURSOR ; - data.coexist_feature = j; -prepare (&data); -run (&data); -cleanup (&data); + +for (j =FEATURE_NONE ; j <FEATURE_COUNT ; j++) { +if (j !=FEATURE_NONE && !(coexist_features[i] & j)) +continue ; +igt_dynamic_f ("pipe-%s-%s%s" ,kmstest_pipe_name (pipes[i]), +igt_output_name (outputs[i]), + coexist_feature_str(j)) { + data.pipe = pipes[i]; + data.output = outputs[i]; + data.test_plane_id =DRM_PLANE_TYPE_OVERLAY ; + data.coexist_feature = j; +for (k =POS_TOP_LEFT ; k <=POS_BOTTOM_RIGHT ; k++) { + data.pos = k; +prepare (&data); +run (&data); +cleanup (&data); + } + } } } } - } - data.op =PLANE_MOVE_CONTINUOUS_EXCEED_FULLY ; -igt_describe ("Test that selective fetch works on moving cursor plane exceeding fully visible area (no update)" ); - igt_subtest_with_dynamic_f("cursor-%s-sf", op_str(data.op)) { -for (i =0 ; i < n_pipes; i++) { -if (!pipe_output_combo_valid (&data.display, pipes[i], outputs[i])) -continue ; - -for (j =FEATURE_NONE ; j <FEATURE_COUNT ; j++) { -if (j !=FEATURE_NONE && !(coexist_features[i] & j)) + data.op =PLANE_MOVE_CONTINUOUS ; +igt_describe ("Test that selective fetch works on moving overlay plane (no update)" ); +igt_subtest_with_dynamic_f ("%soverlay-%s-sf" , append_fbc_subtest[y], + op_str(data.op)) { +for (i =0 ; i < n_pipes; i++) { +if (!pipe_output_combo_valid (&data.display, pipes[i], outputs[i]))continue ; -igt_dynamic_f ("pipe-%s-%s%s" ,kmstest_pipe_name (pipes[i]), -igt_output_name (outputs[i]), - coexist_feature_str(j)) { + +for (j =FEATURE_NONE ; j <FEATURE_COUNT ; j++) { +if (j !=FEATURE_NONE && !(coexist_features[i] & j)) +continue ; +igt_dynamic_f ("pipe-%s-%s%s" ,kmstest_pipe_name (pipes[i]), +igt_output_name (outputs[i]), + coexist_feature_str(j)) { data.pipe = pipes[i]; data.output = outputs[i]; - data.test_plane_id =DRM_PLANE_TYPE_CURSOR ; + data.test_plane_id =DRM_PLANE_TYPE_OVERLAY ; data.coexist_feature = j;prepare (&data);run (&data);cleanup (&data); + } } } } - } -/* Only for overlay plane */ - data.op =PLANE_MOVE ; -/* Verify overlay plane move selective fetch */ -igt_describe ("Test that selective fetch works on moving overlay plane" ); - igt_subtest_with_dynamic_f("%s-sf-dmg-area", op_str(data.op)) { -for (i =0 ; i < n_pipes; i++) { -if (!pipe_output_combo_valid (&data.display, pipes[i], outputs[i])) -continue ; - -for (j =FEATURE_NONE ; j <FEATURE_COUNT ; j++) { -if (j !=FEATURE_NONE && !(coexist_features[i] & j)) + data.op =PLANE_MOVE_CONTINUOUS_EXCEED ; +igt_describe ("Test that selective fetch works on moving overlay plane partially " +"exceeding visible area (no update)" ); +igt_subtest_with_dynamic_f ("%soverlay-%s-sf" , append_fbc_subtest[y], + op_str(data.op)) { +for (i =0 ; i < n_pipes; i++) { +if (!pipe_output_combo_valid (&data.display, pipes[i], outputs[i]))continue ; -igt_dynamic_f ("pipe-%s-%s%s" ,kmstest_pipe_name (pipes[i]), -igt_output_name (outputs[i]), - coexist_feature_str(j)) { - data.pipe = pipes[i]; - data.output = outputs[i]; - data.test_plane_id =DRM_PLANE_TYPE_OVERLAY ; - data.coexist_feature = j; -for (k =POS_TOP_LEFT ; k <=POS_BOTTOM_RIGHT ; k++) { - data.pos = k; + +for (j =FEATURE_NONE ; j <FEATURE_COUNT ; j++) { +if (j !=FEATURE_NONE && !(coexist_features[i] & j)) +continue ; +igt_dynamic_f ("pipe-%s-%s%s" ,kmstest_pipe_name (pipes[i]), +igt_output_name (outputs[i]), + coexist_feature_str(j)) { + data.pipe = pipes[i]; + data.output = outputs[i]; + data.test_plane_id =DRM_PLANE_TYPE_OVERLAY ; + data.coexist_feature = j;prepare (&data);run (&data);cleanup (&data);
@@ -1210,103 +1323,88 @@ igt_main } } } - } - - data.op =PLANE_MOVE_CONTINUOUS ; -igt_describe ("Test that selective fetch works on moving overlay plane (no update)" ); - igt_subtest_with_dynamic_f("overlay-%s-sf", op_str(data.op)) { -for (i =0 ; i < n_pipes; i++) { -if (!pipe_output_combo_valid (&data.display, pipes[i], outputs[i])) -continue ; -for (j =FEATURE_NONE ; j <FEATURE_COUNT ; j++) { -if (j !=FEATURE_NONE && !(coexist_features[i] & j)) + data.op =PLANE_MOVE_CONTINUOUS_EXCEED_FULLY ; +igt_describe ("Test that selective fetch works on moving overlay plane fully " +"exceeding visible area (no update)" ); +igt_subtest_with_dynamic_f ("%soverlay-%s-sf" , append_fbc_subtest[y], + op_str(data.op)) { +for (i =0 ; i < n_pipes; i++) { +if (!pipe_output_combo_valid (&data.display, pipes[i], outputs[i]))continue ; -igt_dynamic_f ("pipe-%s-%s%s" ,kmstest_pipe_name (pipes[i]), -igt_output_name (outputs[i]), - coexist_feature_str(j)) { - data.pipe = pipes[i]; - data.output = outputs[i]; - data.test_plane_id =DRM_PLANE_TYPE_OVERLAY ; - data.coexist_feature = j; -prepare (&data); -run (&data); -cleanup (&data); - } - } - } - } - - data.op =PLANE_MOVE_CONTINUOUS_EXCEED ; -igt_describe ("Test that selective fetch works on moving overlay plane partially exceeding visible area (no update)" ); - igt_subtest_with_dynamic_f("overlay-%s-sf", op_str(data.op)) { -for (i =0 ; i < n_pipes; i++) { -if (!pipe_output_combo_valid (&data.display, pipes[i], outputs[i])) -continue ; -for (j =FEATURE_NONE ; j <FEATURE_COUNT ; j++) { -if (j !=FEATURE_NONE && !(coexist_features[i] & j)) -continue ; -igt_dynamic_f ("pipe-%s-%s%s" ,kmstest_pipe_name (pipes[i]), -igt_output_name (outputs[i]), - coexist_feature_str(j)) { - data.pipe = pipes[i]; - data.output = outputs[i]; - data.test_plane_id =DRM_PLANE_TYPE_OVERLAY ; - data.coexist_feature = j; -prepare (&data); -run (&data); -cleanup (&data); +for (j =FEATURE_NONE ; j <FEATURE_COUNT ; j++) { +if (j !=FEATURE_NONE && !(coexist_features[i] & j)) +continue ; +igt_dynamic_f ("pipe-%s-%s%s" ,kmstest_pipe_name (pipes[i]), +igt_output_name (outputs[i]), + coexist_feature_str(j)) { + data.pipe = pipes[i]; + data.output = outputs[i]; + data.test_plane_id =DRM_PLANE_TYPE_OVERLAY ; + data.coexist_feature = j; +prepare (&data); +run (&data); +cleanup (&data); + } } } } - } - data.op =PLANE_MOVE_CONTINUOUS_EXCEED_FULLY ; -igt_describe ("Test that selective fetch works on moving overlay plane fully exceeding visible area (no update)" ); - igt_subtest_with_dynamic_f("overlay-%s-sf", op_str(data.op)) { -for (i =0 ; i < n_pipes; i++) { -if (!pipe_output_combo_valid (&data.display, pipes[i], outputs[i])) -continue ; - -for (j =FEATURE_NONE ; j <FEATURE_COUNT ; j++) { -if (j !=FEATURE_NONE && !(coexist_features[i] & j)) +/* Verify primary plane selective fetch with overplay plane blended */ + data.op =OVERLAY_PRIM_UPDATE ; +igt_describe ("Test that selective fetch works on primary plane " +"with blended overlay plane" ); +igt_subtest_with_dynamic_f ("%s%s-sf-dmg-area" , append_fbc_subtest[y], + op_str(data.op)) { +for (i =0 ; i < n_pipes; i++) { +if (!pipe_output_combo_valid (&data.display, pipes[i], outputs[i]))continue ; -igt_dynamic_f ("pipe-%s-%s%s" ,kmstest_pipe_name (pipes[i]), -igt_output_name (outputs[i]), - coexist_feature_str(j)) { - data.pipe = pipes[i]; - data.output = outputs[i]; - data.test_plane_id =DRM_PLANE_TYPE_OVERLAY ; - data.coexist_feature = j; -prepare (&data); -run (&data); -cleanup (&data); + +for (j =FEATURE_NONE ; j <FEATURE_COUNT ; j++) { +if (j !=FEATURE_NONE && !(coexist_features[i] & j)) +continue ; +igt_dynamic_f ("pipe-%s-%s%s" ,kmstest_pipe_name (pipes[i]), +igt_output_name (outputs[i]), + coexist_feature_str(j)) { + data.pipe = pipes[i]; + data.output = outputs[i]; +for (k =1 ; k <=MAX_DAMAGE_AREAS ; k++) { + data.damage_area_count = k; + data.test_plane_id =DRM_PLANE_TYPE_PRIMARY ; + data.coexist_feature = j; +prepare (&data); +run (&data); +cleanup (&data); + } + } } } } - } -/* Verify primary plane selective fetch with overplay plane blended */ - data.op =OVERLAY_PRIM_UPDATE ; -igt_describe ("Test that selective fetch works on primary plane " -"with blended overlay plane" ); - igt_subtest_with_dynamic_f("%s-sf-dmg-area", op_str(data.op)) { -for (i =0 ; i < n_pipes; i++) { -if (!pipe_output_combo_valid (&data.display, pipes[i], outputs[i])) -continue ; - -for (j =FEATURE_NONE ; j <FEATURE_COUNT ; j++) { -if (j !=FEATURE_NONE && !(coexist_features[i] & j)) +/* +* Verify overlay plane selective fetch using NV12 primary +* plane and continuous updates. +*/ + data.op =PLANE_UPDATE_CONTINUOUS ; + data.primary_format =DRM_FORMAT_NV12 ; +igt_describe ("Test that selective fetch works on overlay plane" ); +igt_subtest_with_dynamic_f ("%soverlay-%s-sf" , append_fbc_subtest[y], + op_str(data.op)) { +for (i =0 ; i < n_pipes; i++) { +if (!pipe_output_combo_valid (&data.display, pipes[i], outputs[i]))continue ; -igt_dynamic_f ("pipe-%s-%s%s" ,kmstest_pipe_name (pipes[i]), -igt_output_name (outputs[i]), - coexist_feature_str(j)) { - data.pipe = pipes[i]; - data.output = outputs[i]; -for (k =1 ; k <=MAX_DAMAGE_AREAS ; k++) { - data.damage_area_count = k; - data.test_plane_id =DRM_PLANE_TYPE_PRIMARY ; + +for (j =FEATURE_NONE ; j <FEATURE_COUNT ; j++) { +if (j !=FEATURE_NONE && !(coexist_features[i] & j)) +continue ; +igt_dynamic_f ("pipe-%s-%s%s" ,kmstest_pipe_name (pipes[i]), +igt_output_name (outputs[i]), + coexist_feature_str(j)) { + data.pipe = pipes[i]; + data.output = outputs[i]; + data.damage_area_count =1 ; + data.test_plane_id =DRM_PLANE_TYPE_OVERLAY ; data.coexist_feature = j;prepare (&data);run (&data);
@@ -1317,37 +1415,6 @@ igt_main } } -/* -* Verify overlay plane selective fetch using NV12 primary -* plane and continuous updates. -*/ - data.op =PLANE_UPDATE_CONTINUOUS ; - data.primary_format =DRM_FORMAT_NV12 ; -igt_describe ("Test that selective fetch works on overlay plane" ); - igt_subtest_with_dynamic_f("overlay-%s-sf", op_str(data.op)) { -for (i =0 ; i < n_pipes; i++) { -if (!pipe_output_combo_valid (&data.display, pipes[i], outputs[i])) -continue ; - -for (j =FEATURE_NONE ; j <FEATURE_COUNT ; j++) { -if (j !=FEATURE_NONE && !(coexist_features[i] & j)) -continue ; -igt_dynamic_f ("pipe-%s-%s%s" ,kmstest_pipe_name (pipes[i]), -igt_output_name (outputs[i]), - coexist_feature_str(j)) { - data.pipe = pipes[i]; - data.output = outputs[i]; - data.damage_area_count =1 ; - data.test_plane_id =DRM_PLANE_TYPE_OVERLAY ; - data.coexist_feature = j; -prepare (&data); -run (&data); -cleanup (&data); - } - } - } - } - igt_fixture {close (data.debugfs_fd);display_fini (&data);
Signature · 1 line
2.25.1
Patchwork
CI[igt-dev] ✓ CI.xeBAT: success for Add FBC support to PSR/PSR2 tests (rev8)
In reply to Jeevan B== Series Details ==
== Series Details ==
Series: Add FBC support to PSR/PSR2 tests (rev8)
URL : https://patchwork.freedesktop.org/series/126689/
State : success
== Summary ==
CI Bug Log - changes from XEIGT_7609_BAT -> XEIGTPW_10286_BAT
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (4 -> 4)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in XEIGTPW_10286_BAT:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.
* {igt@kms_psr@psr_cursor_plane_move}:
- bat-adlp-7: [PASS][1] -> [SKIP][2] +2 other tests skip
[1]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7609/bat-adlp-7/igt@kms_psr@psr_cursor_plane_move.html
[2]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10286/bat-adlp-7/igt@kms_psr@psr_cursor_plane_move.html
Known issues
------------
Here are the changes found in XEIGTPW_10286_BAT that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_addfb_basic@addfb25-y-tiled-small-legacy:
- bat-dg2-oem2: NOTRUN -> [SKIP][3] ([Intel XE#623])
[3]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10286/bat-dg2-oem2/igt@[email protected]
* igt@kms_addfb_basic@basic-y-tiled-legacy:
- bat-dg2-oem2: NOTRUN -> [SKIP][4] ([Intel XE#388]) +2 other tests skip
[4]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10286/bat-dg2-oem2/igt@[email protected]
* igt@kms_dsc@dsc-basic:
- bat-dg2-oem2: NOTRUN -> [SKIP][5] ([Intel XE#423])
[5]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10286/bat-dg2-oem2/igt@[email protected]
* igt@kms_force_connector_basic@prune-stale-modes:
- bat-dg2-oem2: NOTRUN -> [SKIP][6] ([i915#5274])
[6]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10286/bat-dg2-oem2/igt@[email protected]
* igt@kms_frontbuffer_tracking@basic:
- bat-dg2-oem2: NOTRUN -> [FAIL][7] ([Intel XE#608])
[7]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10286/bat-dg2-oem2/igt@[email protected]
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12:
- bat-dg2-oem2: NOTRUN -> [FAIL][8] ([Intel XE#400] / [Intel XE#616]) +2 other tests fail
[8]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10286/bat-dg2-oem2/igt@[email protected]
* igt@xe_exec_fault_mode@many-basic:
- bat-dg2-oem2: NOTRUN -> [SKIP][9] ([Intel XE#288]) +17 other tests skip
[9]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10286/bat-dg2-oem2/igt@[email protected]
* igt@xe_huc_copy@huc_copy:
- bat-dg2-oem2: NOTRUN -> [SKIP][10] ([Intel XE#255])
[10]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10286/bat-dg2-oem2/igt@xe_huc_copy@huc_copy.html
#### Possible fixes ####
* igt@xe_exec_compute_mode@twice-userptr:
- bat-dg2-oem2: [INCOMPLETE][11] ([Intel XE#948]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7609/bat-dg2-oem2/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10286/bat-dg2-oem2/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[Intel XE#255]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/255
[Intel XE#288]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/288
[Intel XE#388]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/388
[Intel XE#400]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/400
[Intel XE#423]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/423
[Intel XE#608]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/608
[Intel XE#616]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/616
[Intel XE#623]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/623
[Intel XE#929]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/929
[Intel XE#948]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/948
[i915#5274]: https://gitlab.freedesktop.org/drm/intel/issues/5274
Build changes
-------------
* IGT: IGT_7609 -> IGTPW_10286
* Linux: xe-527-b06c9f366cd09b888be061d23eecffed7139c09b -> xe-529-1b020536e1c9147006cfe4e771396e89afdb14f3
IGTPW_10286: 10286
IGT_7609: 72a759595100b8d167ca78cd2d62e9acd97e36bf @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
xe-527-b06c9f366cd09b888be061d23eecffed7139c09b: b06c9f366cd09b888be061d23eecffed7139c09b xe-529-1b020536e1c9147006cfe4e771396e89afdb14f3: 1b020536e1c9147006cfe4e771396e89afdb14f3
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10286/index.html