arm64: dts: rockchip: Fix Turing RK1 interrupt pinctrls
Subsystems (2)
PATCH 1/1 arm64: dts: rockchip: Fix Turing RK1 interrupt pinctrls
The pinctrls for the hym8563 interrupt line and fan-tach input were both mistakenly defined as pcfg_pull_none. As these are active-low signals (level-triggered, in the hym8563 case) which may not be driven at times, these should really be pull-up. The lack of any bias results in spurious interrupts.
Fix this by modifying the rockchip,pins properties as necessary to enable the pull-up resistors.
--- arch/arm64/boot/dts/rockchip/rk3588-turing-rk1.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/rockchip/rk3588-turing-rk1.dtsi +2 -2
@@ -294,13 +294,13 @@ &pcie3x4 { &pinctrl { fan { fan_int: fan-int { - rockchip,pins = <0 RK_PA4 RK_FUNC_GPIO &pcfg_pull_none>; + rockchip,pins = <0 RK_PA4 RK_FUNC_GPIO &pcfg_pull_up>; }; }; hym8563 { hym8563_int: hym8563-int { - rockchip,pins = <0 RK_PB0 RK_FUNC_GPIO &pcfg_pull_none>; + rockchip,pins = <0 RK_PB0 RK_FUNC_GPIO &pcfg_pull_up>; }; };
Signature · 1 line
2.41.0
Quoted 10 lines · Sam Edwards
The pinctrls for the hym8563 interrupt line and fan-tach input were both mistakenly defined as
pcfg_pull_none. As these are active-low signals (level-triggered, in the hym8563 case) which may not be driven at times, these should really be pull-up. The lack of any bias results in spurious interrupts.Fix this by modifying the
rockchip,pinsproperties as necessary to enable the pull-up resistors.[...]
Applied, thanks!
[1/1] arm64: dts: rockchip: Fix Turing RK1 interrupt pinctrls
commit: 9f6acd2b4dfef81dcc45486ac704cf602c88db02
Best regards,
Signature · 1 line
Heiko Stuebner <[email protected]>