Skip to contentSkip to conversation

drm/bridge: tc358768: select CONFIG_VIDEOMODE_HELPERS

PATCH Applied Arnd Bergmann 2 participants 3 messages Dec 4, 2023 – Dec 5, 2023

Subsystems (3)
DRM drivers DRM misc DRM drivers for bridge chips
lore
Share & tools
lore

Arnd Bergmann

author
#0 lore raw

PATCH 1/1 drm/bridge: tc358768: select CONFIG_VIDEOMODE_HELPERS

From: Arnd Bergmann <[email protected]>

A dependency on this feature was recently introduced:

x86_64-linux-ld: vmlinux.o: in function `tc358768_bridge_pre_enable':
tc358768.c:(.text+0xbe3dae): undefined reference to `drm_display_mode_to_videomode'

Make sure this is always enabled.

Fixes e5fb21678136 ("drm/bridge: tc358768: Use struct videomode")
Signed-off-by Arnd Bergmann <[email protected]>
---
 drivers/gpu/drm/bridge/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/bridge/Kconfig +1 -0
index ba82a1142adf..3e6a4e2044c0 100644
@@ -313,6 +313,7 @@ config DRM_TOSHIBA_TC358768
 	select REGMAP_I2C
 	select DRM_PANEL
 	select DRM_MIPI_DSI
+	select VIDEOMODE_HELPERS
 	help
 	  Toshiba TC358768AXBG/TC358778XBG DSI bridge chip driver.
Signature · 1 line
2.39.2
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 20 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

A dependency on this feature was recently introduced:

x86_64-linux-ld: vmlinux.o: in function `tc358768_bridge_pre_enable':
tc358768.c:(.text+0xbe3dae): undefined reference to `drm_display_mode_to_videomode'

Make sure this is always enabled.

Fixes e5fb21678136 ("drm/bridge: tc358768: Use struct videomode")
Signed-off-by Arnd Bergmann <[email protected]>
---
  drivers/gpu/drm/bridge/Kconfig | 1 +
  1 file changed, 1 insertion(+)
drivers/gpu/drm/bridge/Kconfig +0 -0
index ba82a1142adf..3e6a4e2044c0 100644

drivers/gpu/drm/bridge/Kconfig config DRM_TOSHIBA_TC358768 · line 319

Quoted 7 lines
drivers/gpu/drm/bridge/Kconfig +1 -0
@@ -313,6 +313,7 @@ config DRM_TOSHIBA_TC358768
  	select REGMAP_I2C
  	select DRM_PANEL
  	select DRM_MIPI_DSI
+	select VIDEOMODE_HELPERS
  	help
  	  Toshiba TC358768AXBG/TC358778XBG DSI bridge chip driver.
Reviewed-by Neil Armstrong <[email protected]>
maintainer Applied
#2 lore raw
In reply to Arnd Bergmann

Hi,

Quoted 8 lines · Arnd Bergmann

A dependency on this feature was recently introduced:

x86_64-linux-ld: vmlinux.o: in function `tc358768_bridge_pre_enable':
tc358768.c:(.text+0xbe3dae): undefined reference to `drm_display_mode_to_videomode'

Make sure this is always enabled.

[...]

Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-fixes)

[1/1] drm/bridge: tc358768: select CONFIG_VIDEOMODE_HELPERS

      https://cgit.freedesktop.org/drm/drm-misc/commit/?id=26513300978f7285c3e776c144f27ef71be61f57
Signature · 1 line
Neil