Skip to contentSkip to conversation

ASoC: dt-bindings: fsl,xcvr: Adjust the number of interrupts

PATCH Superseded Fabio Estevam 2 participants 2 messages Dec 5, 2023 – Dec 6, 2023

Subsystems (3)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: dt-bindings: fsl,xcvr: Adjust the number of interrupts

From: Fabio Estevam <[email protected]>

Unlike i.MX8MP, i.MX93 has two XCVR interrupts.

Describe the two interrupts for the i.MX93 to fix the following dt-schema warning:

imx93-11x11-evk.dtb: xcvr@42680000: interrupts: [[0, 203, 4], [0, 204, 4]] is too long
from schema $id: http://devicetree.org/schemas/sound/fsl,xcvr.yaml#

---
 .../devicetree/bindings/sound/fsl,xcvr.yaml    | 18 +++++++++++++++++-
 1 file changed, 17 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/sound/fsl,xcvr.yaml +17 -1
index 799b362ba498..2db69a953afa 100644
@@ -38,7 +38,10 @@ properties:
       - const: txfifo
 
   interrupts:
-    maxItems: 1
+    items:
+      - description: WAKEUPMIX Audio XCVR Interrupt 1
+      - description: WAKEUPMIX Audio XCVR Interrupt 2
+    minItems: 1
 
   clocks:
     items:
@@ -78,6 +81,19 @@ required:
   - dma-names
   - resets
 
+allOf:
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - fsl,imx93-xcvr
+    then:
+      properties:
+        interrupts:
+          minItems: 2
+          maxItems: 2
+
 additionalProperties: false
 
 examples:
Signature · 1 line
2.34.1
#1 lore raw
Quoted 37 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Unlike i.MX8MP, i.MX93 has two XCVR interrupts.

Describe the two interrupts for the i.MX93 to fix the following dt-schema warning:

imx93-11x11-evk.dtb: xcvr@42680000: interrupts: [[0, 203, 4], [0, 204, 4]] is too long
from schema $id: http://devicetree.org/schemas/sound/fsl,xcvr.yaml#

---
 .../devicetree/bindings/sound/fsl,xcvr.yaml    | 18 +++++++++++++++++-
 1 file changed, 17 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/sound/fsl,xcvr.yaml +6 -1
index 799b362ba498..2db69a953afa 100644
@@ -38,7 +38,10 @@ properties:
       - const: txfifo
 
   interrupts:
-    maxItems: 1
+    items:
+      - description: WAKEUPMIX Audio XCVR Interrupt 1
+      - description: WAKEUPMIX Audio XCVR Interrupt 2
+    minItems: 1
 
   clocks:
     items:
@@ -78,6 +81,19 @@ required:
   - dma-names
   - resets
 
+allOf:
+  - if:

Documentation/devicetree/bindings/sound/fsl,xcvr.yaml required: · line 95

Quoted 10 lines
Documentation/devicetree/bindings/sound/fsl,xcvr.yaml +10 -0
+      properties:
+        compatible:
+          contains:
+            enum:
+              - fsl,imx93-xcvr
+    then:
+      properties:
+        interrupts:
+          minItems: 2
+          maxItems: 2

Same comment as your lcdif. Why all devices support now two interrupts?

Best regards,
Krzysztof