Skip to contentSkip to conversation

board: rockchip: add Powkiddy X55

PATCH Superseded Chris Morgan 3 participants 3 messages Dec 5, 2023 – Dec 6, 2023

Subsystems (3)

v1 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 board: rockchip: add Powkiddy X55

From: Chris Morgan <[email protected]>

The Powkiddy X55 is a Rockchip RK3566 based handheld gaming device. UART, ADC, eMMC, and SDMMC are tested to work.

---
 arch/arm/dts/Makefile                        |   1 +
 arch/arm/dts/rk3566-powkiddy-x55-u-boot.dtsi |  67 ++
 arch/arm/dts/rk3566-powkiddy-x55.dts         | 926 +++++++++++++++++++
 arch/arm/mach-rockchip/rk3568/Kconfig        |   6 +
 board/powkiddy/x55/Kconfig                   |  15 +
 board/powkiddy/x55/MAINTAINERS               |   8 +
 board/powkiddy/x55/Makefile                  |   6 +
 board/powkiddy/x55/x55.c                     | 101 ++
 configs/powkiddy-x55-rk3566_defconfig        |  86 ++
 doc/board/index.rst                          |   1 +
 doc/board/powkiddy/index.rst                 |   9 +
 doc/board/powkiddy/x55.rst                   |  46 +
 include/configs/powkiddy-x55-rk3566.h        |  12 +
 13 files changed, 1284 insertions(+)
 create mode 100644 arch/arm/dts/rk3566-powkiddy-x55-u-boot.dtsi
 create mode 100644 arch/arm/dts/rk3566-powkiddy-x55.dts
 create mode 100644 board/powkiddy/x55/Kconfig
 create mode 100644 board/powkiddy/x55/MAINTAINERS
 create mode 100644 board/powkiddy/x55/Makefile
 create mode 100644 board/powkiddy/x55/x55.c
 create mode 100644 configs/powkiddy-x55-rk3566_defconfig
 create mode 100644 doc/board/powkiddy/index.rst
 create mode 100644 doc/board/powkiddy/x55.rst
 create mode 100644 include/configs/powkiddy-x55-rk3566.h
arch/arm/dts/Makefile +1 -0
index 1be08c5fdc..9e38bab6eb 100644
@@ -174,6 +174,7 @@ dtb-$(CONFIG_ROCKCHIP_RK3568) += \
 	rk3566-anbernic-rgxx3.dtb \
 	rk3566-quartz64-a.dtb \
 	rk3566-quartz64-b.dtb \
+	rk3566-powkiddy-x55.dtb \
 	rk3566-radxa-cm3-io.dtb \
 	rk3566-soquartz-blade.dtb \
 	rk3566-soquartz-cm4.dtb \
arch/arm/dts/rk3566-powkiddy-x55-u-boot.dtsi new file +67 -0

67 lines not on this page · raw message

arch/arm/dts/rk3566-powkiddy-x55.dts new file +926 -0

926 lines not on this page · raw message

arch/arm/mach-rockchip/rk3568/Kconfig +6 -0
index baa51349f4..a97da8ae55 100644
@@ -22,6 +22,11 @@ config TARGET_ODROID_M1_RK3568
 	help
 	  Hardkernel ODROID-M1 single board computer with a RK3568B2 SoC.
 
+config TARGET_POWKIDDY_X55_RK3566
+	bool "Powkiddy X55"
+	help
+	  Powkiddy X55 handheld gaming console with an RK3566 SoC.
+
 config TARGET_QUARTZ64_RK3566
 	bool "Pine64 Quartz64"
 	help
@@ -45,5 +50,6 @@ source "board/rockchip/evb_rk3568/Kconfig"
 source "board/anbernic/rgxx3_rk3566/Kconfig"
 source "board/hardkernel/odroid_m1/Kconfig"
 source "board/pine64/quartz64_rk3566/Kconfig"
+source "board/powkiddy/x55/Kconfig"
 
 endif
board/powkiddy/x55/Kconfig new file +15 -0
new file mode 100644
index 0000000000..a7b3ed4d0d
@@ -0,0 +1,15 @@
+if TARGET_POWKIDDY_X55_RK3566
+
+config SYS_BOARD
+	default "x55"
+
+config SYS_VENDOR
+	default "powkiddy"
+
+config SYS_CONFIG_NAME
+	default "powkiddy-x55-rk3566"
+
+config BOARD_SPECIFIC_OPTIONS
+	def_bool y
+
+endif
board/powkiddy/x55/MAINTAINERS new file +8 -0
new file mode 100644
index 0000000000..2c83cd6ee1
@@ -0,0 +1,8 @@
+X55
+M:	Chris Morgan <[email protected]>
+S:	Maintained
+F:	board/powkiddy/x55
+F:	include/configs/powkiddy-x55-rk3566.h
+F:	configs/powkiddy-x55-rk3566_defconfig
+F:	arch/arm/dts/rk3566-powkiddy-x55.dts
+F:	arch/arm/dts/rk3566-powkiddy-x55-u-boot.dtsi
board/powkiddy/x55/Makefile new file +6 -0
new file mode 100644
index 0000000000..55c8c16aa1
@@ -0,0 +1,6 @@
+# SPDX-License-Identifier:     GPL-2.0+
+#
+# Copyright (c) 2023 Chris Morgan <[email protected]>
+#
+
+obj-y += x55.o
board/powkiddy/x55/x55.c new file +101 -0

101 lines not on this page · raw message

configs/powkiddy-x55-rk3566_defconfig new file +86 -0

86 lines not on this page · raw message

doc/board/index.rst +1 -0
index 531e547e7e..dd4bce9981 100644
@@ -36,6 +36,7 @@ Board-specific doc
    nxp/index
    openpiton/index
    phytec/index
+   powkiddy/index
    purism/index
    qualcomm/index
    renesas/index
doc/board/powkiddy/index.rst new file +9 -0
new file mode 100644
index 0000000000..b0115a73d4
@@ -0,0 +1,9 @@
+.. SPDX-License-Identifier: GPL-2.0+
+
+Powkiddy
+========
+
+.. toctree::
+   :maxdepth: 2
+
+   x55.rst
doc/board/powkiddy/x55.rst new file +46 -0

46 lines not on this page · raw message

include/configs/powkiddy-x55-rk3566.h new file +12 -0
new file mode 100644
index 0000000000..4b25c6a877
@@ -0,0 +1,12 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
+
+#ifndef __POWKIDDY_X55_RK3566_H
+#define __POWKIDDY_X55_RK3566_H
+
+#include <configs/rk3568_common.h>
+
+#define ROCKCHIP_DEVICE_SETTINGS \
+			"stdout=serial,vidconsole\0" \
+			"stderr=serial,vidconsole\0"
+
+#endif
Signature · 1 line
2.34.1
#1 lore raw

Hi Chris,

Quoted 50 lines · Chris Morgan

From: Chris Morgan <[email protected]>

The Powkiddy X55 is a Rockchip RK3566 based handheld gaming device. UART, ADC, eMMC, and SDMMC are tested to work.

---
 arch/arm/dts/Makefile                        |   1 +
 arch/arm/dts/rk3566-powkiddy-x55-u-boot.dtsi |  67 ++
 arch/arm/dts/rk3566-powkiddy-x55.dts         | 926 +++++++++++++++++++
 arch/arm/mach-rockchip/rk3568/Kconfig        |   6 +
 board/powkiddy/x55/Kconfig                   |  15 +
 board/powkiddy/x55/MAINTAINERS               |   8 +
 board/powkiddy/x55/Makefile                  |   6 +
 board/powkiddy/x55/x55.c                     | 101 ++
 configs/powkiddy-x55-rk3566_defconfig        |  86 ++
 doc/board/index.rst                          |   1 +
 doc/board/powkiddy/index.rst                 |   9 +
 doc/board/powkiddy/x55.rst                   |  46 +
 include/configs/powkiddy-x55-rk3566.h        |  12 +
 13 files changed, 1284 insertions(+)
 create mode 100644 arch/arm/dts/rk3566-powkiddy-x55-u-boot.dtsi
 create mode 100644 arch/arm/dts/rk3566-powkiddy-x55.dts
 create mode 100644 board/powkiddy/x55/Kconfig
 create mode 100644 board/powkiddy/x55/MAINTAINERS
 create mode 100644 board/powkiddy/x55/Makefile
 create mode 100644 board/powkiddy/x55/x55.c
 create mode 100644 configs/powkiddy-x55-rk3566_defconfig
 create mode 100644 doc/board/powkiddy/index.rst
 create mode 100644 doc/board/powkiddy/x55.rst
 create mode 100644 include/configs/powkiddy-x55-rk3566.h
arch/arm/dts/Makefile +1 -0
index 1be08c5fdc..9e38bab6eb 100644
@@ -174,6 +174,7 @@ dtb-$(CONFIG_ROCKCHIP_RK3568) += \
 	rk3566-anbernic-rgxx3.dtb \
 	rk3566-quartz64-a.dtb \
 	rk3566-quartz64-b.dtb \
+	rk3566-powkiddy-x55.dtb \
 	rk3566-radxa-cm3-io.dtb \
 	rk3566-soquartz-blade.dtb \
 	rk3566-soquartz-cm4.dtb \
arch/arm/dts/rk3566-powkiddy-x55-u-boot.dtsi new file +0 -0
new file mode 100644
index 0000000000..2e3998a65a

arch/arm/dts/rk3566-powkiddy-x55-u-boot.dtsi line 8

Quoted 8 lines
arch/arm/dts/rk3566-powkiddy-x55-u-boot.dtsi new file +8 -0
@@ -0,0 +1,67 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+
+#include "rk356x-u-boot.dtsi"
+
+/ {
+	chosen {
+		stdout-path = &uart2;
+		u-boot,spl-boot-order = "same-as-spl", &sdmmc0, &sdhci;

This matches what is set in rk356x-u-boot.dtsi and can be droped.

Quoted 43 lines
arch/arm/dts/rk3566-powkiddy-x55-u-boot.dtsi new file +43 -0
+	};
+
+	rng: rng@fe388000 {
+		compatible = "rockchip,cryptov2-rng";
+		reg = <0x0 0xfe388000 0x0 0x2000>;
+		status = "okay";
+	};
+};
+
+&cru {
+	assigned-clocks =
+			<&pmucru CLK_RTC_32K>, <&pmucru PLL_PPLL>,
+			<&pmucru PCLK_PMU>, <&cru PLL_CPLL>,
+			<&cru PLL_GPLL>, <&cru PLL_VPLL>,
+			<&cru ACLK_BUS>, <&cru PCLK_BUS>,
+			<&cru ACLK_TOP_HIGH>, <&cru ACLK_TOP_LOW>,
+			<&cru HCLK_TOP>, <&cru PCLK_TOP>,
+			<&cru ACLK_PERIMID>, <&cru HCLK_PERIMID>,
+			<&cru CPLL_500M>, <&cru CPLL_333M>,
+			<&cru CPLL_250M>, <&cru CPLL_125M>,
+			<&cru CPLL_100M>, <&cru CPLL_62P5M>,
+			<&cru CPLL_50M>, <&cru CPLL_25M>;
+		assigned-clock-rates =
+			<32768>, <200000000>,
+			<100000000>, <1000000000>,
+			<1200000000>, <126400000>,
+			<150000000>, <100000000>,
+			<500000000>, <400000000>,
+			<150000000>, <100000000>,
+			<300000000>, <150000000>,
+			<500000000>, <333333333>,
+			<250000000>, <125000000>,
+			<100000000>, <62500000>,
+			<50000000>, <25000000>;
+		assigned-clock-parents =
+			<&pmucru CLK_RTC32K_FRAC>;
+};
+
+&pmucru {
+	assigned-clocks = <&pmucru SCLK_32K_IOE>;
+	assigned-clock-parents = <&pmucru CLK_RTC_32K>;
+};
+

arch/arm/dts/rk3566-powkiddy-x55-u-boot.dtsi line 61

Quoted 10 lines
arch/arm/dts/rk3566-powkiddy-x55-u-boot.dtsi new file +10 -0
+/*
+ * We don't need the clocks, but if they are present they may cause
+ * probing to fail so we remove them for U-Boot.
+ */
+&rk817 {
+	/delete-property/ assigned-clocks;
+	/delete-property/ assigned-clock-parents;
+	/delete-property/ clocks;
+	/delete-property/ clock-names;
+};

You should not need to remove these clock properties, the clk driver has dummy support for the referenced I2S1_MCLKOUT_TX clock.

Quoted 6 lines
arch/arm/dts/rk3566-powkiddy-x55-u-boot.dtsi new file +6 -0
+
+&uart2 {
+	clock-frequency = <24000000>;
+	bootph-all;
+	status = "okay";
+};

[...]

Quoted 50 lines
arch/arm/mach-rockchip/rk3568/Kconfig +6 -0
index baa51349f4..a97da8ae55 100644
@@ -22,6 +22,11 @@ config TARGET_ODROID_M1_RK3568
 	help
 	  Hardkernel ODROID-M1 single board computer with a RK3568B2 SoC.
 
+config TARGET_POWKIDDY_X55_RK3566
+	bool "Powkiddy X55"
+	help
+	  Powkiddy X55 handheld gaming console with an RK3566 SoC.
+
 config TARGET_QUARTZ64_RK3566
 	bool "Pine64 Quartz64"
 	help
@@ -45,5 +50,6 @@ source "board/rockchip/evb_rk3568/Kconfig"
 source "board/anbernic/rgxx3_rk3566/Kconfig"
 source "board/hardkernel/odroid_m1/Kconfig"
 source "board/pine64/quartz64_rk3566/Kconfig"
+source "board/powkiddy/x55/Kconfig"
 
 endif
board/powkiddy/x55/Kconfig new file +15 -0
new file mode 100644
index 0000000000..a7b3ed4d0d
@@ -0,0 +1,15 @@
+if TARGET_POWKIDDY_X55_RK3566
+
+config SYS_BOARD
+	default "x55"
+
+config SYS_VENDOR
+	default "powkiddy"
+
+config SYS_CONFIG_NAME
+	default "powkiddy-x55-rk3566"
+
+config BOARD_SPECIFIC_OPTIONS
+	def_bool y
+
+endif
board/powkiddy/x55/MAINTAINERS new file +0 -0
new file mode 100644
index 0000000000..2c83cd6ee1

board/powkiddy/x55/MAINTAINERS line 8

Quoted 8 lines
board/powkiddy/x55/MAINTAINERS new file +8 -0
@@ -0,0 +1,8 @@
+X55
+M:	Chris Morgan <[email protected]>
+S:	Maintained
+F:	board/powkiddy/x55
+F:	include/configs/powkiddy-x55-rk3566.h
+F:	configs/powkiddy-x55-rk3566_defconfig
+F:	arch/arm/dts/rk3566-powkiddy-x55.dts
+F:	arch/arm/dts/rk3566-powkiddy-x55-u-boot.dtsi

doc/board/powkiddy/x55.rst should probably also be listed.

Quoted 83 lines
board/powkiddy/x55/Makefile new file +6 -0
new file mode 100644
index 0000000000..55c8c16aa1
@@ -0,0 +1,6 @@
+# SPDX-License-Identifier:     GPL-2.0+
+#
+# Copyright (c) 2023 Chris Morgan <[email protected]>
+#
+
+obj-y += x55.o
board/powkiddy/x55/x55.c new file +65 -0
new file mode 100644
index 0000000000..5c8d7e2bcd
@@ -0,0 +1,101 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright (c) 2023 Chris Morgan <[email protected]>
+ */
+
+#include <asm/io.h>
+#include <command.h>
+#include <linux/iopoll.h>
+
+#define BOOT_BROM_DOWNLOAD	0xef08a53c
+
+#define GPIO4_BASE		0xfe770000
+#define GPIO_SWPORT_DR_L	0x0000
+#define GPIO_SWPORT_DDR_L	0x0008
+#define GPIO_B4			BIT(12)
+#define GPIO_B5			BIT(13)
+#define GPIO_B6			BIT(14)
+
+#define GPIO_WRITEMASK(bits)	((bits) << 16)
+
+#define SARADC_BASE		0xfe720000
+#define SARADC_DATA		0x0000
+#define SARADC_STAS		0x0004
+#define SARADC_ADC_STATUS	BIT(0)
+#define SARADC_CTRL		0x0008
+#define SARADC_INPUT_SRC_MSK	0x7
+#define SARADC_POWER_CTRL	BIT(3)
+
+/*
+ * Read the function "button" to determine if we need to boot straight
+ * into download mode. In this case a user would hold the left joystick
+ * all the way to the left when powering on the device. This function is
+ * needed because 1) on some devices it may not be possible to bypass the
+ * eMMC in the bootpath and 2) after A-TF loads the device will simply
+ * reboot instead of booting into download mode.
+ */
+void read_func_button(void)
+{
+	int ret;
+	u32 reg;
+
+	/* Turn off SARADC to reset it. */
+	writel(0, (SARADC_BASE + SARADC_CTRL));
+
+	/* Enable channel 0 and power on SARADC. */
+	writel(((0 & SARADC_INPUT_SRC_MSK) | SARADC_POWER_CTRL),
+	       (SARADC_BASE + SARADC_CTRL));
+
+	/*
+	 * Wait for data to be ready. Use timeout of 20000us from
+	 * rockchip_saradc driver.
+	 */
+	ret = readl_poll_timeout((SARADC_BASE + SARADC_STAS), reg,
+				 !(reg & SARADC_ADC_STATUS), 20000);
+	if (ret) {
+		printf("ADC Timeout");
+		return;
+	}
+
+	/* Read the data from the SARADC. */
+	reg = readl((SARADC_BASE + SARADC_DATA));
+
+	/* Turn the SARADC back off so it's ready to be used again. */
+	writel(0, (SARADC_BASE + SARADC_CTRL));
+

board/powkiddy/x55/x55.c line 75

Quoted 10 lines
board/powkiddy/x55/x55.c new file +10 -0
+	/*
+	 * If the value is less than 30 the button is being pressed.
+	 * Reset the device back into Rockchip download mode.
+	 */
+	if (reg <= 30) {
+		printf("download key pressed, entering download mode...");
+		writel(BOOT_BROM_DOWNLOAD, CONFIG_ROCKCHIP_BOOT_MODE_REG);
+		do_reset(NULL, 0, 0, NULL);
+	}
+};

Would be nice if this could be made more generic for all rockchip boards, and using a value from devicetree to configure the channel to use.

Possible something like rockchip,brom-download-adc-channel = <0> under chosen node or something similar could work?

We should also have enough space in SPL to be able to use driver model for interaction with adc.

Quoted 35 lines
board/powkiddy/x55/x55.c new file +26 -0
+
+/*
+ * Start LED very early so user knows device is on. Set color
+ * to red.
+ */
+void spl_board_init(void)
+{
+	read_func_button();
+
+	/* Set GPIO4_B4, GPIO4_B5, and GPIO4_B6 to output. */
+	writel(GPIO_WRITEMASK(GPIO_B6 | GPIO_B5 | GPIO_B4) | \
+	       (GPIO_B6 | GPIO_B5 | GPIO_B4),
+	       (GPIO4_BASE + GPIO_SWPORT_DDR_L));
+	/* Set GPIO4_B5 and GPIO4_B6 to 0 and GPIO4_B4 to 1. */
+	writel(GPIO_WRITEMASK(GPIO_B6 | GPIO_B5 | GPIO_B4) | GPIO_B4,
+	       (GPIO4_BASE + GPIO_SWPORT_DR_L));
+}
+
+int rk_board_late_init(void)
+{
+	/* Turn off red LED and turn on orange LED. */
+	writel(GPIO_WRITEMASK(GPIO_B6 | GPIO_B5 | GPIO_B4) | GPIO_B6,
+	       (GPIO4_BASE + GPIO_SWPORT_DR_L));
+
+	return 0;
+}
configs/powkiddy-x55-rk3566_defconfig new file +3 -0
new file mode 100644
index 0000000000..aa29df04d1
@@ -0,0 +1,86 @@
+CONFIG_ARM=y
+CONFIG_SKIP_LOWLEVEL_INIT=y
+CONFIG_COUNTER_FREQUENCY=24000000

configs/powkiddy-x55-rk3566_defconfig line 13

Quoted 10 lines
configs/powkiddy-x55-rk3566_defconfig new file +10 -0
+CONFIG_ARCH_ROCKCHIP=y
+CONFIG_TEXT_BASE=0x00a00000
+CONFIG_SPL_LIBCOMMON_SUPPORT=y
+CONFIG_SPL_LIBGENERIC_SUPPORT=y
+CONFIG_NR_DRAM_BANKS=2
+CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y
+CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0xc00000
+CONFIG_DEFAULT_DEVICE_TREE="rk3566-powkiddy-x55"
+CONFIG_ROCKCHIP_RK3568=y
+CONFIG_SPL_ROCKCHIP_BACK_TO_BROM=y

SPL load U-Boot proper from FIT image, so this should not be needed.

configs/powkiddy-x55-rk3566_defconfig line 26

Quoted 13 lines
configs/powkiddy-x55-rk3566_defconfig new file +13 -0
+CONFIG_SPL_ROCKCHIP_COMMON_BOARD=y
+CONFIG_ROCKCHIP_RK8XX_DISABLE_BOOT_ON_POWERON=y
+CONFIG_SPL_MMC=y
+CONFIG_SPL_SERIAL=y
+CONFIG_SPL_STACK_R_ADDR=0x600000
+CONFIG_TARGET_POWKIDDY_X55_RK3566=y
+CONFIG_SPL_STACK=0x400000
+CONFIG_DEBUG_UART_BASE=0xFE660000
+CONFIG_DEBUG_UART_CLOCK=24000000
+CONFIG_SYS_LOAD_ADDR=0xc00800
+CONFIG_DEBUG_UART=y
+CONFIG_FIT=y
+CONFIG_FIT_VERBOSE=y

Recommend adding following for an added integrity check of loaded FIT images.

CONFIG_SPL_FIT_SIGNATURE=y
CONFIG_LEGACY_IMAGE_FORMAT=y

Try following patch to speed up boot when signature check is enabled.
https://patchwork.ozlabs.org/patch/1802303/

configs/powkiddy-x55-rk3566_defconfig line 33

Quoted 7 lines
configs/powkiddy-x55-rk3566_defconfig new file +7 -0
+CONFIG_SPL_LOAD_FIT=y
+CONFIG_OF_STDOUT_VIA_ALIAS=y
+CONFIG_DEFAULT_FDT_FILE="rockchip/rk3566-powkiddy-x55.dtb"
+# CONFIG_CONSOLE_MUX is not set
+# CONFIG_DISPLAY_CPUINFO is not set
+CONFIG_DISPLAY_BOARDINFO_LATE=y
+CONFIG_SPL_MAX_SIZE=0x20000

Should be 0x40000 not 0x20000

Quoted 7 lines
configs/powkiddy-x55-rk3566_defconfig new file +7 -0
+CONFIG_SPL_PAD_TO=0x7f8000
+CONFIG_SPL_HAS_BSS_LINKER_SECTION=y
+CONFIG_SPL_BSS_START_ADDR=0x4000000
+CONFIG_SPL_BSS_MAX_SIZE=0x4000
+CONFIG_SPL_BOARD_INIT=y
+# CONFIG_SPL_RAW_IMAGE_SUPPORT is not set
+# CONFIG_SPL_SHARES_INIT_SP_ADDR is not set

configs/powkiddy-x55-rk3566_defconfig line 50

Quoted 10 lines
configs/powkiddy-x55-rk3566_defconfig new file +10 -0
+CONFIG_SPL_STACK_R=y
+CONFIG_SPL_ATF=y
+CONFIG_CMD_PWM=y
+CONFIG_CMD_GPT=y
+CONFIG_CMD_MMC=y
+# CONFIG_CMD_SETEXPR is not set
+# CONFIG_CMD_CLS is not set
+# CONFIG_SPL_DOS_PARTITION is not set
+CONFIG_SPL_OF_CONTROL=y
+CONFIG_OF_LIVE=y

Recommend adding following to ensure pinctrl for sdmmc/sdhci is configured at SPL stage.

CONFIG_OF_SPL_REMOVE_PROPS="clock-names interrupt-parent assigned-clocks assigned-clock-rates assigned-clock-parents" CONFIG_SPL_DM_SEQ_ALIAS=y
CONFIG_SPL_PINCTRL=y

Quoted 8 lines
configs/powkiddy-x55-rk3566_defconfig new file +8 -0
+CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=y
+# CONFIG_NET is not set
+CONFIG_SPL_REGMAP=y
+CONFIG_SPL_SYSCON=y
+CONFIG_SPL_CLK=y
+CONFIG_ARM_SMCCC_FEATURES=y
+CONFIG_SCMI_FIRMWARE=y
+CONFIG_ROCKCHIP_GPIO=y

configs/powkiddy-x55-rk3566_defconfig line 68

Quoted 10 lines
configs/powkiddy-x55-rk3566_defconfig new file +10 -0
+CONFIG_SYS_I2C_ROCKCHIP=y
+CONFIG_MISC=y
+CONFIG_SUPPORT_EMMC_RPMB=y
+CONFIG_MMC_DW=y
+CONFIG_MMC_DW_ROCKCHIP=y
+CONFIG_MMC_SDHCI=y
+CONFIG_MMC_SDHCI_SDMA=y
+CONFIG_MMC_SDHCI_ROCKCHIP=y
+CONFIG_DM_PMIC=y
+CONFIG_DM_PMIC_FAN53555=y

I do not see fcs,fan53555 compatible in the device tree, this can be droped.

configs/powkiddy-x55-rk3566_defconfig line 71

Quoted 3 lines
configs/powkiddy-x55-rk3566_defconfig new file +3 -0
+CONFIG_PMIC_RK8XX=y
+CONFIG_REGULATOR_PWM=y
+CONFIG_DM_REGULATOR_GPIO=y

I do not see any pwm-regulator or regulator-gpio compatible in the device tree, these two can be dropped.

configs/powkiddy-x55-rk3566_defconfig line 73

Quoted 2 lines
configs/powkiddy-x55-rk3566_defconfig new file +2 -0
+CONFIG_REGULATOR_RK8XX=y
+CONFIG_DM_REGULATOR_SCMI=y

SCMI clock protocol is only used to control cpu and gpu clock on rk356x, this can be droped.

Quoted 67 lines
configs/powkiddy-x55-rk3566_defconfig new file +13 -0
+CONFIG_PWM_ROCKCHIP=y
+CONFIG_SPL_RAM=y
+# CONFIG_RAM_ROCKCHIP_DEBUG is not set
+CONFIG_DM_RNG=y
+CONFIG_RNG_ROCKCHIP=y
+# CONFIG_RNG_SMCCC_TRNG is not set
+CONFIG_BAUDRATE=1500000
+CONFIG_DEBUG_UART_SHIFT=2
+CONFIG_SYS_NS16550_MEM32=y
+CONFIG_SYSRESET=y
+CONFIG_REGEX=y
+CONFIG_ERRNO_STR=y
+# CONFIG_EFI_LOADER is not set
doc/board/index.rst +1 -0
index 531e547e7e..dd4bce9981 100644
@@ -36,6 +36,7 @@ Board-specific doc
    nxp/index
    openpiton/index
    phytec/index
+   powkiddy/index
    purism/index
    qualcomm/index
    renesas/index
doc/board/powkiddy/index.rst new file +9 -0
new file mode 100644
index 0000000000..b0115a73d4
@@ -0,0 +1,9 @@
+.. SPDX-License-Identifier: GPL-2.0+
+
+Powkiddy
+========
+
+.. toctree::
+   :maxdepth: 2
+
+   x55.rst
doc/board/powkiddy/x55.rst new file +21 -0
new file mode 100644
index 0000000000..66d02944c9
@@ -0,0 +1,46 @@
+.. SPDX-License-Identifier: GPL-2.0+
+
+U-Boot for Powkiddy X55 Handheld Gaming Console
+===============================================
+
+This allows U-Boot to boot the Powkiddy X55 handheld gaming console.
+The X55 is very similar to the other existing Powkiddy RK3566 based
+devices, except that ADC channels 0-3 are used for the ADC joysticks.
+As a result the same auto detection functionality cannot be used on
+this device as the others.
+
+The indicator LED will change color based on the boot stage. Red means
+the device is powered on but has yet to start U-Boot, amber means the
+device has started U-Boot and is waiting to boot Linux, and when Linux
+has taken over the LED should change to green (or however it has been
+configured by the user).
+
+In the event the device needs to enter Rockchip download mode, a user
+can, starting with the power off, hold the left joystick all the way
+to the left and then power on the device. At this point the USB-C port
+marked DC/OTG should be set to peripheral mode and allow a user to

doc/board/powkiddy/x55.rst line 31

Quoted 10 lines
doc/board/powkiddy/x55.rst new file +10 -0
+manipulate the device with the rkdeveloptool tool.
+
+Building U-Boot
+---------------
+
+.. code-block:: bash
+
+    $ export CROSS_COMPILE=aarch64-linux-gnu-
+    $ export BL31=../rkbin/bin/rk35/rk3568_bl31_v1.34.elf
+    $ export ROCKCHIP_TPL=../rkbin/bin/rk35/rk3568_ddr_1056MHz_v1.13.bin

I know that the rk3566/rk3568 ddr blobs are identical, but suggest you reference correct ddr blob here.

Quoted 5 lines
doc/board/powkiddy/x55.rst new file +5 -0
+    $ make powkiddy-x55-rk3566_defconfig
+    $ make
+
+This will build ``u-boot-rockchip.bin`` which can be written to an SD
+card.

doc/board/powkiddy/x55.rst line 46

Quoted 10 lines
doc/board/powkiddy/x55.rst new file +10 -0
+
+Image installation
+------------------
+
+Write the ``u-boot-rockchip.bin`` to an SD card or the internal eMMC
+offset 32kb from the start.
+
+.. code-block:: bash
+
+    $ dd if=u-boot-rockchip.bin of=/dev/mmcblk0 bs=512 seek=64

Why just not reference the common Rockchip build and flashing instructions at doc/board/rockchip/rockchip.rst ? Are they missing something and could/should be updated?

Also missing addition of this board under the rk3566 heading in that doc.

Regards,
Jonas

Quoted 18 lines
include/configs/powkiddy-x55-rk3566.h new file +12 -0
new file mode 100644
index 0000000000..4b25c6a877
@@ -0,0 +1,12 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
+
+#ifndef __POWKIDDY_X55_RK3566_H
+#define __POWKIDDY_X55_RK3566_H
+
+#include <configs/rk3568_common.h>
+
+#define ROCKCHIP_DEVICE_SETTINGS \
+			"stdout=serial,vidconsole\0" \
+			"stderr=serial,vidconsole\0"
+
+#endif
#2 lore raw
Quoted 55 lines · Jonas Karlman

Hi Chris,

Quoted 52 lines · Chris Morgan

From: Chris Morgan <[email protected]>

The Powkiddy X55 is a Rockchip RK3566 based handheld gaming device. UART, ADC, eMMC, and SDMMC are tested to work.

---
 arch/arm/dts/Makefile                        |   1 +
 arch/arm/dts/rk3566-powkiddy-x55-u-boot.dtsi |  67 ++
 arch/arm/dts/rk3566-powkiddy-x55.dts         | 926 +++++++++++++++++++
 arch/arm/mach-rockchip/rk3568/Kconfig        |   6 +
 board/powkiddy/x55/Kconfig                   |  15 +
 board/powkiddy/x55/MAINTAINERS               |   8 +
 board/powkiddy/x55/Makefile                  |   6 +
 board/powkiddy/x55/x55.c                     | 101 ++
 configs/powkiddy-x55-rk3566_defconfig        |  86 ++
 doc/board/index.rst                          |   1 +
 doc/board/powkiddy/index.rst                 |   9 +
 doc/board/powkiddy/x55.rst                   |  46 +
 include/configs/powkiddy-x55-rk3566.h        |  12 +
 13 files changed, 1284 insertions(+)
 create mode 100644 arch/arm/dts/rk3566-powkiddy-x55-u-boot.dtsi
 create mode 100644 arch/arm/dts/rk3566-powkiddy-x55.dts
 create mode 100644 board/powkiddy/x55/Kconfig
 create mode 100644 board/powkiddy/x55/MAINTAINERS
 create mode 100644 board/powkiddy/x55/Makefile
 create mode 100644 board/powkiddy/x55/x55.c
 create mode 100644 configs/powkiddy-x55-rk3566_defconfig
 create mode 100644 doc/board/powkiddy/index.rst
 create mode 100644 doc/board/powkiddy/x55.rst
 create mode 100644 include/configs/powkiddy-x55-rk3566.h
arch/arm/dts/Makefile +1 -0
index 1be08c5fdc..9e38bab6eb 100644
@@ -174,6 +174,7 @@ dtb-$(CONFIG_ROCKCHIP_RK3568) += \
 	rk3566-anbernic-rgxx3.dtb \
 	rk3566-quartz64-a.dtb \
 	rk3566-quartz64-b.dtb \
+	rk3566-powkiddy-x55.dtb \
 	rk3566-radxa-cm3-io.dtb \
 	rk3566-soquartz-blade.dtb \
 	rk3566-soquartz-cm4.dtb \
arch/arm/dts/rk3566-powkiddy-x55-u-boot.dtsi new file +2 -0
new file mode 100644
index 0000000000..2e3998a65a
@@ -0,0 +1,67 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+
Quoted 8 lines

arch/arm/dts/rk3566-powkiddy-x55-u-boot.dtsi line 8

Quoted 6 lines
arch/arm/dts/rk3566-powkiddy-x55-u-boot.dtsi new file +6 -0
+#include "rk356x-u-boot.dtsi"
+
+/ {
+	chosen {
+		stdout-path = &uart2;
+		u-boot,spl-boot-order = "same-as-spl", &sdmmc0, &sdhci;

This matches what is set in rk356x-u-boot.dtsi and can be droped.

Will do, thank you.

Quoted 49 lines
Quoted 49 lines
arch/arm/dts/rk3566-powkiddy-x55-u-boot.dtsi new file +48 -0
+	};
+
+	rng: rng@fe388000 {
+		compatible = "rockchip,cryptov2-rng";
+		reg = <0x0 0xfe388000 0x0 0x2000>;
+		status = "okay";
+	};
+};
+
+&cru {
+	assigned-clocks =
+			<&pmucru CLK_RTC_32K>, <&pmucru PLL_PPLL>,
+			<&pmucru PCLK_PMU>, <&cru PLL_CPLL>,
+			<&cru PLL_GPLL>, <&cru PLL_VPLL>,
+			<&cru ACLK_BUS>, <&cru PCLK_BUS>,
+			<&cru ACLK_TOP_HIGH>, <&cru ACLK_TOP_LOW>,
+			<&cru HCLK_TOP>, <&cru PCLK_TOP>,
+			<&cru ACLK_PERIMID>, <&cru HCLK_PERIMID>,
+			<&cru CPLL_500M>, <&cru CPLL_333M>,
+			<&cru CPLL_250M>, <&cru CPLL_125M>,
+			<&cru CPLL_100M>, <&cru CPLL_62P5M>,
+			<&cru CPLL_50M>, <&cru CPLL_25M>;
+		assigned-clock-rates =
+			<32768>, <200000000>,
+			<100000000>, <1000000000>,
+			<1200000000>, <126400000>,
+			<150000000>, <100000000>,
+			<500000000>, <400000000>,
+			<150000000>, <100000000>,
+			<300000000>, <150000000>,
+			<500000000>, <333333333>,
+			<250000000>, <125000000>,
+			<100000000>, <62500000>,
+			<50000000>, <25000000>;
+		assigned-clock-parents =
+			<&pmucru CLK_RTC32K_FRAC>;
+};
+
+&pmucru {
+	assigned-clocks = <&pmucru SCLK_32K_IOE>;
+	assigned-clock-parents = <&pmucru CLK_RTC_32K>;
+};
+
+/*
+ * We don't need the clocks, but if they are present they may cause
+ * probing to fail so we remove them for U-Boot.
+ */
+&rk817 {
Quoted 9 lines

arch/arm/dts/rk3566-powkiddy-x55-u-boot.dtsi line 61

Quoted 5 lines
arch/arm/dts/rk3566-powkiddy-x55-u-boot.dtsi new file +5 -0
+	/delete-property/ assigned-clocks;
+	/delete-property/ assigned-clock-parents;
+	/delete-property/ clocks;
+	/delete-property/ clock-names;
+};

You should not need to remove these clock properties, the clk driver has dummy support for the referenced I2S1_MCLKOUT_TX clock.

I'll test without them then and confirm, thank you. Previously this was necessary.

Quoted 61 lines
Quoted 6 lines
arch/arm/dts/rk3566-powkiddy-x55-u-boot.dtsi new file +6 -0
+
+&uart2 {
+	clock-frequency = <24000000>;
+	bootph-all;
+	status = "okay";
+};

[...]

Quoted 52 lines
arch/arm/mach-rockchip/rk3568/Kconfig +6 -0
index baa51349f4..a97da8ae55 100644
@@ -22,6 +22,11 @@ config TARGET_ODROID_M1_RK3568
 	help
 	  Hardkernel ODROID-M1 single board computer with a RK3568B2 SoC.
 
+config TARGET_POWKIDDY_X55_RK3566
+	bool "Powkiddy X55"
+	help
+	  Powkiddy X55 handheld gaming console with an RK3566 SoC.
+
 config TARGET_QUARTZ64_RK3566
 	bool "Pine64 Quartz64"
 	help
@@ -45,5 +50,6 @@ source "board/rockchip/evb_rk3568/Kconfig"
 source "board/anbernic/rgxx3_rk3566/Kconfig"
 source "board/hardkernel/odroid_m1/Kconfig"
 source "board/pine64/quartz64_rk3566/Kconfig"
+source "board/powkiddy/x55/Kconfig"
 
 endif
board/powkiddy/x55/Kconfig new file +15 -0
new file mode 100644
index 0000000000..a7b3ed4d0d
@@ -0,0 +1,15 @@
+if TARGET_POWKIDDY_X55_RK3566
+
+config SYS_BOARD
+	default "x55"
+
+config SYS_VENDOR
+	default "powkiddy"
+
+config SYS_CONFIG_NAME
+	default "powkiddy-x55-rk3566"
+
+config BOARD_SPECIFIC_OPTIONS
+	def_bool y
+
+endif
board/powkiddy/x55/MAINTAINERS new file +2 -0
new file mode 100644
index 0000000000..2c83cd6ee1
@@ -0,0 +1,8 @@
+X55
+M:	Chris Morgan <[email protected]>
Quoted 8 lines

board/powkiddy/x55/MAINTAINERS line 8

Quoted 6 lines
board/powkiddy/x55/MAINTAINERS new file +6 -0
+S:	Maintained
+F:	board/powkiddy/x55
+F:	include/configs/powkiddy-x55-rk3566.h
+F:	configs/powkiddy-x55-rk3566_defconfig
+F:	arch/arm/dts/rk3566-powkiddy-x55.dts
+F:	arch/arm/dts/rk3566-powkiddy-x55-u-boot.dtsi

doc/board/powkiddy/x55.rst should probably also be listed.

Acknowledged, thank you.

Quoted 98 lines
Quoted 84 lines
board/powkiddy/x55/Makefile new file +6 -0
new file mode 100644
index 0000000000..55c8c16aa1
@@ -0,0 +1,6 @@
+# SPDX-License-Identifier:     GPL-2.0+
+#
+# Copyright (c) 2023 Chris Morgan <[email protected]>
+#
+
+obj-y += x55.o
board/powkiddy/x55/x55.c new file +65 -0
new file mode 100644
index 0000000000..5c8d7e2bcd
@@ -0,0 +1,101 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright (c) 2023 Chris Morgan <[email protected]>
+ */
+
+#include <asm/io.h>
+#include <command.h>
+#include <linux/iopoll.h>
+
+#define BOOT_BROM_DOWNLOAD	0xef08a53c
+
+#define GPIO4_BASE		0xfe770000
+#define GPIO_SWPORT_DR_L	0x0000
+#define GPIO_SWPORT_DDR_L	0x0008
+#define GPIO_B4			BIT(12)
+#define GPIO_B5			BIT(13)
+#define GPIO_B6			BIT(14)
+
+#define GPIO_WRITEMASK(bits)	((bits) << 16)
+
+#define SARADC_BASE		0xfe720000
+#define SARADC_DATA		0x0000
+#define SARADC_STAS		0x0004
+#define SARADC_ADC_STATUS	BIT(0)
+#define SARADC_CTRL		0x0008
+#define SARADC_INPUT_SRC_MSK	0x7
+#define SARADC_POWER_CTRL	BIT(3)
+
+/*
+ * Read the function "button" to determine if we need to boot straight
+ * into download mode. In this case a user would hold the left joystick
+ * all the way to the left when powering on the device. This function is
+ * needed because 1) on some devices it may not be possible to bypass the
+ * eMMC in the bootpath and 2) after A-TF loads the device will simply
+ * reboot instead of booting into download mode.
+ */
+void read_func_button(void)
+{
+	int ret;
+	u32 reg;
+
+	/* Turn off SARADC to reset it. */
+	writel(0, (SARADC_BASE + SARADC_CTRL));
+
+	/* Enable channel 0 and power on SARADC. */
+	writel(((0 & SARADC_INPUT_SRC_MSK) | SARADC_POWER_CTRL),
+	       (SARADC_BASE + SARADC_CTRL));
+
+	/*
+	 * Wait for data to be ready. Use timeout of 20000us from
+	 * rockchip_saradc driver.
+	 */
+	ret = readl_poll_timeout((SARADC_BASE + SARADC_STAS), reg,
+				 !(reg & SARADC_ADC_STATUS), 20000);
+	if (ret) {
+		printf("ADC Timeout");
+		return;
+	}
+
+	/* Read the data from the SARADC. */
+	reg = readl((SARADC_BASE + SARADC_DATA));
+
+	/* Turn the SARADC back off so it's ready to be used again. */
+	writel(0, (SARADC_BASE + SARADC_CTRL));
+

board/powkiddy/x55/x55.c line 75

Quoted 10 lines
board/powkiddy/x55/x55.c new file +10 -0
+	/*
+	 * If the value is less than 30 the button is being pressed.
+	 * Reset the device back into Rockchip download mode.
+	 */
+	if (reg <= 30) {
+		printf("download key pressed, entering download mode...");
+		writel(BOOT_BROM_DOWNLOAD, CONFIG_ROCKCHIP_BOOT_MODE_REG);
+		do_reset(NULL, 0, 0, NULL);
+	}
+};

Would be nice if this could be made more generic for all rockchip boards, and using a value from devicetree to configure the channel to use.

Quoted 6 lines

Possible something like rockchip,brom-download-adc-channel = <0> under chosen node or something similar could work?

We should also have enough space in SPL to be able to use driver model for interaction with adc.

Will that work prior to A-TF in the SPL stage? One thing I noticed is that if I call pre A-TF the USB download mode worked as expected, but post A-TF the device would just reboot (and not into the download mode). I'll happily make this code generic if I can. Would a suitable compromise (for now) be to move this into the board specific file for the rk3568? That would also allow me to remove this (pretty much identical) code from the rgxx3_rk3566.c board file too. I have some other code I'm going to submit soon to move the rng_seed code to the main board.c in mach-rockchip so all boards can benefit. For now the one requirement I have for this routine is that it runs as early as possible, since for some devices (but not necessarily this one) it's the last line of defense against a possible brick.

Quoted 39 lines
Quoted 39 lines
board/powkiddy/x55/x55.c new file +26 -0
+
+/*
+ * Start LED very early so user knows device is on. Set color
+ * to red.
+ */
+void spl_board_init(void)
+{
+	read_func_button();
+
+	/* Set GPIO4_B4, GPIO4_B5, and GPIO4_B6 to output. */
+	writel(GPIO_WRITEMASK(GPIO_B6 | GPIO_B5 | GPIO_B4) | \
+	       (GPIO_B6 | GPIO_B5 | GPIO_B4),
+	       (GPIO4_BASE + GPIO_SWPORT_DDR_L));
+	/* Set GPIO4_B5 and GPIO4_B6 to 0 and GPIO4_B4 to 1. */
+	writel(GPIO_WRITEMASK(GPIO_B6 | GPIO_B5 | GPIO_B4) | GPIO_B4,
+	       (GPIO4_BASE + GPIO_SWPORT_DR_L));
+}
+
+int rk_board_late_init(void)
+{
+	/* Turn off red LED and turn on orange LED. */
+	writel(GPIO_WRITEMASK(GPIO_B6 | GPIO_B5 | GPIO_B4) | GPIO_B6,
+	       (GPIO4_BASE + GPIO_SWPORT_DR_L));
+
+	return 0;
+}
configs/powkiddy-x55-rk3566_defconfig new file +7 -0
new file mode 100644
index 0000000000..aa29df04d1
@@ -0,0 +1,86 @@
+CONFIG_ARM=y
+CONFIG_SKIP_LOWLEVEL_INIT=y
+CONFIG_COUNTER_FREQUENCY=24000000
+CONFIG_ARCH_ROCKCHIP=y
+CONFIG_TEXT_BASE=0x00a00000
+CONFIG_SPL_LIBCOMMON_SUPPORT=y
+CONFIG_SPL_LIBGENERIC_SUPPORT=y
Quoted 9 lines

configs/powkiddy-x55-rk3566_defconfig line 13

Quoted 6 lines
configs/powkiddy-x55-rk3566_defconfig new file +6 -0
+CONFIG_NR_DRAM_BANKS=2
+CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y
+CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0xc00000
+CONFIG_DEFAULT_DEVICE_TREE="rk3566-powkiddy-x55"
+CONFIG_ROCKCHIP_RK3568=y
+CONFIG_SPL_ROCKCHIP_BACK_TO_BROM=y

SPL load U-Boot proper from FIT image, so this should not be needed.

I'll test this and confirm, but thank you.

Quoted 8 lines
Quoted 8 lines
configs/powkiddy-x55-rk3566_defconfig new file +8 -0
+CONFIG_SPL_ROCKCHIP_COMMON_BOARD=y
+CONFIG_ROCKCHIP_RK8XX_DISABLE_BOOT_ON_POWERON=y
+CONFIG_SPL_MMC=y
+CONFIG_SPL_SERIAL=y
+CONFIG_SPL_STACK_R_ADDR=0x600000
+CONFIG_TARGET_POWKIDDY_X55_RK3566=y
+CONFIG_SPL_STACK=0x400000
+CONFIG_DEBUG_UART_BASE=0xFE660000
Quoted 8 lines

configs/powkiddy-x55-rk3566_defconfig line 26

Quoted 5 lines
configs/powkiddy-x55-rk3566_defconfig new file +5 -0
+CONFIG_DEBUG_UART_CLOCK=24000000
+CONFIG_SYS_LOAD_ADDR=0xc00800
+CONFIG_DEBUG_UART=y
+CONFIG_FIT=y
+CONFIG_FIT_VERBOSE=y

Recommend adding following for an added integrity check of loaded FIT images.

Will do.

Quoted 7 lines

CONFIG_SPL_FIT_SIGNATURE=y
CONFIG_LEGACY_IMAGE_FORMAT=y

Try following patch to speed up boot when signature check is enabled.
https://patchwork.ozlabs.org/patch/1802303/

Quoted 10 lines

configs/powkiddy-x55-rk3566_defconfig line 33

Quoted 7 lines
configs/powkiddy-x55-rk3566_defconfig new file +7 -0
+CONFIG_SPL_LOAD_FIT=y
+CONFIG_OF_STDOUT_VIA_ALIAS=y
+CONFIG_DEFAULT_FDT_FILE="rockchip/rk3566-powkiddy-x55.dtb"
+# CONFIG_CONSOLE_MUX is not set
+# CONFIG_DISPLAY_CPUINFO is not set
+CONFIG_DISPLAY_BOARDINFO_LATE=y
+CONFIG_SPL_MAX_SIZE=0x20000

Should be 0x40000 not 0x20000

Acknowledged.

Quoted 21 lines
Quoted 7 lines
configs/powkiddy-x55-rk3566_defconfig new file +7 -0
+CONFIG_SPL_PAD_TO=0x7f8000
+CONFIG_SPL_HAS_BSS_LINKER_SECTION=y
+CONFIG_SPL_BSS_START_ADDR=0x4000000
+CONFIG_SPL_BSS_MAX_SIZE=0x4000
+CONFIG_SPL_BOARD_INIT=y
+# CONFIG_SPL_RAW_IMAGE_SUPPORT is not set
+# CONFIG_SPL_SHARES_INIT_SP_ADDR is not set

configs/powkiddy-x55-rk3566_defconfig line 50

Quoted 10 lines
configs/powkiddy-x55-rk3566_defconfig new file +10 -0
+CONFIG_SPL_STACK_R=y
+CONFIG_SPL_ATF=y
+CONFIG_CMD_PWM=y
+CONFIG_CMD_GPT=y
+CONFIG_CMD_MMC=y
+# CONFIG_CMD_SETEXPR is not set
+# CONFIG_CMD_CLS is not set
+# CONFIG_SPL_DOS_PARTITION is not set
+CONFIG_SPL_OF_CONTROL=y
+CONFIG_OF_LIVE=y

Recommend adding following to ensure pinctrl for sdmmc/sdhci is configured at SPL stage.

Quoted 4 lines

CONFIG_OF_SPL_REMOVE_PROPS="clock-names interrupt-parent assigned-clocks assigned-clock-rates assigned-clock-parents" CONFIG_SPL_DM_SEQ_ALIAS=y
CONFIG_SPL_PINCTRL=y

Thanks, I'll test it out.

Quoted 13 lines
Quoted 13 lines
configs/powkiddy-x55-rk3566_defconfig new file +13 -0
+CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=y
+# CONFIG_NET is not set
+CONFIG_SPL_REGMAP=y
+CONFIG_SPL_SYSCON=y
+CONFIG_SPL_CLK=y
+CONFIG_ARM_SMCCC_FEATURES=y
+CONFIG_SCMI_FIRMWARE=y
+CONFIG_ROCKCHIP_GPIO=y
+CONFIG_SYS_I2C_ROCKCHIP=y
+CONFIG_MISC=y
+CONFIG_SUPPORT_EMMC_RPMB=y
+CONFIG_MMC_DW=y
+CONFIG_MMC_DW_ROCKCHIP=y
Quoted 8 lines

configs/powkiddy-x55-rk3566_defconfig line 68

Quoted 5 lines
configs/powkiddy-x55-rk3566_defconfig new file +5 -0
+CONFIG_MMC_SDHCI=y
+CONFIG_MMC_SDHCI_SDMA=y
+CONFIG_MMC_SDHCI_ROCKCHIP=y
+CONFIG_DM_PMIC=y
+CONFIG_DM_PMIC_FAN53555=y

I do not see fcs,fan53555 compatible in the device tree, this can be droped.

There is a compatible device. I'll test this out though but I think either it's there under a different compatible (or more likely I need to add a new compatible to this driver).

Quoted 7 lines

configs/powkiddy-x55-rk3566_defconfig line 71

Quoted 4 lines
configs/powkiddy-x55-rk3566_defconfig new file +3 -0
+CONFIG_PMIC_RK8XX=y
+CONFIG_REGULATOR_PWM=y
+CONFIG_DM_REGULATOR_GPIO=y

I do not see any pwm-regulator or regulator-gpio compatible in the device tree, these two can be dropped.

I get confused between regulator-gpio and regulator-fixed, sorry.

Quoted 6 lines

configs/powkiddy-x55-rk3566_defconfig line 73

Quoted 3 lines
configs/powkiddy-x55-rk3566_defconfig new file +2 -0
+CONFIG_REGULATOR_RK8XX=y
+CONFIG_DM_REGULATOR_SCMI=y

SCMI clock protocol is only used to control cpu and gpu clock on rk356x, this can be droped.

Ack, thanks.

Quoted 73 lines
Quoted 73 lines
configs/powkiddy-x55-rk3566_defconfig new file +13 -0
+CONFIG_PWM_ROCKCHIP=y
+CONFIG_SPL_RAM=y
+# CONFIG_RAM_ROCKCHIP_DEBUG is not set
+CONFIG_DM_RNG=y
+CONFIG_RNG_ROCKCHIP=y
+# CONFIG_RNG_SMCCC_TRNG is not set
+CONFIG_BAUDRATE=1500000
+CONFIG_DEBUG_UART_SHIFT=2
+CONFIG_SYS_NS16550_MEM32=y
+CONFIG_SYSRESET=y
+CONFIG_REGEX=y
+CONFIG_ERRNO_STR=y
+# CONFIG_EFI_LOADER is not set
doc/board/index.rst +1 -0
index 531e547e7e..dd4bce9981 100644
@@ -36,6 +36,7 @@ Board-specific doc
    nxp/index
    openpiton/index
    phytec/index
+   powkiddy/index
    purism/index
    qualcomm/index
    renesas/index
doc/board/powkiddy/index.rst new file +9 -0
new file mode 100644
index 0000000000..b0115a73d4
@@ -0,0 +1,9 @@
+.. SPDX-License-Identifier: GPL-2.0+
+
+Powkiddy
+========
+
+.. toctree::
+   :maxdepth: 2
+
+   x55.rst
doc/board/powkiddy/x55.rst new file +26 -0
new file mode 100644
index 0000000000..66d02944c9
@@ -0,0 +1,46 @@
+.. SPDX-License-Identifier: GPL-2.0+
+
+U-Boot for Powkiddy X55 Handheld Gaming Console
+===============================================
+
+This allows U-Boot to boot the Powkiddy X55 handheld gaming console.
+The X55 is very similar to the other existing Powkiddy RK3566 based
+devices, except that ADC channels 0-3 are used for the ADC joysticks.
+As a result the same auto detection functionality cannot be used on
+this device as the others.
+
+The indicator LED will change color based on the boot stage. Red means
+the device is powered on but has yet to start U-Boot, amber means the
+device has started U-Boot and is waiting to boot Linux, and when Linux
+has taken over the LED should change to green (or however it has been
+configured by the user).
+
+In the event the device needs to enter Rockchip download mode, a user
+can, starting with the power off, hold the left joystick all the way
+to the left and then power on the device. At this point the USB-C port
+marked DC/OTG should be set to peripheral mode and allow a user to
+manipulate the device with the rkdeveloptool tool.
+
+Building U-Boot
+---------------
+
Quoted 9 lines

doc/board/powkiddy/x55.rst line 31

Quoted 5 lines
doc/board/powkiddy/x55.rst new file +5 -0
+.. code-block:: bash
+
+    $ export CROSS_COMPILE=aarch64-linux-gnu-
+    $ export BL31=../rkbin/bin/rk35/rk3568_bl31_v1.34.elf
+    $ export ROCKCHIP_TPL=../rkbin/bin/rk35/rk3568_ddr_1056MHz_v1.13.bin

I know that the rk3566/rk3568 ddr blobs are identical, but suggest you reference correct ddr blob here.

Will do. In one of my rkbin trees (the one I must have been testing with) there were no 3566 files, so that might be why I did this. Will update.

Quoted 20 lines
Quoted 5 lines
doc/board/powkiddy/x55.rst new file +5 -0
+    $ make powkiddy-x55-rk3566_defconfig
+    $ make
+
+This will build ``u-boot-rockchip.bin`` which can be written to an SD
+card.

doc/board/powkiddy/x55.rst line 46

Quoted 10 lines
doc/board/powkiddy/x55.rst new file +10 -0
+
+Image installation
+------------------
+
+Write the ``u-boot-rockchip.bin`` to an SD card or the internal eMMC
+offset 32kb from the start.
+
+.. code-block:: bash
+
+    $ dd if=u-boot-rockchip.bin of=/dev/mmcblk0 bs=512 seek=64

Why just not reference the common Rockchip build and flashing instructions at doc/board/rockchip/rockchip.rst ? Are they missing something and could/should be updated?

Quoted 1 line

Also missing addition of this board under the rk3566 heading in that doc.

No, this was mostly a cut and paste of docs I wrote for the Anbernic RGxx3 series. I'll cut this part out and reference that instead.

Quoted 4 lines

Regards,
Jonas

Thank you for all your feedback. I'll work on a V2 and send it soon.

Quoted 19 lines
Quoted 18 lines
include/configs/powkiddy-x55-rk3566.h new file +12 -0
new file mode 100644
index 0000000000..4b25c6a877
@@ -0,0 +1,12 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
+
+#ifndef __POWKIDDY_X55_RK3566_H
+#define __POWKIDDY_X55_RK3566_H
+
+#include <configs/rk3568_common.h>
+
+#define ROCKCHIP_DEVICE_SETTINGS \
+			"stdout=serial,vidconsole\0" \
+			"stderr=serial,vidconsole\0"
+
+#endif