Skip to contentSkip to conversation

Add some missing descriptions

PATCH Superseded Mauro Carvalho Chehab 3 participants 9 messages Dec 6, 2023

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

cover Add some missing descriptions

From: Mauro Carvalho Chehab <[email protected]>

Address those build time warnings:

Warning: igt@xe_live_ktest@bo Description documentation is missing
Warning: igt@xe_live_ktest@dmabuf Description documentation is missing
Warning: igt@xe_live_ktest@migrate Description documentation is missing
Warning: igt@xe_media_fill@media-fill Description documentation is missing
Warning: igt@xe_sysfs_defaults@engine-defaults Description documentation is missing

Mauro Carvalho Chehab (1):
intel/xe_media_fill.c: address a documentation warning

 tests/intel/xe_media_fill.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
Signature · 1 line
2.43.0
#1 lore raw

PATCH 1/1 intel/xe_media_fill.c: address a documentation warning

From: Mauro Carvalho Chehab <[email protected]>

Currently, this warning is happening when building IGT:
Warning: igt@xe_media_fill@media-fill Description documentation is missing

The documentation is there, but not for the subtests. Address it by moving it to the right place while adding a description for the test, as other subtests could be added there in the future.

---
 tests/intel/xe_media_fill.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
tests/intel/xe_media_fill.c +3 -2
index 6b8494537038..ddda1b535ba0 100644
@@ -30,12 +30,13 @@
  * Category: Hardware building block
  * Sub-category: Media
  * Functionality: fill surface with media block
- * Description: Basic test for the media_fill() function,
- *              a very simple workload for the Media pipeline.
+ * Description: Basic tests for the media_fill() function.
  * Feature: media
  * Test category: functionality test
  *
  * SUBTEST: media-fill
+ * Description: Basic test for the media_fill() function,
+ *              a very simple workload for the Media pipeline.
  */
 
 IGT_TEST_DESCRIPTION("Basic test for the media_fill() function, a very simple"
Signature · 1 line
2.43.0
Reviewed-by on v1 1/1
#2 lore raw

Re: [igt-dev] [PATCH i-g-t 1/1] intel/xe_media_fill.c: address a documentation warning

Hi Mauro,

Quoted 10 lines · Mauro Carvalho Chehab

From: Mauro Carvalho Chehab <[email protected]>

Currently, this warning is happening when building IGT:
Warning: igt@xe_media_fill@media-fill Description documentation is missing

The documentation is there, but not for the subtests. Address it by moving it to the right place while adding a description for the test, as other subtests could be added there in the future.

Thank you for fixing this,

Quoted 27 lines
---
 tests/intel/xe_media_fill.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
tests/intel/xe_media_fill.c +3 -2
index 6b8494537038..ddda1b535ba0 100644
@@ -30,12 +30,13 @@
  * Category: Hardware building block
  * Sub-category: Media
  * Functionality: fill surface with media block
- * Description: Basic test for the media_fill() function,
- *              a very simple workload for the Media pipeline.
+ * Description: Basic tests for the media_fill() function.
  * Feature: media
  * Test category: functionality test
  *
  * SUBTEST: media-fill
+ * Description: Basic test for the media_fill() function,
+ *              a very simple workload for the Media pipeline.
  */
 
 IGT_TEST_DESCRIPTION("Basic test for the media_fill() function, a very simple"
Signature · 1 line
2.43.0
#3 lore raw

Re: [igt-dev] [PATCH i-g-t 1/1] intel/xe_media_fill.c: address a documentation warning

In reply to Mauro Carvalho Chehab

Hi Mauro,

Quoted 2 lines · Mauro Carvalho Chehab

From: Mauro Carvalho Chehab <[email protected]>

One small nit, please add 'tests/' before test name in subject, also remove ".c", so it will be:

[PATCH i-g-t 1/1] tests/intel/xe_media_fill: address a doc warning

Regards,
Kamil

Quoted 35 lines

Currently, this warning is happening when building IGT:
Warning: igt@xe_media_fill@media-fill Description documentation is missing

The documentation is there, but not for the subtests. Address it by moving it to the right place while adding a description for the test, as other subtests could be added there in the future.

---
 tests/intel/xe_media_fill.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
tests/intel/xe_media_fill.c +3 -2
index 6b8494537038..ddda1b535ba0 100644
@@ -30,12 +30,13 @@
  * Category: Hardware building block
  * Sub-category: Media
  * Functionality: fill surface with media block
- * Description: Basic test for the media_fill() function,
- *              a very simple workload for the Media pipeline.
+ * Description: Basic tests for the media_fill() function.
  * Feature: media
  * Test category: functionality test
  *
  * SUBTEST: media-fill
+ * Description: Basic test for the media_fill() function,
+ *              a very simple workload for the Media pipeline.
  */
 
 IGT_TEST_DESCRIPTION("Basic test for the media_fill() function, a very simple"
Signature · 1 line
2.43.0
#4 lore raw

[igt-dev] ✗ GitLab.Pipeline: warning for Add some missing descriptions

In reply to Mauro Carvalho Chehab
== Series Details ==

== Series Details ==

Series: Add some missing descriptions
URL : https://patchwork.freedesktop.org/series/127419/
State : warning

== Summary ==

Pipeline status: FAILED.

see https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/pipelines/1050754 for the overview.

build:tests-debian-meson has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/52433259):
section_start:1701863248:get_sources
Getting source from Git repository

  $ /host/bin/curl -s -L --cacert /host/ca-certificates.crt --retry 4 -f --retry-delay 60 https://gitlab.freedesktop.org/freedesktop/helm-gitlab-infra/-/raw/main/runner-gating/runner-gating.sh | sh -s -- pre_get_sources_script
  Checking if the user of the pipeline is allowed...
  Checking if the job's project is part of a well-known group...
  Thank you for contributing to freedesktop.org
  Fetching changes...
  Reinitialized existing Git repository in /builds/gfx-ci/igt-ci-tags/.git/
  Checking out 5d657be6 as detached HEAD (ref is intel/IGTPW_10350)...

Skipping Git submodules setup
section_end:1701863252:get_sources
section_start:1701863252:step_script
Executing "step_script" stage of the job script
Using docker image sha256:ca01fc804bb92e5df42a202dd7e0470610c6711c66a808525defcb8bbb774078 for registry.freedesktop.org/gfx-ci/igt-ci-tags/build-debian:commit-5d657be67c25d67d581dfd37b7ddd176d9a48272 with digest registry.freedesktop.org/gfx-ci/igt-ci-tags/build-debian@sha256:b9fe73c6ff5d68f5692fd18b9076735679c8bfa7ed393e752dd4927a2cdf9874 ... section_end:1701863256:step_script
section_start:1701863256:cleanup_file_variables
Cleaning up project directory and file based variables
section_end:1701863257:cleanup_file_variables
ERROR: Job failed (system failure): Error response from daemon: no such image: docker.io/library/sha256:ca01fc804bb92e5df42a202dd7e0470610c6711c66a808525defcb8bbb774078: image not known (docker.go:570:0s)

== Logs ==

For more details see: https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/pipelines/1050754

#5 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for Add some missing descriptions

In reply to Mauro Carvalho Chehab
== Series Details ==

== Series Details ==

Series: Add some missing descriptions
URL : https://patchwork.freedesktop.org/series/127419/
State : success

== Summary ==

CI Bug Log - changes from IGT_7623 -> IGTPW_10350
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10350/index.html

Participating hosts (39 -> 38)
------------------------------

Missing (1): fi-snb-2520m

Known issues
------------

Here are the changes found in IGTPW_10350 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@kms_hdmi_inject@inject-audio:
- fi-kbl-guc: [PASS][1] -> [FAIL][2] ([IGT#3])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7623/fi-kbl-guc/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10350/fi-kbl-guc/igt@[email protected]

* igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1:
- bat-rplp-1: [PASS][3] -> [ABORT][4] ([i915#8668])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7623/bat-rplp-1/igt@kms_pipe_crc_basic@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10350/bat-rplp-1/igt@kms_pipe_crc_basic@[email protected]

#### Possible fixes ####

* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24@pipe-d-dp-1:
- bat-dg2-8: [DMESG-WARN][5] ([i915#1982]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7623/bat-dg2-8/igt@kms_pipe_crc_basic@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10350/bat-dg2-8/igt@kms_pipe_crc_basic@[email protected]

[IGT#3]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/3
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#8668]: https://gitlab.freedesktop.org/drm/intel/issues/8668

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_7623 -> IGTPW_10350

CI-20190529: 20190529
CI_DRM_13986: b441e2df33ada84a77c2da0b5619e212e94675bf @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_10350: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10350/index.html
IGT_7623: f42cda2a9ad74846fb59eea436cc98c8789849f9 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10350/index.html

#6 lore raw
In reply to Mauro Carvalho Chehab

Hi Mauro,

Quoted 8 lines · Mauro Carvalho Chehab

From: Mauro Carvalho Chehab <[email protected]>

Address those build time warnings:

Warning: igt@xe_live_ktest@bo Description documentation is missing
Warning: igt@xe_live_ktest@dmabuf Description documentation is missing
Warning: igt@xe_live_ktest@migrate Description documentation is missing
Warning: igt@xe_media_fill@media-fill Description documentation is missing

You actually adressed only this one, do you plan send other fixes?

Regards,
Kamil

Quoted 11 lines

Warning: igt@xe_sysfs_defaults@engine-defaults Description documentation is missing

Mauro Carvalho Chehab (1):
intel/xe_media_fill.c: address a documentation warning

 tests/intel/xe_media_fill.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
Signature · 1 line
2.43.0
#7 lore raw
Quoted 4 lines · On Wed, 6 Dec 2023 14:20:45 +0100 Kamil Konieczny…

Hi Mauro,

Quoted 2 lines · Mauro Carvalho Chehab

From: Mauro Carvalho Chehab <[email protected]>

Quoted 8 lines
Quoted 6 lines

Address those build time warnings:

Warning: igt@xe_live_ktest@bo Description documentation is missing
Warning: igt@xe_live_ktest@dmabuf Description documentation is missing
Warning: igt@xe_live_ktest@migrate Description documentation is missing
Warning: igt@xe_media_fill@media-fill Description documentation is missing

You actually adressed only this one, do you plan send other fixes?

Sorry, got a wrong head as basis. Resent it, this time with all 3 patches.

Regards,
Mauro

#8 lore raw

[igt-dev] ✓ CI.xeBAT: success for Add some missing descriptions

In reply to Mauro Carvalho Chehab
== Series Details ==

== Series Details ==

Series: Add some missing descriptions
URL : https://patchwork.freedesktop.org/series/127419/
State : success

== Summary ==

CI Bug Log - changes from XEIGT_7623_BAT -> XEIGTPW_10350_BAT
====================================================

Summary
-------

**WARNING**

Minor unknown changes coming with XEIGTPW_10350_BAT need to be verified manually.

If you think the reported changes have nothing to do with the changes
introduced in XEIGTPW_10350_BAT, please notify your bug team ([email protected]) to allow them to document this new failure mode, which will reduce false positives in CI.

Participating hosts (4 -> 4)
------------------------------

No changes in participating hosts

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in XEIGTPW_10350_BAT:

### IGT changes ###

#### Warnings ####

* igt@xe_prime_self_import@basic-with_one_bo:
- bat-pvc-2: [FAIL][1] ([Intel XE#999]) -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7623/bat-pvc-2/igt@xe_prime_self_import@basic-with_one_bo.html
[2]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10350/bat-pvc-2/igt@xe_prime_self_import@basic-with_one_bo.html

Known issues
------------

Here are the changes found in XEIGTPW_10350_BAT that come from known issues:

### IGT changes ###

#### Possible fixes ####

* igt@kms_flip@basic-flip-vs-wf_vblank:
- bat-adlp-7: [FAIL][3] ([Intel XE#480]) -> [PASS][4] +1 other test pass
[3]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7623/bat-adlp-7/igt@kms_flip@basic-flip-vs-wf_vblank.html
[4]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10350/bat-adlp-7/igt@kms_flip@basic-flip-vs-wf_vblank.html

* igt@xe_prime_self_import@basic-with_fd_dup:
- bat-atsm-2: [FAIL][5] ([Intel XE#999]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7623/bat-atsm-2/igt@xe_prime_self_import@basic-with_fd_dup.html
[6]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10350/bat-atsm-2/igt@xe_prime_self_import@basic-with_fd_dup.html

#### Warnings ####

* igt@xe_prime_self_import@basic-with_fd_dup:
- bat-pvc-2: [FAIL][7] -> [FAIL][8] ([Intel XE#999])
[7]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7623/bat-pvc-2/igt@xe_prime_self_import@basic-with_fd_dup.html
[8]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10350/bat-pvc-2/igt@xe_prime_self_import@basic-with_fd_dup.html

[Intel XE#480]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/480
[Intel XE#999]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/999

Build changes
-------------

* IGT: IGT_7623 -> IGTPW_10350

IGTPW_10350: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10350/index.html
IGT_7623: f42cda2a9ad74846fb59eea436cc98c8789849f9 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
xe-554-9d76164e08c68a3d5d081ff7b07c15a2cadf741a: 9d76164e08c68a3d5d081ff7b07c15a2cadf741a

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10350/index.html