Skip to contentSkip to conversation

drivers: misc: Add socfpga_dtreg driver for Intel SoCFPGA

PATCH Superseded [email protected] 4 participants 9 messages Dec 8, 2023 – Jan 5, 2024 Char and misc drivers

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers: misc: Add socfpga_dtreg driver for Intel SoCFPGA

From: Wan Yee Lau <[email protected]>

This driver can be used to provide user a clean interface and all register settings are centralized in one place, device tree without need for hardcoding in the source code.

---
 .../misc/socfpga_dtreg.txt                    |  66 ++++++++++
 drivers/misc/Kconfig                          |   7 ++
 drivers/misc/Makefile                         |   1 +
 drivers/misc/socfpga_dtreg.c                  | 117 ++++++++++++++++++
 4 files changed, 191 insertions(+)
 create mode 100644 doc/device-tree-bindings/misc/socfpga_dtreg.txt
 create mode 100644 drivers/misc/socfpga_dtreg.c
doc/device-tree-bindings/misc/socfpga_dtreg.txt new file +66 -0
new file mode 100644
index 0000000000..5458103f88
@@ -0,0 +1,66 @@
+* Firewall and privilege register settings in device tree
+
+Required properties:
+--------------------
+
+- compatible: should contain "intel,socfpga-dtreg"
+- reg: Physical base address and size of block register.
+- intel,offset-settings: 32-bit offset address of block register,
+			 followed by 32-bit value settings and
+			 the masking bits, only masking bit
+			 set to 1 allows modification.
+
+This driver can be used to provide user a clean interface and all register
+settings are centralized in one place, device tree without need for
+hardcoding in the source code.
+
+General setup would be to set the memory address used by the register,
+followed by the offset-settings containing the 32-bit offset address
+of the block register, then the 32-bit value settings and
+lastly the masking bits.
+
+Example:
+--------
+
+Configuration for multiple dtreg node support in device tree:
+
+	socfpga_mainfirewall: socfpga-mainfirewall {
+		compatible = "intel,socfpga-dtreg";
+                	#address-cells = <1>;
+                        #size-cells = <1>;
+		        bootph-all;
+
+                        coh_cpu0_bypass_OC_Firewall_main_Firewall@f7100200 {
+                        	reg = <0xf7100200 0x00000014>;
+                                intel,offset-settings =
+                                	/* Disable ocram security at CCU for non secure access */
+                                        <0x0000004 0x8000ffff 0xe007ffff>,
+                                        <0x0000008 0x8000ffff 0xe007ffff>,
+                                        <0x000000c 0x8000ffff 0xe007ffff>,
+                                        <0x0000010 0x8000ffff 0xe007ffff>;
+                                bootph-all;
+                        };
+                };
+
+	socfpga_mpfefirewall: socfpga-mpfefirewall {
+        	compatible = "intel,socfpga-dtreg";
+                	#address-cells = <1>;
+                        #size-cells = <1>;
+			bootph-all;
+
+                        soc_noc_fw_mpfe_csr_inst_0_mpfe_scr@f8020000 {
+                                reg = <0xf8020000 0x0000001c>;
+                                intel,offset-settings =
+                                        /* Disable MPFE firewall for SMMU */
+                                        <0x00000000 0x00010101 0x00010101>,
+                                        /* Disable MPFE firewall for HMC adapter */
+                                        <0x00000004 0x00000001 0x00010101>;
+				bootph-all;
+                        };
+                };
+
+To call the nodes use:
+
+	ret = uclass_get_device_by_name(UCLASS_NOP, "socfpga-mainfirewall", &dev);
+	ret = uclass_get_device_by_name(UCLASS_NOP, "socfpga-mpfefirewall", &dev);
+
drivers/misc/Kconfig +7 -0
index fccd9b89b8..c423905ba2 100644
@@ -683,4 +683,11 @@ config SL28CPLD
 	  the base driver which provides common access methods for the
 	  sub-drivers.
 
+config SPL_SOCFPGA_DT_REG
+	bool "Enable register setting from device tree in SPL"
+	depends on SPL
+	help
+	  Enable register setting from device tree. This also
+	  provides user a clean interface and all register settings are
+	  centralized in one place, device tree.
 endmenu
drivers/misc/Makefile +1 -0
index b67b82358a..8f813edd84 100644
@@ -89,3 +89,4 @@ obj-$(CONFIG_K3_AVS0) += k3_avs.o
 obj-$(CONFIG_ESM_K3) += k3_esm.o
 obj-$(CONFIG_ESM_PMIC) += esm_pmic.o
 obj-$(CONFIG_SL28CPLD) += sl28cpld.o
+obj-$(CONFIG_SPL_SOCFPGA_DT_REG) += socfpga_dtreg.o
drivers/misc/socfpga_dtreg.c new file +117 -0

117 lines not on this page · raw message

--
2.25.1

#1 lore raw

Hi,

Quoted 144 lines

-----Original Message-----
From: Lau, Wan Yee <[email protected]>
Sent: Friday, December 8, 2023 4:37 PM
To: [email protected]
Cc: Simon Glass <[email protected]>; Kever Yang <kever.yang@rock- chips.com>; Bin Meng <[email protected]>; Jonas Karlman <[email protected]>; Jean-Marie Lemetayer <[email protected]>; Peng Fan <[email protected]>; Vladimir Zapolskiy <[email protected]>; Konrad Dybcio <[email protected]>; Marek Vasut <[email protected]>; Simon Goldschmidt <[email protected]>; Chee, Tien Fong <[email protected]>; Hea, Kok Kiang <[email protected]>; Maniyam, Dinesh <[email protected]>; Ng, Boon Khai <[email protected]>; Yuslaimi, Alif Zakuan <[email protected]>; Chong, Teik Heng <[email protected]>; Zamri, Muhammad Hazim Izzat <[email protected]>; Lim, Jit Loon <[email protected]>; Tang, Sieu Mun <[email protected]>
Subject: [PATCH v1 1/1] drivers: misc: Add socfpga_dtreg driver for Intel SoCFPGA

From: Wan Yee Lau <[email protected]>

This driver can be used to provide user a clean interface and all register settings are centralized in one place, device tree without need for hardcoding in the source code.

---
 .../misc/socfpga_dtreg.txt                    |  66 ++++++++++
 drivers/misc/Kconfig                          |   7 ++
 drivers/misc/Makefile                         |   1 +
 drivers/misc/socfpga_dtreg.c                  | 117 ++++++++++++++++++
 4 files changed, 191 insertions(+)
 create mode 100644 doc/device-tree-bindings/misc/socfpga_dtreg.txt
 create mode 100644 drivers/misc/socfpga_dtreg.c
doc/device- renamed from doc/device-tree-bindings/misc/socfpga_dtreg.txt +0 -0

tree-bindings/misc/socfpga_dtreg.txt
new file mode 100644
index 0000000000..5458103f88

doc/device-tree-bindings/misc/socfpga_dtreg.txt new file +36 -0
@@ -0,0 +1,66 @@
+* Firewall and privilege register settings in device tree
+
+Required properties:
+--------------------
+
+- compatible: should contain "intel,socfpga-dtreg"
+- reg: Physical base address and size of block register.
+- intel,offset-settings: 32-bit offset address of block register,
+			 followed by 32-bit value settings and
+			 the masking bits, only masking bit
+			 set to 1 allows modification.
+
+This driver can be used to provide user a clean interface and all
+register settings are centralized in one place, device tree without
+need for hardcoding in the source code.
+
+General setup would be to set the memory address used by the register,
+followed by the offset-settings containing the 32-bit offset address of
+the block register, then the 32-bit value settings and lastly the
+masking bits.
+
+Example:
+--------
+
+Configuration for multiple dtreg node support in device tree:
+
+	socfpga_mainfirewall: socfpga-mainfirewall {
+		compatible = "intel,socfpga-dtreg";
+                	#address-cells = <1>;
+                        #size-cells = <1>;
+		        bootph-all;
+
+                        coh_cpu0_bypass_OC_Firewall_main_Firewall@f7100200 {
+                        	reg = <0xf7100200 0x00000014>;
+                                intel,offset-settings =
+                                	/* Disable ocram security at CCU for non secure

access */

doc/device-tree-bindings/misc/socfpga_dtreg.txt new file +28 -0
+                                        <0x0000004 0x8000ffff 0xe007ffff>,
+                                        <0x0000008 0x8000ffff 0xe007ffff>,
+                                        <0x000000c 0x8000ffff 0xe007ffff>,
+                                        <0x0000010 0x8000ffff 0xe007ffff>;
+                                bootph-all;
+                        };
+                };
+
+	socfpga_mpfefirewall: socfpga-mpfefirewall {
+        	compatible = "intel,socfpga-dtreg";
+                	#address-cells = <1>;
+                        #size-cells = <1>;
+			bootph-all;
+
+                        soc_noc_fw_mpfe_csr_inst_0_mpfe_scr@f8020000 {
+                                reg = <0xf8020000 0x0000001c>;
+                                intel,offset-settings =
+                                        /* Disable MPFE firewall for SMMU */
+                                        <0x00000000 0x00010101 0x00010101>,
+                                        /* Disable MPFE firewall for HMC adapter */
+                                        <0x00000004 0x00000001 0x00010101>;
+				bootph-all;
+                        };
+                };
+
+To call the nodes use:
+
+	ret = uclass_get_device_by_name(UCLASS_NOP, "socfpga-

mainfirewall", &dev);

doc/device-tree-bindings/misc/socfpga_dtreg.txt new file +1 -0
+	ret = uclass_get_device_by_name(UCLASS_NOP, "socfpga-

mpfefirewall",
+&dev);

doc/device-tree-bindings/misc/socfpga_dtreg.txt new file +1 -0
+
drivers/misc/Kconfig index renamed from drivers/misc/Kconfig +0 -0

fccd9b89b8..c423905ba2 100644

drivers/misc/Kconfig +7 -0
@@ -683,4 +683,11 @@ config SL28CPLD
 	  the base driver which provides common access methods for the
 	  sub-drivers.
 
+config SPL_SOCFPGA_DT_REG
+	bool "Enable register setting from device tree in SPL"
+	depends on SPL
+	help
+	  Enable register setting from device tree. This also
+	  provides user a clean interface and all register settings are
+	  centralized in one place, device tree.
 endmenu
drivers/misc/Makefile index renamed from drivers/misc/Makefile +0 -0

b67b82358a..8f813edd84 100644

drivers/misc/Makefile +1 -0
@@ -89,3 +89,4 @@ obj-$(CONFIG_K3_AVS0) += k3_avs.o
 obj-$(CONFIG_ESM_K3) += k3_esm.o
 obj-$(CONFIG_ESM_PMIC) += esm_pmic.o
 obj-$(CONFIG_SL28CPLD) += sl28cpld.o
+obj-$(CONFIG_SPL_SOCFPGA_DT_REG) += socfpga_dtreg.o
drivers/misc/socfpga_dtreg.c new renamed from drivers/misc/socfpga_dtreg.c +0 -0

file mode 100644 index 0000000000..982f9592cb

drivers/misc/socfpga_dtreg.c line 8

Quoted 8 lines
drivers/misc/socfpga_dtreg.c new file +8 -0
@@ -0,0 +1,117 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (C) 2023 Intel Corporation <www.intel.com>  */
+
+#include <asm/io.h>
+#include <common.h>
+#include <dm.h>
+#include <errno.h>

Please move <asm/io.h> above to here

drivers/misc/socfpga_dtreg.c line 10

Quoted 1 line
drivers/misc/socfpga_dtreg.c new file +1 -0
+#include <linux/sizes.h>

--
Tien Fong

#2 lore raw
Quoted 148 lines · Tien Fong

Hi,

Quoted 146 lines

-----Original Message-----
From: Lau, Wan Yee <[email protected]>
Sent: Friday, December 8, 2023 4:37 PM
To: [email protected]
Cc: Simon Glass <[email protected]>; Kever Yang <kever.yang@rock- chips.com>; Bin Meng <[email protected]>; Jonas Karlman <[email protected]>; Jean-Marie Lemetayer <[email protected]>; Peng Fan <[email protected]>; Vladimir Zapolskiy <[email protected]>; Konrad Dybcio <[email protected]>; Marek Vasut <[email protected]>; Simon Goldschmidt <[email protected]>; Chee, Tien Fong <[email protected]>; Hea, Kok Kiang <[email protected]>; Maniyam, Dinesh <[email protected]>; Ng, Boon Khai <[email protected]>; Yuslaimi, Alif Zakuan <[email protected]>; Chong, Teik Heng <[email protected]>; Zamri, Muhammad Hazim Izzat <[email protected]>; Lim, Jit Loon <[email protected]>; Tang, Sieu Mun <[email protected]>
Subject: [PATCH v1 1/1] drivers: misc: Add socfpga_dtreg driver for Intel SoCFPGA

From: Wan Yee Lau <[email protected]>

This driver can be used to provide user a clean interface and all register settings are centralized in one place, device tree without need for hardcoding in the source code.

---
  .../misc/socfpga_dtreg.txt                    |  66 ++++++++++
  drivers/misc/Kconfig                          |   7 ++
  drivers/misc/Makefile                         |   1 +
  drivers/misc/socfpga_dtreg.c                  | 117 ++++++++++++++++++
  4 files changed, 191 insertions(+)

create mode 100644 doc/device-tree-bindings/misc/socfpga_dtreg.txt create mode 100644 drivers/misc/socfpga_dtreg.c

doc/device- renamed from doc/device-tree-bindings/misc/socfpga_dtreg.txt +0 -0

tree-bindings/misc/socfpga_dtreg.txt
new file mode 100644
index 0000000000..5458103f88

doc/device-tree-bindings/misc/socfpga_dtreg.txt new file +36 -0
@@ -0,0 +1,66 @@
+* Firewall and privilege register settings in device tree
+
+Required properties:
+--------------------
+
+- compatible: should contain "intel,socfpga-dtreg"
+- reg: Physical base address and size of block register.
+- intel,offset-settings: 32-bit offset address of block register,
+			 followed by 32-bit value settings and
+			 the masking bits, only masking bit
+			 set to 1 allows modification.
+
+This driver can be used to provide user a clean interface and all
+register settings are centralized in one place, device tree without
+need for hardcoding in the source code.
+
+General setup would be to set the memory address used by the register,
+followed by the offset-settings containing the 32-bit offset address of
+the block register, then the 32-bit value settings and lastly the
+masking bits.
+
+Example:
+--------
+
+Configuration for multiple dtreg node support in device tree:
+
+	socfpga_mainfirewall: socfpga-mainfirewall {
+		compatible = "intel,socfpga-dtreg";
+                	#address-cells = <1>;
+                        #size-cells = <1>;
+		        bootph-all;
+
+                        coh_cpu0_bypass_OC_Firewall_main_Firewall@f7100200 {
+                        	reg = <0xf7100200 0x00000014>;
+                                intel,offset-settings =
+                                	/* Disable ocram security at CCU for non secure

access */

doc/device-tree-bindings/misc/socfpga_dtreg.txt new file +28 -0
+                                        <0x0000004 0x8000ffff 0xe007ffff>,
+                                        <0x0000008 0x8000ffff 0xe007ffff>,
+                                        <0x000000c 0x8000ffff 0xe007ffff>,
+                                        <0x0000010 0x8000ffff 0xe007ffff>;
+                                bootph-all;
+                        };
+                };
+
+	socfpga_mpfefirewall: socfpga-mpfefirewall {
+        	compatible = "intel,socfpga-dtreg";
+                	#address-cells = <1>;
+                        #size-cells = <1>;
+			bootph-all;
+
+                        soc_noc_fw_mpfe_csr_inst_0_mpfe_scr@f8020000 {
+                                reg = <0xf8020000 0x0000001c>;
+                                intel,offset-settings =
+                                        /* Disable MPFE firewall for SMMU */
+                                        <0x00000000 0x00010101 0x00010101>,
+                                        /* Disable MPFE firewall for HMC adapter */
+                                        <0x00000004 0x00000001 0x00010101>;
+				bootph-all;
+                        };
+                };
+
+To call the nodes use:
+
+	ret = uclass_get_device_by_name(UCLASS_NOP, "socfpga-

mainfirewall", &dev);

doc/device-tree-bindings/misc/socfpga_dtreg.txt new file +1 -0
+	ret = uclass_get_device_by_name(UCLASS_NOP, "socfpga-

mpfefirewall",
+&dev);

doc/device-tree-bindings/misc/socfpga_dtreg.txt new file +1 -0
+
drivers/misc/Kconfig index renamed from drivers/misc/Kconfig +0 -0

fccd9b89b8..c423905ba2 100644

drivers/misc/Kconfig +7 -0
@@ -683,4 +683,11 @@ config SL28CPLD
  	  the base driver which provides common access methods for the
  	  sub-drivers.
 
+config SPL_SOCFPGA_DT_REG
+	bool "Enable register setting from device tree in SPL"
+	depends on SPL
+	help
+	  Enable register setting from device tree. This also
+	  provides user a clean interface and all register settings are
+	  centralized in one place, device tree.
  endmenu
drivers/misc/Makefile index renamed from drivers/misc/Makefile +0 -0

b67b82358a..8f813edd84 100644

drivers/misc/Makefile +1 -0
@@ -89,3 +89,4 @@ obj-$(CONFIG_K3_AVS0) += k3_avs.o
  obj-$(CONFIG_ESM_K3) += k3_esm.o
  obj-$(CONFIG_ESM_PMIC) += esm_pmic.o
  obj-$(CONFIG_SL28CPLD) += sl28cpld.o
+obj-$(CONFIG_SPL_SOCFPGA_DT_REG) += socfpga_dtreg.o
drivers/misc/socfpga_dtreg.c new renamed from drivers/misc/socfpga_dtreg.c +0 -0

file mode 100644 index 0000000000..982f9592cb

drivers/misc/socfpga_dtreg.c new file +2 -0
@@ -0,0 +1,117 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
Quoted 10 lines

drivers/misc/socfpga_dtreg.c line 9

Quoted 6 lines
drivers/misc/socfpga_dtreg.c new file +6 -0
+ * Copyright (C) 2023 Intel Corporation <www.intel.com>  */
+
+#include <asm/io.h>
+#include <common.h>
+#include <dm.h>
+#include <errno.h>

Please move <asm/io.h> above to here

Quoted 1 line
drivers/misc/socfpga_dtreg.c new file +1 -0
+#include <linux/sizes.h>

A good starting point would be to have socfpga 64bit maintainer , without that , these patches are only being archived .

#3 lore raw
Quoted 182 lines

-----Original Message-----
From: Marek Vasut <[email protected]>
Sent: Tuesday, December 19, 2023 5:54 PM
To: Chee, Tien Fong <[email protected]>; Lau, Wan Yee <[email protected]>; [email protected]
Cc: Simon Glass <[email protected]>; Kever Yang <[email protected]>; Bin Meng <[email protected]>; Jonas Karlman <[email protected]>; Jean- Marie Lemetayer <[email protected]>; Peng Fan <[email protected]>; Vladimir Zapolskiy <[email protected]>; Konrad Dybcio <[email protected]>; Simon Goldschmidt <[email protected]>; Hea, Kok Kiang <[email protected]>; Maniyam, Dinesh <[email protected]>; Ng, Boon Khai <[email protected]>; Yuslaimi, Alif Zakuan <[email protected]>; Chong, Teik Heng <[email protected]>; Zamri, Muhammad Hazim Izzat <[email protected]>; Lim, Jit Loon <[email protected]>; Tang, Sieu Mun <[email protected]>
Subject: Re: [PATCH v1 1/1] drivers: misc: Add socfpga_dtreg driver for Intel SoCFPGA

Quoted 159 lines · Tien Fong

Hi,

Quoted 146 lines

-----Original Message-----
From: Lau, Wan Yee <[email protected]>
Sent: Friday, December 8, 2023 4:37 PM
To: [email protected]
Cc: Simon Glass <[email protected]>; Kever Yang <kever.yang@rock- chips.com>; Bin Meng <[email protected]>; Jonas Karlman <[email protected]>; Jean-Marie Lemetayer <[email protected]>; Peng Fan <[email protected]>; Vladimir Zapolskiy <[email protected]>; Konrad Dybcio <[email protected]>; Marek Vasut <[email protected]>; Simon Goldschmidt <[email protected]>; Chee, Tien Fong <[email protected]>; Hea, Kok Kiang <[email protected]>; Maniyam, Dinesh <[email protected]>; Ng, Boon Khai <[email protected]>; Yuslaimi, Alif Zakuan <[email protected]>; Chong, Teik Heng <[email protected]>; Zamri, Muhammad Hazim Izzat <[email protected]>; Lim, Jit Loon <[email protected]>; Tang, Sieu Mun <[email protected]>
Subject: [PATCH v1 1/1] drivers: misc: Add socfpga_dtreg driver for Intel SoCFPGA

From: Wan Yee Lau <[email protected]>

This driver can be used to provide user a clean interface and all register settings are centralized in one place, device tree without need for hardcoding in the source code.

---
  .../misc/socfpga_dtreg.txt                    |  66 ++++++++++
  drivers/misc/Kconfig                          |   7 ++
  drivers/misc/Makefile                         |   1 +
  drivers/misc/socfpga_dtreg.c                  | 117 ++++++++++++++++++
  4 files changed, 191 insertions(+)

create mode 100644 doc/device-tree-bindings/misc/socfpga_dtreg.txt create mode 100644 drivers/misc/socfpga_dtreg.c

(quoted diff) +0 -0

b/doc/device- tree-bindings/misc/socfpga_dtreg.txt new file mode 100644
index 0000000000..5458103f88

doc/device-tree-bindings/misc/socfpga_dtreg.txt new file +37 -0
@@ -0,0 +1,66 @@
+* Firewall and privilege register settings in device tree
+
+Required properties:
+--------------------
+
+- compatible: should contain "intel,socfpga-dtreg"
+- reg: Physical base address and size of block register.
+- intel,offset-settings: 32-bit offset address of block register,
+			 followed by 32-bit value settings and
+			 the masking bits, only masking bit
+			 set to 1 allows modification.
+
+This driver can be used to provide user a clean interface and all
+register settings are centralized in one place, device tree without
+need for hardcoding in the source code.
+
+General setup would be to set the memory address used by the
+register, followed by the offset-settings containing the 32-bit
+offset address of the block register, then the 32-bit value settings
+and lastly the masking bits.
+
+Example:
+--------
+
+Configuration for multiple dtreg node support in device tree:
+
+	socfpga_mainfirewall: socfpga-mainfirewall {
+		compatible = "intel,socfpga-dtreg";
+                	#address-cells = <1>;
+                        #size-cells = <1>;
+		        bootph-all;
+
+                        coh_cpu0_bypass_OC_Firewall_main_Firewall@f7100200 {
+                        	reg = <0xf7100200 0x00000014>;
+                                intel,offset-settings =
+                                	/* Disable ocram security at CCU
+ for non secure

access */

doc/device-tree-bindings/misc/socfpga_dtreg.txt new file +28 -0
+                                        <0x0000004 0x8000ffff 0xe007ffff>,
+                                        <0x0000008 0x8000ffff 0xe007ffff>,
+                                        <0x000000c 0x8000ffff 0xe007ffff>,
+                                        <0x0000010 0x8000ffff 0xe007ffff>;
+                                bootph-all;
+                        };
+                };
+
+	socfpga_mpfefirewall: socfpga-mpfefirewall {
+        	compatible = "intel,socfpga-dtreg";
+                	#address-cells = <1>;
+                        #size-cells = <1>;
+			bootph-all;
+
+                        soc_noc_fw_mpfe_csr_inst_0_mpfe_scr@f8020000 {
+                                reg = <0xf8020000 0x0000001c>;
+                                intel,offset-settings =
+                                        /* Disable MPFE firewall for SMMU */
+                                        <0x00000000 0x00010101 0x00010101>,
+                                        /* Disable MPFE firewall for HMC adapter */
+                                        <0x00000004 0x00000001 0x00010101>;
+				bootph-all;
+                        };
+                };
+
+To call the nodes use:
+
+	ret = uclass_get_device_by_name(UCLASS_NOP, "socfpga-

mainfirewall", &dev);

doc/device-tree-bindings/misc/socfpga_dtreg.txt new file +1 -0
+	ret = uclass_get_device_by_name(UCLASS_NOP, "socfpga-

mpfefirewall",
+&dev);

doc/device-tree-bindings/misc/socfpga_dtreg.txt new file +1 -0
+
drivers/misc/Kconfig index renamed from drivers/misc/Kconfig +0 -0

fccd9b89b8..c423905ba2 100644

drivers/misc/Kconfig +7 -0
@@ -683,4 +683,11 @@ config SL28CPLD
  	  the base driver which provides common access methods for the
  	  sub-drivers.
 
+config SPL_SOCFPGA_DT_REG
+	bool "Enable register setting from device tree in SPL"
+	depends on SPL
+	help
+	  Enable register setting from device tree. This also
+	  provides user a clean interface and all register settings are
+	  centralized in one place, device tree.
  endmenu
drivers/misc/Makefile index renamed from drivers/misc/Makefile +0 -0

b67b82358a..8f813edd84 100644

drivers/misc/Makefile +1 -0
@@ -89,3 +89,4 @@ obj-$(CONFIG_K3_AVS0) += k3_avs.o
  obj-$(CONFIG_ESM_K3) += k3_esm.o
  obj-$(CONFIG_ESM_PMIC) += esm_pmic.o
  obj-$(CONFIG_SL28CPLD) += sl28cpld.o
+obj-$(CONFIG_SPL_SOCFPGA_DT_REG) += socfpga_dtreg.o
(quoted diff) +0 -0

b/drivers/misc/socfpga_dtreg.c new file mode 100644 index 0000000000..982f9592cb

drivers/misc/socfpga_dtreg.c line 8

Quoted 8 lines
drivers/misc/socfpga_dtreg.c new file +8 -0
@@ -0,0 +1,117 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (C) 2023 Intel Corporation <www.intel.com>  */
+
+#include <asm/io.h>
+#include <common.h>
+#include <dm.h>
+#include <errno.h>

Please move <asm/io.h> above to here

Quoted 4 lines
Quoted 1 line

drivers/misc/socfpga_dtreg.c line 10

Quoted 1 line
drivers/misc/socfpga_dtreg.c new file +1 -0
+#include <linux/sizes.h>

A good starting point would be to have socfpga 64bit maintainer , without that , these patches are only being archived .

Hi,

Is only one socfpga 64bit maintainer needed or the whole socfpga 64bit maintainer need to be included for this driver?

Thanks.

Regards,
Wan Yee

#4 lore raw

On 12/20/23 04:09, Lau, Wan Yee wrote:

Hi,

can you trim the CC list to relevant people ?

[...]

Quoted 13 lines
Quoted 13 lines
Quoted 13 lines

drivers/misc/socfpga_dtreg.c line 8

Quoted 10 lines

+++ b/drivers/misc/socfpga_dtreg.c

drivers/misc/socfpga_dtreg.c new file +8 -0
@@ -0,0 +1,117 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (C) 2023 Intel Corporation <www.intel.com>  */
+
+#include <asm/io.h>
+#include <common.h>
+#include <dm.h>
+#include <errno.h>

Please move <asm/io.h> above to here

Quoted 8 lines
Quoted 4 lines
Quoted 1 line

drivers/misc/socfpga_dtreg.c line 10

Quoted 1 line
drivers/misc/socfpga_dtreg.c new file +1 -0
+#include <linux/sizes.h>

A good starting point would be to have socfpga 64bit maintainer , without that , these patches are only being archived .

Hi,

Is only one socfpga 64bit maintainer needed or the whole socfpga 64bit maintainer need to be included for this driver?

U-Boot currently does not have any SoCFPGA 64bit maintainer, that needs to be fixed .

#5 lore raw
Quoted 49 lines

-----Original Message-----
From: Marek Vasut <[email protected]>
Sent: Thursday, December 21, 2023 12:11 AM
To: Lau, Wan Yee <[email protected]>; Chee, Tien Fong <[email protected]>; [email protected]
Cc: Simon Glass <[email protected]>; Kever Yang <[email protected]>; Bin Meng <[email protected]>; Jonas Karlman <[email protected]>; Jean- Marie Lemetayer <[email protected]>; Peng Fan <[email protected]>; Vladimir Zapolskiy <[email protected]>; Konrad Dybcio <[email protected]>; Simon Goldschmidt <[email protected]>; Hea, Kok Kiang <[email protected]>; Maniyam, Dinesh <[email protected]>; Ng, Boon Khai <[email protected]>; Yuslaimi, Alif Zakuan <[email protected]>; Chong, Teik Heng <[email protected]>; Zamri, Muhammad Hazim Izzat <[email protected]>; Lim, Jit Loon <[email protected]>; Tang, Sieu Mun <[email protected]>; Tom Rini <[email protected]>
Subject: Re: [PATCH v1 1/1] drivers: misc: Add socfpga_dtreg driver for Intel SoCFPGA

On 12/20/23 04:09, Lau, Wan Yee wrote:

Hi,

can you trim the CC list to relevant people ?

[...]

Quoted 18 lines
Quoted 17 lines
Quoted 4 lines
Quoted 4 lines

+++ b/drivers/misc/socfpga_dtreg.c

(quoted diff) +2 -0
@@ -0,0 +1,117 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
Quoted 10 lines

drivers/misc/socfpga_dtreg.c line 9

Quoted 6 lines
drivers/misc/socfpga_dtreg.c new file +6 -0
+ * Copyright (C) 2023 Intel Corporation <www.intel.com>  */
+
+#include <asm/io.h>
+#include <common.h>
+#include <dm.h>
+#include <errno.h>

Please move <asm/io.h> above to here

Quoted 1 line
drivers/misc/socfpga_dtreg.c new file +1 -0
+#include <linux/sizes.h>

A good starting point would be to have socfpga 64bit maintainer , without that , these patches are only being archived .

Quoted 7 lines
Quoted 3 lines

Hi,

Is only one socfpga 64bit maintainer needed or the whole socfpga 64bit

maintainer need to be included for this driver?

U-Boot currently does not have any SoCFPGA 64bit maintainer, that needs to be fixed .

Can you share the steps on how to get this fixed? Is there a guide on how to add/process new maintainers?

#6 lore raw
Quoted 51 lines · Wan Yee
Quoted 51 lines

-----Original Message-----
From: Marek Vasut <[email protected]>
Sent: Thursday, December 21, 2023 12:11 AM
To: Lau, Wan Yee <[email protected]>; Chee, Tien Fong <[email protected]>; [email protected]
Cc: Simon Glass <[email protected]>; Kever Yang <[email protected]>; Bin Meng <[email protected]>; Jonas Karlman <[email protected]>; Jean- Marie Lemetayer <[email protected]>; Peng Fan <[email protected]>; Vladimir Zapolskiy <[email protected]>; Konrad Dybcio <[email protected]>; Simon Goldschmidt <[email protected]>; Hea, Kok Kiang <[email protected]>; Maniyam, Dinesh <[email protected]>; Ng, Boon Khai <[email protected]>; Yuslaimi, Alif Zakuan <[email protected]>; Chong, Teik Heng <[email protected]>; Zamri, Muhammad Hazim Izzat <[email protected]>; Lim, Jit Loon <[email protected]>; Tang, Sieu Mun <[email protected]>; Tom Rini <[email protected]>
Subject: Re: [PATCH v1 1/1] drivers: misc: Add socfpga_dtreg driver for Intel SoCFPGA

On 12/20/23 04:09, Lau, Wan Yee wrote:

Hi,

can you trim the CC list to relevant people ?

[...]

Quoted 20 lines
Quoted 13 lines
Quoted 13 lines

drivers/misc/socfpga_dtreg.c line 8

Quoted 10 lines

+++ b/drivers/misc/socfpga_dtreg.c

drivers/misc/socfpga_dtreg.c new file +8 -0
@@ -0,0 +1,117 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (C) 2023 Intel Corporation <www.intel.com>  */
+
+#include <asm/io.h>
+#include <common.h>
+#include <dm.h>
+#include <errno.h>

Please move <asm/io.h> above to here

Quoted 4 lines
Quoted 1 line

drivers/misc/socfpga_dtreg.c line 10

Quoted 1 line
drivers/misc/socfpga_dtreg.c new file +1 -0
+#include <linux/sizes.h>

A good starting point would be to have socfpga 64bit maintainer , without that , these patches are only being archived .

Hi,

Quoted 8 lines
Quoted 5 lines
Quoted 1 line

Is only one socfpga 64bit maintainer needed or the whole socfpga 64bit

maintainer need to be included for this driver?

U-Boot currently does not have any SoCFPGA 64bit maintainer, that needs to be fixed .

Can you share the steps on how to get this fixed? Is there a guide on how to add/process new maintainers?

Well, the first step is to identify someone with familiarity with SoCFPGA and U-Boot and time to spend in the community.

Signature · 1 line
Tom
#7 lore raw
Quoted 77 lines

-----Original Message-----
From: Tom Rini <[email protected]>
Sent: Thursday, December 21, 2023 10:26 PM
To: Lau, Wan Yee <[email protected]>
Cc: Marek Vasut <[email protected]>; Chee, Tien Fong <[email protected]>; [email protected]; Hea, Kok Kiang <[email protected]>; Maniyam, Dinesh <[email protected]>; Ng, Boon Khai <[email protected]>; Yuslaimi, Alif Zakuan <[email protected]>; Chong, Teik Heng <[email protected]>; Zamri, Muhammad Hazim Izzat <[email protected]>; Lim, Jit Loon <[email protected]>; Tang, Sieu Mun <[email protected]>
Subject: Re: [PATCH v1 1/1] drivers: misc: Add socfpga_dtreg driver for Intel SoCFPGA

Quoted 59 lines · Wan Yee
Quoted 58 lines

-----Original Message-----
From: Marek Vasut <[email protected]>
Sent: Thursday, December 21, 2023 12:11 AM
To: Lau, Wan Yee <[email protected]>; Chee, Tien Fong <[email protected]>; [email protected]
Cc: Simon Glass <[email protected]>; Kever Yang <[email protected]>; Bin Meng <[email protected]>; Jonas Karlman <[email protected]>; Jean- Marie Lemetayer <[email protected]>; Peng Fan <[email protected]>; Vladimir Zapolskiy <[email protected]>; Konrad Dybcio <[email protected]>; Simon Goldschmidt <[email protected]>; Hea, Kok Kiang <[email protected]>; Maniyam, Dinesh <[email protected]>; Ng, Boon Khai <[email protected]>; Yuslaimi, Alif Zakuan <[email protected]>; Chong, Teik Heng <[email protected]>; Zamri, Muhammad Hazim Izzat <[email protected]>; Lim, Jit Loon <[email protected]>; Tang, Sieu Mun <[email protected]>; Tom Rini <[email protected]>
Subject: Re: [PATCH v1 1/1] drivers: misc: Add socfpga_dtreg driver for Intel SoCFPGA

On 12/20/23 04:09, Lau, Wan Yee wrote:

Hi,

can you trim the CC list to relevant people ?

[...]

Quoted 15 lines
Quoted 15 lines
Quoted 14 lines

Review line 8

Quoted 10 lines

+++ b/drivers/misc/socfpga_dtreg.c

(quoted diff) +8 -0
@@ -0,0 +1,117 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (C) 2023 Intel Corporation <www.intel.com>  */
+
+#include <asm/io.h>
+#include <common.h>
+#include <dm.h>
+#include <errno.h>

Please move <asm/io.h> above to here

Quoted 1 line
(quoted diff) +1 -0
+#include <linux/sizes.h>
Quoted 7 lines
Quoted 2 lines

A good starting point would be to have socfpga 64bit maintainer , without that , these patches are only being archived .

Hi,

Is only one socfpga 64bit maintainer needed or the whole socfpga 64bit

maintainer need to be included for this driver?

U-Boot currently does not have any SoCFPGA 64bit maintainer, that needs to be fixed .

Quoted 8 lines
Quoted 2 lines

Can you share the steps on how to get this fixed? Is there a guide on how to add/process new maintainers?

Well, the first step is to identify someone with familiarity with SoCFPGA and U- Boot and time to spend in the community.

--
Tom

Thanks. What is the next step after identifying the person that fits the requirement? How do I proceed with adding the new maintainers.

#8 lore raw
Quoted 80 lines · Wan Yee
Quoted 80 lines

-----Original Message-----
From: Tom Rini <[email protected]>
Sent: Thursday, December 21, 2023 10:26 PM
To: Lau, Wan Yee <[email protected]>
Cc: Marek Vasut <[email protected]>; Chee, Tien Fong <[email protected]>; [email protected]; Hea, Kok Kiang <[email protected]>; Maniyam, Dinesh <[email protected]>; Ng, Boon Khai <[email protected]>; Yuslaimi, Alif Zakuan <[email protected]>; Chong, Teik Heng <[email protected]>; Zamri, Muhammad Hazim Izzat <[email protected]>; Lim, Jit Loon <[email protected]>; Tang, Sieu Mun <[email protected]>
Subject: Re: [PATCH v1 1/1] drivers: misc: Add socfpga_dtreg driver for Intel SoCFPGA

Quoted 61 lines · Wan Yee
Quoted 50 lines

-----Original Message-----
From: Marek Vasut <[email protected]>
Sent: Thursday, December 21, 2023 12:11 AM
To: Lau, Wan Yee <[email protected]>; Chee, Tien Fong <[email protected]>; [email protected]
Cc: Simon Glass <[email protected]>; Kever Yang <[email protected]>; Bin Meng <[email protected]>; Jonas Karlman <[email protected]>; Jean- Marie Lemetayer <[email protected]>; Peng Fan <[email protected]>; Vladimir Zapolskiy <[email protected]>; Konrad Dybcio <[email protected]>; Simon Goldschmidt <[email protected]>; Hea, Kok Kiang <[email protected]>; Maniyam, Dinesh <[email protected]>; Ng, Boon Khai <[email protected]>; Yuslaimi, Alif Zakuan <[email protected]>; Chong, Teik Heng <[email protected]>; Zamri, Muhammad Hazim Izzat <[email protected]>; Lim, Jit Loon <[email protected]>; Tang, Sieu Mun <[email protected]>; Tom Rini <[email protected]>
Subject: Re: [PATCH v1 1/1] drivers: misc: Add socfpga_dtreg driver for Intel SoCFPGA

On 12/20/23 04:09, Lau, Wan Yee wrote:

Hi,

can you trim the CC list to relevant people ?

[...]

Quoted 18 lines
Quoted 17 lines
Quoted 4 lines
Quoted 4 lines

+++ b/drivers/misc/socfpga_dtreg.c

(quoted diff) +2 -0
@@ -0,0 +1,117 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
Quoted 10 lines

Review line 8

Quoted 6 lines
(quoted diff) +6 -0
+ * Copyright (C) 2023 Intel Corporation <www.intel.com>  */
+
+#include <asm/io.h>
+#include <common.h>
+#include <dm.h>
+#include <errno.h>

Please move <asm/io.h> above to here

Quoted 1 line
(quoted diff) +1 -0
+#include <linux/sizes.h>

A good starting point would be to have socfpga 64bit maintainer , without that , these patches are only being archived .

Quoted 8 lines
Quoted 4 lines

Hi,

Is only one socfpga 64bit maintainer needed or the whole socfpga 64bit

maintainer need to be included for this driver?

U-Boot currently does not have any SoCFPGA 64bit maintainer, that needs to be fixed .

Can you share the steps on how to get this fixed? Is there a guide on how to add/process new maintainers?

Quoted 8 lines
Quoted 5 lines

Well, the first step is to identify someone with familiarity with SoCFPGA and U- Boot and time to spend in the community.

--
Tom

Thanks. What is the next step after identifying the person that fits the requirement? How do I proceed with adding the new maintainers.

Having them talk with me, off list.

Signature · 1 line
Tom