Patch "spi: imx: add a device specific prepare_message callback" has been added to the 4.19-stable tree

DISCUSSION Uwe Kleine-König 3 participants 3 messages Dec 8, 2023 – Dec 9, 2023 1 message not in the archive Stable branch

lore

Share & tools

lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Uwe Kleine-König

author

2023-12-08 10:48 UTC #1 lore raw

Hello,

Quoted 24 lines · Sasha Levin

This is a note to let you know that I've just added the patch titled
spi: imx: add a device specific prepare_message callback
to the 4.19-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
spi-imx-add-a-device-specific-prepare_message-callba.patch
and it can be found in the queue-4.19 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
commit b19a3770ce84da3c16acc7142e754cd8ff80ad3d
Author: Uwe Kleine-König <[email protected]>
Date:   Fri Nov 30 07:47:05 2018 +0100
spi: imx: add a device specific prepare_message callback
[ Upstream commit e697271c4e2987b333148e16a2eb8b5b924fd40a ]

Quoted 8 lines

This is just preparatory work which allows to move some initialisation that currently is done in the per transfer hook .config to an earlier point in time in the next few patches. There is no change in behaviour introduced by this patch.
Signed-off-by Uwe Kleine-König <[email protected]>
Signed-off-by Mark Brown <[email protected]>
Signed-off-by Sasha Levin <[email protected]>

The patch alone shouldn't be needed for stable and there is no indication that it's a dependency for another patch. Is this an oversight?

Other than that: IMHO the subject for this type of report could be improved. Currently it's:

Subject: Patch "spi: imx: add a device specific prepare_message callback" has been added to the 4.19-stable tree

The most important part of it is "4.19-stable", but that only appears after character column 90 and so my MUA doesn't show it unless the window is wider than my default setting. Maybe make this:

Subject: for-stable-4.19: "spi: imx: add a device specific prepare_message callback"

Another thing I wonder about is: The mail contains

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

but it wasn't sent to [email protected].

Best regards
Uwe

Signature · 2 lines

Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Sasha Levin

maintainer

2023-12-09 06:35 UTC #2 lore raw

Quoted 32 lines · Uwe Kleine-König

Hello,
Quoted 29 lines · Sasha Levin
This is a note to let you know that I've just added the patch titled
spi: imx: add a device specific prepare_message callback
to the 4.19-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
spi-imx-add-a-device-specific-prepare_message-callba.patch
and it can be found in the queue-4.19 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
commit b19a3770ce84da3c16acc7142e754cd8ff80ad3d
Author: Uwe Kleine-König <[email protected]>
Date:   Fri Nov 30 07:47:05 2018 +0100
spi: imx: add a device specific prepare_message callback
[ Upstream commit e697271c4e2987b333148e16a2eb8b5b924fd40a ]
This is just preparatory work which allows to move some initialisation that currently is done in the per transfer hook .config to an earlier point in time in the next few patches. There is no change in behaviour introduced by this patch.

Quoted 7 lines

Quoted 3 lines
Signed-off-by Uwe Kleine-König <[email protected]>
Signed-off-by Mark Brown <[email protected]>
Signed-off-by Sasha Levin <[email protected]>
The patch alone shouldn't be needed for stable and there is no indication that it's a dependency for another patch. Is this an oversight?

It is, appologies. I've been traveling and my patch-shuffling-fu isn't doing well with conference/jetlag.

This is a dependency for 00b80ac93553 ("spi: imx: mx51-ecspi: Move some initialisation to prepare_message hook.").

Quoted 11 lines

Other than that: IMHO the subject for this type of report could be improved. Currently it's:
Subject: Patch "spi: imx: add a device specific prepare_message callback" has been added to the 4.19-stable tree
The most important part of it is "4.19-stable", but that only appears after character column 90 and so my MUA doesn't show it unless the window is wider than my default setting. Maybe make this:
Subject: for-stable-4.19: "spi: imx: add a device specific prepare_message callback"
?

I borrowed the format from Greg, and I'd say that if we make changes then we should be consistent with eachother.

No objections on my end; maybe I'd even go further and try and send one email per patch rather than one mail per patch/tree.

Or... finally drop the stable-commits mailing list altogether? Does anyone still need this (vs. just looking at -rcs)?

Greg?

Quoted 6 lines

Another thing I wonder about is: The mail contains
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
but it wasn't sent to [email protected].

Good point. I figured we want to reduce the spam on stable@ since you'd see a mail about this patch in the -rc mails, and so stable@ isn't cc'ed, but I can definitely add a reply-to header.

Thanks!

Signature · 2 lines

Thanks,
Sasha

Greg KH

2023-12-09 11:29 UTC #3 lore raw

Quoted 55 lines · Sasha Levin

Quoted 32 lines · Uwe Kleine-König
Hello,
Quoted 29 lines · Sasha Levin
This is a note to let you know that I've just added the patch titled
spi: imx: add a device specific prepare_message callback
to the 4.19-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
spi-imx-add-a-device-specific-prepare_message-callba.patch
and it can be found in the queue-4.19 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
commit b19a3770ce84da3c16acc7142e754cd8ff80ad3d
Author: Uwe Kleine-König <[email protected]>
Date:   Fri Nov 30 07:47:05 2018 +0100
spi: imx: add a device specific prepare_message callback
[ Upstream commit e697271c4e2987b333148e16a2eb8b5b924fd40a ]
This is just preparatory work which allows to move some initialisation that currently is done in the per transfer hook .config to an earlier point in time in the next few patches. There is no change in behaviour introduced by this patch.
Quoted 7 lines
Quoted 3 lines
Signed-off-by Uwe Kleine-König <[email protected]>
Signed-off-by Mark Brown <[email protected]>
Signed-off-by Sasha Levin <[email protected]>
The patch alone shouldn't be needed for stable and there is no indication that it's a dependency for another patch. Is this an oversight?
It is, appologies. I've been traveling and my patch-shuffling-fu isn't doing well with conference/jetlag.
This is a dependency for 00b80ac93553 ("spi: imx: mx51-ecspi: Move some initialisation to prepare_message hook.").
Quoted 8 lines
Other than that: IMHO the subject for this type of report could be improved. Currently it's:
Subject: Patch "spi: imx: add a device specific prepare_message callback" has been added to the 4.19-stable tree
The most important part of it is "4.19-stable", but that only appears after character column 90 and so my MUA doesn't show it unless the window is wider than my default setting. Maybe make this:

Quoted 6 lines

Quoted 3 lines
Subject: for-stable-4.19: "spi: imx: add a device specific prepare_message callback"
?
I borrowed the format from Greg, and I'd say that if we make changes then we should be consistent with eachother.

Sure, I can change my script, but better yet, can you send a patch against this file:
https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/tree/scripts/added-to-stable

Quoted 2 lines

No objections on my end; maybe I'd even go further and try and send one email per patch rather than one mail per patch/tree.

one-per-patch isn't going to work, sorry, as I push out queues separately.

Quoted 4 lines

Or... finally drop the stable-commits mailing list altogether? Does anyone still need this (vs. just looking at -rcs)?
Greg?

Yes, we still need it, we want a public record of what is merged, and that is what the mailing list archives provide.

thanks,

greg k-h