Skip to contentSkip to conversation

ARM/dma-mapping: replace kzalloc() and vzalloc() with kvzalloc()

PATCH In review [email protected] 4 participants 5 messages Dec 12, 2023 – Dec 14, 2023 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM/dma-mapping: replace kzalloc() and vzalloc() with kvzalloc()

From: Yang Guang <[email protected]>
using kvzalloc() simplifies the code by avoiding the use of different memory allocation functions for different situations, making the code more uniform and readable.

---
 arch/arm/mm/dma-mapping.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
arch/arm/mm/dma-mapping.c +1 -4
index 5409225b4abc..d688eac6dbc1 100644
@@ -859,10 +859,7 @@ static struct page **__iommu_alloc_buffer(struct device *dev, size_t size,
 	int i = 0;
 	int order_idx = 0;
 
-	if (array_size <= PAGE_SIZE)
-		pages = kzalloc(array_size, GFP_KERNEL);
-	else
-		pages = vzalloc(array_size);
+	pages = kvzalloc(array_size, GFP_KERNEL);
 	if (!pages)
 		return NULL;
 
Signature · 1 line
2.25.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · On Tue, Dec 12, 2023 at 4:20 AM <[email protected]> wrote:

From: Yang Guang <[email protected]>
using kvzalloc() simplifies the code by avoiding the use of different memory allocation functions for different situations, making the code more uniform and readable.

Looks good to me:

Please put this patch into Russell's patch tracker.

Yours,
Linus Walleij

#2 lore raw
Quoted 3 lines

Looks good to me:

Please put this patch into Russell's patch tracker.

Hello, I would like to ask, do you mean to have
me CC the patch email to Russell?I don't really
understand what patch tracker means.Thank you.

#3 lore raw
Quoted 7 lines · On Wed, Dec 13, 2023 at 3:41 PM <[email protected]> wrote:
Quoted 3 lines

Looks good to me:

Please put this patch into Russell's patch tracker.

Hello, I would like to ask, do you mean to have
me CC the patch email to Russell?I don't really
understand what patch tracker means.Thank you.

This is Russell's patch tracker:
https://www.armlinux.org.uk/developer/patches/

Create an account, read the help text, you can submit patches using a web interface or through mail.

Yours,
Linus Walleij

#4 lore raw
Quoted 10 lines · Linus Walleij
Quoted 7 lines · On Wed, Dec 13, 2023 at 3:41 PM <[email protected]> wrote:
Quoted 3 lines

Looks good to me:

Please put this patch into Russell's patch tracker.

Hello, I would like to ask, do you mean to have
me CC the patch email to Russell?I don't really
understand what patch tracker means.Thank you.

Quoted 5 lines

This is Russell's patch tracker:
https://www.armlinux.org.uk/developer/patches/

Create an account, read the help text, you can submit patches using a web interface or through mail.

No need to create an account if submitting by email, that will happen automatically on the successful receipt of a patch, except of course with password access blocked until a "forgotten password" thing is done.

However, well worth reading the bit about adding a KernelVersion: tag somewhere in the email!

Signature · 2 lines
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!