pinctrl: intel: Add Intel Meteor Point pin controller and GPIO support
Subsystems (3)
PATCH 1/1 pinctrl: intel: Add Intel Meteor Point pin controller and GPIO support
This driver supports pinctrl/GPIO hardware found on Intel Meteor Point (a Meteor Lake PCH) providing users a pinctrl and GPIO interfaces including GPIO interrupts.
--- drivers/pinctrl/intel/Kconfig | 9 + drivers/pinctrl/intel/Makefile | 1 + drivers/pinctrl/intel/pinctrl-meteorpoint.c | 465 ++++++++++++++++++++ 3 files changed, 475 insertions(+) create mode 100644 drivers/pinctrl/intel/pinctrl-meteorpoint.c
drivers/pinctrl/intel/Kconfig +9 -0
@@ -138,6 +138,15 @@ config PINCTRL_METEORLAKE This pinctrl driver provides an interface that allows configuring of Intel Meteor Lake pins and using them as GPIOs. +config PINCTRL_METEORPOINT + tristate "Intel Meteor Point pinctrl and GPIO driver" + depends on ACPI + select PINCTRL_INTEL + help + Meteor Point is the PCH of Intel Meteor Lake. This pinctrl driver + provides an interface that allows configuring of PCH pins and + using them as GPIOs. + config PINCTRL_SUNRISEPOINT tristate "Intel Sunrisepoint pinctrl and GPIO driver" select PINCTRL_INTEL
drivers/pinctrl/intel/Makefile +1 -0
@@ -22,5 +22,6 @@ obj-$(CONFIG_PINCTRL_JASPERLAKE) += pinctrl-jasperlake.o obj-$(CONFIG_PINCTRL_LAKEFIELD) += pinctrl-lakefield.o obj-$(CONFIG_PINCTRL_LEWISBURG) += pinctrl-lewisburg.o obj-$(CONFIG_PINCTRL_METEORLAKE) += pinctrl-meteorlake.o +obj-$(CONFIG_PINCTRL_METEORPOINT) += pinctrl-meteorpoint.o obj-$(CONFIG_PINCTRL_SUNRISEPOINT) += pinctrl-sunrisepoint.o obj-$(CONFIG_PINCTRL_TIGERLAKE) += pinctrl-tigerlake.o
drivers/pinctrl/intel/pinctrl-meteorpoint.c new file +465 -0
465 lines not on this page · raw message
Signature · 1 line
2.43.0.rc1.1.gbec44491f096
Mika Westerberg
maintainerQuoted 3 lines · Andy Shevchenko
This driver supports pinctrl/GPIO hardware found on Intel Meteor Point (a Meteor Lake PCH) providing users a pinctrl and GPIO interfaces including GPIO interrupts.
This is driver for Meteor Lake-S and related, correct? Why it cannot use pinctrl-meteorlake.c instead? Same way we do for other desktop CPUs whose PCHs have the GPIO/pinctrl block.
Quoted 8 lines · Mika Westerberg
Quoted 3 lines · Andy Shevchenko
This driver supports pinctrl/GPIO hardware found on Intel Meteor Point (a Meteor Lake PCH) providing users a pinctrl and GPIO interfaces including GPIO interrupts.
This is driver for Meteor Lake-S and related, correct? Why it cannot use
pinctrl-meteorlake.cinstead? Same way we do for other desktop CPUs whose PCHs have the GPIO/pinctrl block.
Meteor Lake-S may or may not have an additional PCH, so the SoC (on-die) pin control IP is serviced by pinctrl-meteorlake.c, here we need to have a different file as we would have a name clash. Yes, it means that on the end user platform it may be two pin control drivers!
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 6 lines · Andy Shevchenko
Quoted 5 lines · Mika Westerberg
Quoted 3 lines · Andy Shevchenko
This driver supports pinctrl/GPIO hardware found on Intel Meteor Point (a Meteor Lake PCH) providing users a pinctrl and GPIO interfaces including GPIO interrupts.
Quoted 8 lines
Quoted 3 lines
This is driver for Meteor Lake-S and related, correct? Why it cannot use
pinctrl-meteorlake.cinstead? Same way we do for other desktop CPUs whose PCHs have the GPIO/pinctrl block.Meteor Lake-S may or may not have an additional PCH, so the SoC (on-die) pin control IP is serviced by
pinctrl-meteorlake.c, here we need to have a different file as we would have a name clash. Yes, it means that on the end user platform it may be two pin control drivers!
I see, thanks for clarification! Then this makes sense.
Quoted 11 lines · Mika Westerberg
Quoted 10 lines · Andy Shevchenko
Quoted 8 lines · Mika Westerberg
Quoted 3 lines · Andy Shevchenko
This driver supports pinctrl/GPIO hardware found on Intel Meteor Point (a Meteor Lake PCH) providing users a pinctrl and GPIO interfaces including GPIO interrupts.
This is driver for Meteor Lake-S and related, correct? Why it cannot use
pinctrl-meteorlake.cinstead? Same way we do for other desktop CPUs whose PCHs have the GPIO/pinctrl block.
Quoted 8 lines
Quoted 4 lines
Meteor Lake-S may or may not have an additional PCH, so the SoC (on-die) pin control IP is serviced by
pinctrl-meteorlake.c, here we need to have a different file as we would have a name clash. Yes, it means that on the end user platform it may be two pin control drivers!I see, thanks for clarification! Then this makes sense.
Acked-by Mika Westerberg <[email protected]>
Pushed to my review and testing queue, thanks!
Signature · 2 lines
With Best Regards, Andy Shevchenko