Skip to contentSkip to conversation

drm/nouveau/disp: switch to use kmemdup() helper

PATCH Superseded [email protected] 3 participants 3 messages Dec 14, 2023 – Jan 8, 2024

Subsystems (3)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/nouveau/disp: switch to use kmemdup() helper

From: Yang Guang <[email protected]>

Use kmemdup() helper instead of open-coding to
simplify the code.

---
 drivers/gpu/drm/nouveau/nvif/outp.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/gpu/drm/nouveau/nvif/outp.c +1 -2
index 5d3190c05250..6daeb7f0b09b 100644
@@ -452,13 +452,12 @@ nvif_outp_edid_get(struct nvif_outp *outp, u8 **pedid)
 	if (ret)
 		goto done;
 
-	*pedid = kmalloc(args->size, GFP_KERNEL);
+	*pedid = kmemdup(args->data, args->size, GFP_KERNEL);
 	if (!*pedid) {
 		ret = -ENOMEM;
 		goto done;
 	}
 
-	memcpy(*pedid, args->data, args->size);
 	ret = args->size;
 done:
 	kfree(args);
Signature · 1 line
2.25.1
#2 lore raw
In reply to [email protected]

Hi Yang,

Quoted 6 lines · On 12/14/23 13:03, [email protected] wrote:

From: Yang Guang <[email protected]>

Use kmemdup() helper instead of open-coding to
simplify the code.

Please add your "Signed-off-by" tag to this patch. If the above is intended to indicate that Chan was involved in creating this patch (e.g. as co-author, reporter, etc.) please use the corresponding tag instead. See also [1].

Once this is fixed, I'll apply the patch.

- Danilo

[1] https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin

Quoted 23 lines
---
  drivers/gpu/drm/nouveau/nvif/outp.c | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)
drivers/gpu/drm/nouveau/nvif/outp.c +1 -2
index 5d3190c05250..6daeb7f0b09b 100644
@@ -452,13 +452,12 @@ nvif_outp_edid_get(struct nvif_outp *outp, u8 **pedid)
  	if (ret)
  		goto done;
 
-	*pedid = kmalloc(args->size, GFP_KERNEL);
+	*pedid = kmemdup(args->data, args->size, GFP_KERNEL);
  	if (!*pedid) {
  		ret = -ENOMEM;
  		goto done;
  	}
 
-	memcpy(*pedid, args->data, args->size);
  	ret = args->size;
  done:
  	kfree(args);