Skip to contentSkip to conversation

fs: remove duplicated including of posix_acl.h

PATCH In review Wang Jinchao 2 participants 2 messages Dec 15, 2023 Overlay filesystem

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fs: remove duplicated including of posix_acl.h

remove the second including of linux/posix_acl.h

---
 fs/overlayfs/inode.c | 1 -
 1 file changed, 1 deletion(-)
fs/overlayfs/inode.c +0 -1
index c63b31a460be..2003425875d9 100644
@@ -14,7 +14,6 @@
 #include <linux/fileattr.h>
 #include <linux/security.h>
 #include <linux/namei.h>
-#include <linux/posix_acl.h>
 #include <linux/posix_acl_xattr.h>
 #include "overlayfs.h"
 
Signature · 1 line
2.40.0
maintainer
#1 lore raw
Quoted 13 lines · Wang Jinchao

remove the second including of linux/posix_acl.h

---
 fs/overlayfs/inode.c | 1 -
 1 file changed, 1 deletion(-)
fs/overlayfs/inode.c +0 -0
index c63b31a460be..2003425875d9 100644

fs/overlayfs/inode.c line 19

Quoted 7 lines
fs/overlayfs/inode.c +0 -1
@@ -14,7 +14,6 @@
 #include <linux/fileattr.h>
 #include <linux/security.h>
 #include <linux/namei.h>
-#include <linux/posix_acl.h>
 #include <linux/posix_acl_xattr.h>
 #include "overlayfs.h"
 

Since both posix_acl.h and posix_acl_xattr.h are included by overlayfs.h I would rather remove them both including the first posix_acl.h include.

It is far from being the only duplicate include in "overlayfs.h" and it is not important enough IMO to start a cleanup project, but if you are going to tidy up includes for a particular file, I'd rather use the opportunity to cleanup that duplicity as well.

Thanks,
Amir.