Skip to contentSkip to conversation

nilfs2: Add missing set_freezable() for freezable kthread

PATCH In review Kevin Hao 2 participants 2 messages Dec 17, 2023 NILFS2 filesystem

lore
Share & tools
lore

Kevin Hao

author
#0 lore raw

PATCH 1/1 nilfs2: Add missing set_freezable() for freezable kthread

The kernel thread function nilfs_segctor_thread() invokes the try_to_freeze() in its loop. But all the kernel threads are non-freezable by default. So if we want to make a kernel thread to be freezable, we have to invoke set_freezable() explicitly.

---
 fs/nilfs2/segment.c | 1 +
 1 file changed, 1 insertion(+)
fs/nilfs2/segment.c +1 -0
index 52995838f2de..2590a0860eab 100644
@@ -2588,6 +2588,7 @@ static int nilfs_segctor_thread(void *arg)
 		   "segctord starting. Construction interval = %lu seconds, CP frequency < %lu seconds",
 		   sci->sc_interval / HZ, sci->sc_mjcp_freq / HZ);
 
+	set_freezable();
 	spin_lock(&sci->sc_state_lock);
  loop:
 	for (;;) {
Signature · 1 line
2.39.2
maintainer
#1 lore raw
Quoted 10 lines · Kevin Hao

The kernel thread function nilfs_segctor_thread() invokes the try_to_freeze() in its loop. But all the kernel threads are non-freezable by default. So if we want to make a kernel thread to be freezable, we have to invoke set_freezable() explicitly.

---
 fs/nilfs2/segment.c | 1 +
 1 file changed, 1 insertion(+)

Thank you!
I'll grab this and send it upstream.

Ryusuke Konishi

Quoted 16 lines
fs/nilfs2/segment.c +1 -1
index 52995838f2de..2590a0860eab 100644
@@ -2588,6 +2588,7 @@ static int nilfs_segctor_thread(void *arg)
                   "segctord starting. Construction interval = %lu seconds, CP frequency < %lu seconds",
                   sci->sc_interval / HZ, sci->sc_mjcp_freq / HZ);
 
+       set_freezable();
        spin_lock(&sci->sc_state_lock);
  loop:
        for (;;) {
--

2.39.2