Skip to contentSkip to conversation

drm/nouveau/therm: remove redundant duty == target check

PATCH New Colin Ian King 1 participant 1 message Dec 19, 2023

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/nouveau/therm: remove redundant duty == target check

The check for duty == target is always false because it is in an if block where duty != target. A previous change added the duty != target check and so the check duty == target check is now redundant and can be removed. Cleans up a cppcheck warning:

drivers/gpu/drm/nouveau/nvkm/subdev/therm/fan.c:93:17: warning: Opposite inner 'if' condition leads to a dead code block. [oppositeInnerCondition]

Fixes e4311ee51d1e ("drm/nouveau/therm: remove ineffective workarounds for alarm bugs")
---
 drivers/gpu/drm/nouveau/nvkm/subdev/therm/fan.c | 2 --
 1 file changed, 2 deletions(-)
drivers/gpu/drm/nouveau/nvkm/subdev/therm/fan.c +0 -2
index f8fa43c8a7d2..c4aaf7473065 100644
@@ -90,8 +90,6 @@ nvkm_fan_update(struct nvkm_fan *fan, bool immediate, int target)
 
 		if (duty > target)
 			delay = slow_down_period;
-		else if (duty == target)
-			delay = min(bump_period, slow_down_period) ;
 		else
 			delay = bump_period;
 
Signature · 1 line
2.39.2