Skip to contentSkip to conversation

staging:vme_user:Fix the issue of return the wrong error code

PATCH RESEND Superseded Piro Yang 2 participants 2 messages Dec 19, 2023

Subsystems (2)

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore

Piro Yang

author
#0 lore raw

PATCH RESEND v3 1/1 staging:vme_user:Fix the issue of return the wrong error code

Fixed the issue of returning the -ENOSYS error code when an error occurs.

The error code of -ENOSYS indicates Invalid system call number, but there is not system call error. So replace -ENOSYS error code by using -EINVAL error code to return.

---
v3: change the description and format for the patch.

v2: split two different changes,
only fix the issue of wrong error code.

---
 drivers/staging/vme_user/vme.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/vme_user/vme.c +1 -1
index 5c416c31ec57..9bc2d35405af 100644
@@ -341,7 +341,7 @@ int vme_slave_set(struct vme_resource *resource, int enabled,
 
 	if (!bridge->slave_set) {
 		dev_err(bridge->parent, "Function not supported\n");
-		return -ENOSYS;
+		return -EINVAL;
 	}
 
 	if (!(((image->address_attr & aspace) == aspace) &&
Signature · 1 line
2.25.1
#1 lore raw

The subject line looks wrong. Normally there are spaces after :. Look at what others have done on this file and do the same.

Also, did you previously send a V3? Resend is only for when you are sending exactly the same thing you sent previously, not because you fixed something up.

Quoted 7 lines · Piro Yang

Fixed the issue of returning the -ENOSYS error code when an error occurs.

The error code of -ENOSYS indicates Invalid system call number, but there is not system call error. So replace -ENOSYS error code by using -EINVAL error code to return.

Quoted 7 lines

---
v3: change the description and format for the patch.

v2: split two different changes,
only fix the issue of wrong error code.
---

The second --- is not needed.

Finally, it's not the application period of Outreachy, so please don't use the list [email protected]. That's only for outreachy applicants.

thanks,
julia

Quoted 21 lines
 drivers/staging/vme_user/vme.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/vme_user/vme.c +1 -2
index 5c416c31ec57..9bc2d35405af 100644
@@ -341,7 +341,7 @@ int vme_slave_set(struct vme_resource *resource, int enabled,
 
 	if (!bridge->slave_set) {
 		dev_err(bridge->parent, "Function not supported\n");
-		return -ENOSYS;
+		return -EINVAL;
 	}
 
 	if (!(((image->address_attr & aspace) == aspace) &&
--

2.25.1