drm/xe: Remove uninitialized variable from warning
Subsystems (2)
PATCH 1/1 drm/xe: Remove uninitialized variable from warning
"err" is not initialized when failing to create and add the freq0 sysfs file. Remove it from the message. This fixes the following warning with clang:
../drivers/gpu/drm/xe/xe_gt_freq.c:202:30: error: variable 'err' is uninitialized when used here [-Werror,-Wuninitialized] kobject_name(gt->sysfs), err); ^~~
Fixes fc5b7e3efff3 ("drm/xe: Create a xe_gt_freq component for raw management and sysfs")
Signed-off-by Lucas De Marchi <[email protected]>
--- drivers/gpu/drm/xe/xe_gt_freq.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/xe/xe_gt_freq.c +2 -2
@@ -198,8 +198,8 @@ void xe_gt_freq_init(struct xe_gt *gt) gt->freq =kobject_create_and_add ("freq0" , gt->sysfs);if (!gt->freq) { -drm_warn (&xe->drm,"failed to add freq0 directory to %s, err: %d\n" , -kobject_name (gt->sysfs), err); +drm_warn (&xe->drm,"failed to add freq0 directory to %s\n" , +kobject_name (gt->sysfs));return ; }
Signature · 1 line
2.40.1
Quoted 10 lines · Lucas De Marchi
"err" is not initialized when failing to create and add the freq0 sysfs file. Remove it from the message. This fixes the following warning with clang:
../drivers/gpu/drm/xe/xe_gt_freq.c:202:30: error: variable 'err' is uninitialized when used here [-Werror,-Wuninitialized] kobject_name(gt->sysfs), err); ^~~Fixes fc5b7e3efff3 ("drm/xe: Create a xe_gt_freq component for raw management and sysfs")Signed-off-by Lucas De Marchi <[email protected]>
Reviewed-by Michał Winiarski <[email protected]>
-Michał
Quoted 22 lines
--- drivers/gpu/drm/xe/xe_gt_freq.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/xe/xe_gt_freq.c +2
-2@@ -198,8 +198,8 @@ void xe_gt_freq_init(struct xe_gt *gt) gt->freq =kobject_create_and_add ("freq0" , gt->sysfs);if (!gt->freq) { -drm_warn (&xe->drm,"failed to add freq0 directory to %s, err: %d\n" , -kobject_name (gt->sysfs), err); +drm_warn (&xe->drm,"failed to add freq0 directory to %s\n" , +kobject_name (gt->sysfs));return ; }Signature · 1 line
2.40.1