drm/xe: Add mocs reset kunit
Subsystems (2)
PATCH 1/1 drm/xe: Add mocs reset kunit
From: Ruthuvikas Ravikumar <[email protected]>
This kunit verifies the mocs registers content
with the KMD programmed values before and after
GT reset.
Cc Mathew D Roper <[email protected]>
Signed-off-by Ruthuvikas Ravikumar <[email protected]>
Signed-off-by Janga Rahul Kumar <[email protected]>
--- drivers/gpu/drm/xe/tests/xe_mocs.c | 38 +++++++++++++++++++++++++ drivers/gpu/drm/xe/tests/xe_mocs_test.c | 1 + drivers/gpu/drm/xe/tests/xe_mocs_test.h | 1 + 3 files changed, 40 insertions(+)
drivers/gpu/drm/xe/tests/xe_mocs.c +38 -0
@@ -128,3 +128,41 @@ void xe_live_mocs_kernel_kunit(struct kunit *test)xe_call_for_each_device (mocs_kernel_test_run_device); }EXPORT_SYMBOL_IF_KUNIT (xe_live_mocs_kernel_kunit); + +static int mocs_reset_test_run_device (struct xe_device *xe) +{ +/* Check the mocs setup is retained over GT reset */ + +struct live_mocs mocs; +struct xe_gt *gt; + +unsigned int flags; +int id; + +struct kunit *test =xe_cur_kunit (); + +for_each_gt (gt, xe, id) { + flags =live_mocs_init (&mocs, gt); +kunit_info (test,"mocs_reset_test before reset\n" ); +if (flags &HAS_GLOBAL_MOCS ) +read_mocs_table (gt, &mocs.table); +if (flags &HAS_LNCF_MOCS ) +read_l3cc_table (gt, &mocs.table); + +xe_gt_reset_async (gt); +flush_work (>->reset.worker); + +kunit_info (test,"mocs_reset_test after reset\n" ); +if (flags &HAS_GLOBAL_MOCS ) +read_mocs_table (gt, &mocs.table); +if (flags &HAS_LNCF_MOCS ) +read_l3cc_table (gt, &mocs.table); + } +return 0 ; +} + +void xe_live_mocs_reset_kunit (struct kunit *test) +{ +xe_call_for_each_device (mocs_reset_test_run_device); +} +EXPORT_SYMBOL_IF_KUNIT (xe_live_mocs_reset_kunit);
drivers/gpu/drm/xe/tests/xe_mocs_test.c +1 -0
@@ -9,6 +9,7 @@static struct kunit_case xe_mocs_tests[] = {KUNIT_CASE (xe_live_mocs_kernel_kunit), +KUNIT_CASE (xe_live_mocs_reset_kunit), {} };
drivers/gpu/drm/xe/tests/xe_mocs_test.h +1 -0
@@ -9,5 +9,6 @@struct kunit ;void xe_live_mocs_kernel_kunit (struct kunit *test); +void xe_live_mocs_reset_kunit (struct kunit *test);#endif
Signature · 1 line
2.25.1
Quoted 24 lines · Janga Rahul Kumar
From: Ruthuvikas Ravikumar <[email protected]>
This kunit verifies the mocs registers content
with the KMD programmed values before and after
GT reset.Cc Mathew D Roper <[email protected]>Signed-off-by Ruthuvikas Ravikumar <[email protected]>Signed-off-by Janga Rahul Kumar <[email protected]>--- drivers/gpu/drm/xe/tests/xe_mocs.c | 38 +++++++++++++++++++++++++ drivers/gpu/drm/xe/tests/xe_mocs_test.c | 1 + drivers/gpu/drm/xe/tests/xe_mocs_test.h | 1 + 3 files changed, 40 insertions(+)drivers/gpu/drm/xe/tests/xe_mocs.c +1
-0@@ -128,3 +128,41 @@ void xe_live_mocs_kernel_kunit(struct kunit *test)xe_call_for_each_device (mocs_kernel_test_run_device); }EXPORT_SYMBOL_IF_KUNIT (xe_live_mocs_kernel_kunit); +
drivers/gpu/drm/xe/tests/xe_mocs.c void xe_live_mocs_kernel_kunit(struct kunit *test) · line 141
Quoted 10 lines
drivers/gpu/drm/xe/tests/xe_mocs.c +10
-0+static int mocs_reset_test_run_device (struct xe_device *xe) +{ +/* Check the mocs setup is retained over GT reset */ + +struct live_mocs mocs; +struct xe_gt *gt; + +unsigned int flags; +int id; +
Minor nitpick: there probably shouldn't be extra blank lines between the various local variables definitions here.
Aside from that,
Reviewed-by Matt Roper <[email protected]>
Quoted 53 lines
drivers/gpu/drm/xe/tests/xe_mocs.c +27
-0+struct kunit *test =xe_cur_kunit (); + +for_each_gt (gt, xe, id) { + flags =live_mocs_init (&mocs, gt); +kunit_info (test,"mocs_reset_test before reset\n" ); +if (flags &HAS_GLOBAL_MOCS ) +read_mocs_table (gt, &mocs.table); +if (flags &HAS_LNCF_MOCS ) +read_l3cc_table (gt, &mocs.table); + +xe_gt_reset_async (gt); +flush_work (>->reset.worker); + +kunit_info (test,"mocs_reset_test after reset\n" ); +if (flags &HAS_GLOBAL_MOCS ) +read_mocs_table (gt, &mocs.table); +if (flags &HAS_LNCF_MOCS ) +read_l3cc_table (gt, &mocs.table); + } +return 0 ; +} + +void xe_live_mocs_reset_kunit (struct kunit *test) +{ +xe_call_for_each_device (mocs_reset_test_run_device); +} +EXPORT_SYMBOL_IF_KUNIT (xe_live_mocs_reset_kunit);drivers/gpu/drm/xe/tests/xe_mocs_test.c +1
-0@@ -9,6 +9,7 @@static struct kunit_case xe_mocs_tests[] = {KUNIT_CASE (xe_live_mocs_kernel_kunit), +KUNIT_CASE (xe_live_mocs_reset_kunit), {} };drivers/gpu/drm/xe/tests/xe_mocs_test.h +1
-0@@ -9,5 +9,6 @@struct kunit ;void xe_live_mocs_kernel_kunit (struct kunit *test); +void xe_live_mocs_reset_kunit (struct kunit *test);#endif Signature · 1 line
2.25.1
Signature · 4 lines
Matt Roper Graphics Software Engineer Linux GPU Platform Enablement Intel Corporation