Skip to contentSkip to conversation

sunxi: add defconfig for nanopi_duo2

PATCH In review Chuanhong Guo 2 participants 4 messages Dec 28, 2023 – Jan 30, 2024 Arm/Allwinner sunXi SoC support

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sunxi: add defconfig for nanopi_duo2

FriendlyElec NanoPi Duo2 is a tiny SBC with Allwinner H3 and Ampak AP6212 WiFi module. The device-tree for it is already available in u-boot source tree. Add a default config for it.

---
 configs/nanopi_duo2_defconfig | 11 +++++++++++
 1 file changed, 11 insertions(+)
 create mode 100644 configs/nanopi_duo2_defconfig
configs/nanopi_duo2_defconfig new file +11 -0
new file mode 100644
index 0000000000..5a2069789f
@@ -0,0 +1,11 @@
+CONFIG_ARM=y
+CONFIG_ARCH_SUNXI=y
+CONFIG_DEFAULT_DEVICE_TREE="sun8i-h3-nanopi-duo2"
+CONFIG_SPL=y
+CONFIG_MACH_SUN8I_H3=y
+CONFIG_DRAM_CLK=408
+# CONFIG_VIDEO_DE2 is not set
+# CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
+CONFIG_CONSOLE_MUX=y
+CONFIG_USB_EHCI_HCD=y
+CONFIG_USB_OHCI_HCD=y
Signature · 1 line
2.43.0
#1 lore raw

On Thu, 28 Dec 2023 13:29:15 +0800
Chuanhong Guo <[email protected]> wrote:

Hi,

thanks for taking care and sending a patch!

Quoted 17 lines

FriendlyElec NanoPi Duo2 is a tiny SBC with Allwinner H3 and Ampak AP6212 WiFi module. The device-tree for it is already available in u-boot source tree. Add a default config for it.

---
 configs/nanopi_duo2_defconfig | 11 +++++++++++
 1 file changed, 11 insertions(+)
 create mode 100644 configs/nanopi_duo2_defconfig
configs/nanopi_duo2_defconfig new file +1 -0
new file mode 100644
index 0000000000..5a2069789f
@@ -0,0 +1,11 @@
+CONFIG_ARM=y

configs/nanopi_duo2_defconfig line 11

Quoted 10 lines
configs/nanopi_duo2_defconfig new file +10 -0
+CONFIG_ARCH_SUNXI=y
+CONFIG_DEFAULT_DEVICE_TREE="sun8i-h3-nanopi-duo2"
+CONFIG_SPL=y
+CONFIG_MACH_SUN8I_H3=y
+CONFIG_DRAM_CLK=408
+# CONFIG_VIDEO_DE2 is not set
+# CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
+CONFIG_CONSOLE_MUX=y
+CONFIG_USB_EHCI_HCD=y
+CONFIG_USB_OHCI_HCD=y

Judging by the DT, this board has USB-OTG wired up correctly, so we should enable it, by adding:
CONFIG_USB_MUSB_GADGET=y
This would allow access to USB Ethernet, fastboot or UMS devices, which prove to be quite useful for U-Boot.

Cheers,
Andre

#2 lore raw

On Sun, 21 Jan 2024 01:15:28 +0000
Andre Przywara <[email protected]> wrote:

Hi,

Quoted 32 lines

On Thu, 28 Dec 2023 13:29:15 +0800
Chuanhong Guo <[email protected]> wrote:

Hi,

thanks for taking care and sending a patch!

Quoted 25 lines

FriendlyElec NanoPi Duo2 is a tiny SBC with Allwinner H3 and Ampak AP6212 WiFi module. The device-tree for it is already available in u-boot source tree. Add a default config for it.

---
 configs/nanopi_duo2_defconfig | 11 +++++++++++
 1 file changed, 11 insertions(+)
 create mode 100644 configs/nanopi_duo2_defconfig
configs/nanopi_duo2_defconfig new file +9 -0
new file mode 100644
index 0000000000..5a2069789f
@@ -0,0 +1,11 @@
+CONFIG_ARM=y
+CONFIG_ARCH_SUNXI=y
+CONFIG_DEFAULT_DEVICE_TREE="sun8i-h3-nanopi-duo2"
+CONFIG_SPL=y
+CONFIG_MACH_SUN8I_H3=y
+CONFIG_DRAM_CLK=408
+# CONFIG_VIDEO_DE2 is not set
+# CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
+CONFIG_CONSOLE_MUX=y
Quoted 8 lines

configs/nanopi_duo2_defconfig line 11

Quoted 2 lines
configs/nanopi_duo2_defconfig new file +2 -0
+CONFIG_USB_EHCI_HCD=y
+CONFIG_USB_OHCI_HCD=y  

Judging by the DT, this board has USB-OTG wired up correctly, so we should enable it, by adding:
CONFIG_USB_MUSB_GADGET=y
This would allow access to USB Ethernet, fastboot or UMS devices, which prove to be quite useful for U-Boot.

So I merged this patch, after adding the USB_MUSB_GADGET option. I just see that the CI complained about a missing maintainer entry, I will fix this up in a follow-up patch.

Thanks,
Andre.

Quoted 3 lines

Cheers,
Andre

#3 lore raw

Hi!

Quoted 10 lines · Andre Przywara
Quoted 6 lines

Judging by the DT, this board has USB-OTG wired up correctly, so we should enable it, by adding:
CONFIG_USB_MUSB_GADGET=y
This would allow access to USB Ethernet, fastboot or UMS devices, which prove to be quite useful for U-Boot.

So I merged this patch, after adding the USB_MUSB_GADGET option. I just see that the CI complained about a missing maintainer entry, I will fix this up in a follow-up patch.

Oops. I forgot to follow up your previous email.

This board does have a working USB OTG port.
Thanks for fixing the patch for me!

Signature · 2 lines
Regards,
Chuanhong Guo