arm64: dts: allwinner: h618: Add Sipeed Longan SoM 3H and Pi 3H board
Subsystems (2)
cover arm64: dts: allwinner: h618: Add Sipeed Longan SoM 3H and Pi 3H board
Add Sipeed Longan SoM 3H and Longan Pi 3H board support.
The Sipeed Longan SoM 3H is a system on module based on the Allwinner H618 SoC. The SoM features:
- Four ARM Cortex-A53 cores, Mali-G31 MP2 GPU
- 2/4 GiB LPDDR4 DRAM SoMs
- AXP313a PMIC
- eMMC
The Sipeed Longan PI 3H is a development board based on the above SoM. The board features:
- Longan SoM 3H
- Raspberry-Pi-1 compatible GPIO header
- 2 USB 2.0 host port
- 1 USB 2.0 type C port (power supply + OTG)
- MicroSD slot
- 1Gbps Ethernet port (via RTL8211 PHY)
- HDMI port
- WiFi/BT chip
NOTE: I know it's too late for v6.8-rc1, but I want to send out this series so that the board users can easily get mainline support with two additional patches. I will send out v2 once v6.8-rc1 is out.
Jisheng Zhang (2):
dt-bindings: arm: sunxi: Add Sipeed Longan Module 3H and Longan Pi 3H
arm64: dts: allwinner: h618: Add Sipeed Longan SoM 3H and Pi 3H board
support
.../devicetree/bindings/arm/sunxi.yaml | 7 + arch/arm64/boot/dts/allwinner/Makefile | 1 + .../sun50i-h618-longan-module-3h.dtsi | 82 +++++++++++ .../dts/allwinner/sun50i-h618-longanpi-3h.dts | 133 ++++++++++++++++++ 4 files changed, 223 insertions(+) create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h618-longan-module-3h.dtsi create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h618-longanpi-3h.dts
Signature · 1 line
2.40.0
PATCH 1/2 dt-bindings: arm: sunxi: Add Sipeed Longan Module 3H and Longan Pi 3H
Add name & compatible for the Sipeed Longan Module 3H and Longan PI 3H board.
--- Documentation/devicetree/bindings/arm/sunxi.yaml | 7 +++++++ 1 file changed, 7 insertions(+)
Documentation/devicetree/bindings/arm/sunxi.yaml +7 -0
@@ -835,6 +835,13 @@ properties: - const: sinlinx,sina33 - const: allwinner,sun8i-a33 + - description: Sipeed Longan Pi 3H board for the Sipeed Longan Module 3H + items: + - enum: + - sipeed,longan-pi-3h + - const: sipeed,longan-module-3h + - const: allwinner,sun50i-h618 + - description: SourceParts PopStick v1.1 items: - const: sourceparts,popstick-v1.1
Signature · 1 line
2.40.0
Re: [PATCH 1/2] dt-bindings: arm: sunxi: Add Sipeed Longan Module 3H and Longan Pi 3H
On Thu, 28 Dec 2023 22:56:46 +0800
Jisheng Zhang <[email protected]> wrote:
Hi Jisheng,
thanks for sending this, seems to be on time with the release of the hardware. Don't see that very often!
Quoted 13 lines
Add name & compatible for the Sipeed Longan Module 3H and Longan PI 3H board.
Signed-off-by Jisheng Zhang <[email protected]>--- Documentation/devicetree/bindings/arm/sunxi.yaml | 7 +++++++ 1 file changed, 7 insertions(+)Documentation/devicetree/bindings/arm/sunxi.yaml +0
-0
Documentation/devicetree/bindings/arm/sunxi.yaml properties: · line 841
Quoted 7 lines
Documentation/devicetree/bindings/arm/sunxi.yaml +4
-0@@ -835,6 +835,13 @@ properties: - const: sinlinx,sina33 - const: allwinner,sun8i-a33 + - description: Sipeed Longan Pi 3H board for the Sipeed Longan Module 3H + items: + - enum: + - sipeed,longan-pi-3h
The picture of the SoM suggests that it cannot be used on its own, so for anything usable we will always need both the SoM and some board. Definitely we do for this board. So please follow the example for the SoPine (or other SoM based boards), and just name all three names as "const" items.
Cheers,
Andre
Quoted 6 lines
Documentation/devicetree/bindings/arm/sunxi.yaml +3
-0+ - const: sipeed,longan-module-3h + - const: allwinner,sun50i-h618 + - description: SourceParts PopStick v1.1 items: - const: sourceparts,popstick-v1.1
PATCH 2/2 arm64: dts: allwinner: h616: Add Sipeed Longan SoM 3H and Pi 3H board support
In reply to Jisheng ZhangThe Sipeed Longan SoM 3H is a system on module based on the Allwinner H618 SoC. The SoM features:
- Four ARM Cortex-A53 cores, Mali-G31 MP2 GPU
- 2/4 GiB LPDDR4 DRAM SoMs
- AXP313a PMIC
- eMMC
The Sipeed Longan PI 3H is a development board based on the above SoM. The board features:
- Longan SoM 3H
- Raspberry-Pi-1 compatible GPIO header
- 2 USB 2.0 host port
- 1 USB 2.0 type C port (power supply + OTG)
- MicroSD slot
- 1Gbps Ethernet port (via RTL8211 PHY)
- HDMI port
- WiFi/BT chip
Add the devicetree file describing the currently supported features, namely PMIC, LEDs, UART, SD card, eMMC, USB and Ethernet.
--- arch/arm64/boot/dts/allwinner/Makefile | 1 + .../sun50i-h618-longan-module-3h.dtsi | 82 +++++++++++ .../dts/allwinner/sun50i-h618-longanpi-3h.dts | 133 ++++++++++++++++++ 3 files changed, 216 insertions(+) create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h618-longan-module-3h.dtsi create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h618-longanpi-3h.dts
arch/arm64/boot/dts/allwinner/Makefile +1 -0
@@ -42,4 +42,5 @@ dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-bigtreetech-cb1-manta.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-bigtreetech-pi.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-orangepi-zero2.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-x96-mate.dtb +dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h618-longanpi-3h.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h618-orangepi-zero3.dtb
arch/arm64/boot/dts/allwinner/sun50i-h618-longan-module-3h.dtsi new file +82 -0
82 lines not on this page · raw message
arch/arm64/boot/dts/allwinner/sun50i-h618-longanpi-3h.dts new file +133 -0
133 lines not on this page · raw message
Signature · 1 line
2.40.0
Re: [PATCH 2/2] arm64: dts: allwinner: h616: Add Sipeed Longan SoM 3H and Pi 3H board support
On Thu, 28 Dec 2023 22:56:47 +0800
Jisheng Zhang <[email protected]> wrote:
Hi,
Quoted 47 lines
The Sipeed Longan SoM 3H is a system on module based on the Allwinner H618 SoC. The SoM features:
- Four ARM Cortex-A53 cores, Mali-G31 MP2 GPU
- 2/4 GiB LPDDR4 DRAM SoMs
- AXP313a PMIC
- eMMCThe Sipeed Longan PI 3H is a development board based on the above SoM. The board features:
- Longan SoM 3H
- Raspberry-Pi-1 compatible GPIO header
- 2 USB 2.0 host port
- 1 USB 2.0 type C port (power supply + OTG)
- MicroSD slot
- 1Gbps Ethernet port (via RTL8211 PHY)
- HDMI port
- WiFi/BT chipAdd the devicetree file describing the currently supported features, namely PMIC, LEDs, UART, SD card, eMMC, USB and Ethernet.
Signed-off-by Jisheng Zhang <[email protected]>--- arch/arm64/boot/dts/allwinner/Makefile | 1 + .../sun50i-h618-longan-module-3h.dtsi | 82 +++++++++++ .../dts/allwinner/sun50i-h618-longanpi-3h.dts | 133 ++++++++++++++++++ 3 files changed, 216 insertions(+) create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h618-longan-module-3h.dtsi create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h618-longanpi-3h.dtsarch/arm64/boot/dts/allwinner/Makefile +1
-0@@ -42,4 +42,5 @@ dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-bigtreetech-cb1-manta.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-bigtreetech-pi.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-orangepi-zero2.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-x96-mate.dtb +dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h618-longanpi-3h.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h618-orangepi-zero3.dtbarch/arm64/boot/dts/allwinner/sun50i-h618-longan-module-3h.dtsi new file +0
-0
arch/arm64/boot/dts/allwinner/sun50i-h618-longan-module-3h.dtsi line 6
Quoted 6 lines
arch/arm64/boot/dts/allwinner/sun50i-h618-longan-module-3h.dtsi new file +6
-0@@ -0,0 +1,82 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Copyright (C) Jisheng Zhang <[email protected]> + */ + +/dts-v1/;
I don't see how the SoM could be used on its own, without a hosting board. So we don't need the dts version tag in the .dtsi, that would just be double when we are going to compile any actual .dtb.
arch/arm64/boot/dts/allwinner/sun50i-h618-longan-module-3h.dtsi line 12
Quoted 6 lines
arch/arm64/boot/dts/allwinner/sun50i-h618-longan-module-3h.dtsi new file +6
-0+ +#include "sun50i-h616.dtsi" + +/ { + model = "Sipeed Longan Module 3H"; + compatible = "sipeed,longan-module-3h", "allwinner,sun50i-h618";
Same here, any model or compatible string would only be overwritten by the board versions, so you don't need those two in the SoM .dtsi. Compare the SoPine and BTT CB1 .dtsi files.
arch/arm64/boot/dts/allwinner/sun50i-h618-longan-module-3h.dtsi line 17
Quoted 5 lines
arch/arm64/boot/dts/allwinner/sun50i-h618-longan-module-3h.dtsi new file +5
-0+}; + +&mmc2 { + pinctrl-names = "default"; + pinctrl-0 = <&mmc2_pins>;
Can you please add the DS pin here? At the moment the sunxi Linux driver doesn't support HS-400, but that can a) change and b) doesn't affect the DT anyway, since that describes the hardware. The connection is definitely there, according to the schematics.
Quoted 5 lines
arch/arm64/boot/dts/allwinner/sun50i-h618-longan-module-3h.dtsi new file +5
-0+ vmmc-supply = <®_dldo1>; + vqmmc-supply = <®_aldo1>; + bus-width = <8>; + non-removable; + cap-mmc-hw-reset;
arch/arm64/boot/dts/allwinner/sun50i-h618-longan-module-3h.dtsi line 32
Quoted 10 lines
arch/arm64/boot/dts/allwinner/sun50i-h618-longan-module-3h.dtsi new file +10
-0+ mmc-ddr-1_8v; + mmc-hs200-1_8v; + status = "okay"; +}; + +&r_i2c { + status = "okay"; + + axp313: pmic@36 { + compatible = "x-powers,axp313a";
According to the bindings you need:
interrupt-controller; #interrupt-cells = <1>;
Even without the IRQ line connected. dt-validate complains about that.
Actually, do you know of any reason why it is not connected? I see it on the SoM pins, is the idea that any *board* could dedicate a GPIO pin for it, if needed?
arch/arm64/boot/dts/allwinner/sun50i-h618-longan-module-3h.dtsi line 41
Quoted 9 lines
arch/arm64/boot/dts/allwinner/sun50i-h618-longan-module-3h.dtsi new file +9
-0+ reg = <0x36>; + + regulators { + /* Supplies VCC-PLL, so needs to be always on. */ + reg_aldo1: aldo1 { + regulator-always-on; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-name = "vcc1v8";
Can you please use "vcc-1v8-pll" instead? Then you don't need the comment.
arch/arm64/boot/dts/allwinner/sun50i-h618-longan-module-3h.dtsi line 49
Quoted 8 lines
arch/arm64/boot/dts/allwinner/sun50i-h618-longan-module-3h.dtsi new file +8
-0+ }; + + /* Supplies VCC-IO, so needs to be always on. */ + reg_dldo1: dldo1 { + regulator-always-on; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + regulator-name = "vcc3v3";
Same here, "vcc-3v3-io" is the name we used lately, to avoid the comment.
Quoted 81 lines
arch/arm64/boot/dts/allwinner/sun50i-h618-longan-module-3h.dtsi new file +33
-0+ }; + + reg_dcdc1: dcdc1 { + regulator-always-on; + regulator-min-microvolt = <810000>; + regulator-max-microvolt = <990000>; + regulator-name = "vdd-gpu-sys"; + }; + + reg_dcdc2: dcdc2 { + regulator-always-on; + regulator-min-microvolt = <810000>; + regulator-max-microvolt = <1100000>; + regulator-name = "vdd-cpu"; + }; + + reg_dcdc3: dcdc3 { + regulator-always-on; + regulator-min-microvolt = <1100000>; + regulator-max-microvolt = <1100000>; + regulator-name = "vdd-dram"; + }; + }; + }; +}; + +&pio { + vcc-pc-supply = <®_dldo1>; + vcc-pf-supply = <®_dldo1>; + vcc-pg-supply = <®_aldo1>; + vcc-ph-supply = <®_dldo1>; + vcc-pi-supply = <®_dldo1>; +};arch/arm64/boot/dts/allwinner/sun50i-h618-longanpi-3h.dts new file +42
-0@@ -0,0 +1,133 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Copyright (C) Jisheng Zhang <[email protected]> + */ + +/dts-v1/; + +#include "sun50i-h618-longan-module-3h.dtsi" + +#include <dt-bindings/gpio/gpio.h> +#include <dt-bindings/interrupt-controller/arm-gic.h> +#include <dt-bindings/leds/common.h> + +/ { + model = "Sipeed Longan Pi 3H"; + compatible = "sipeed,longan-pi-3h", "sipeed,longan-module-3h", "allwinner,sun50i-h618"; + + aliases { + ethernet0 = &emac0; + serial0 = &uart0; + }; + + chosen { + stdout-path = "serial0:115200n8"; + }; + + leds { + compatible = "gpio-leds"; + + led-0 { + color = <LED_COLOR_ID_ORANGE>; + function = LED_FUNCTION_INDICATOR; + function-enumerator = <0>; + gpios = <&pio 6 2 GPIO_ACTIVE_LOW>; /* PG2 */ + }; + + led-1 { + color = <LED_COLOR_ID_ORANGE>; + function = LED_FUNCTION_INDICATOR; + function-enumerator = <1>; + gpios = <&pio 6 4 GPIO_ACTIVE_LOW>; /* PG4 */ + };
arch/arm64/boot/dts/allwinner/sun50i-h618-longanpi-3h.dts line 52
Quoted 10 lines
arch/arm64/boot/dts/allwinner/sun50i-h618-longanpi-3h.dts new file +10
-0+ }; + + reg_vcc5v: vcc5v { + /* board wide 5V supply directly from the USB-C socket */ + compatible = "regulator-fixed"; + regulator-name = "vcc-5v"; + regulator-min-microvolt = <5000000>; + regulator-max-microvolt = <5000000>; + regulator-always-on; + };
According to the schematic, there is a discrete 5V->3.3V regulator, can you please describe this here as well?
Quoted 14 lines
arch/arm64/boot/dts/allwinner/sun50i-h618-longanpi-3h.dts new file +14
-0+}; + +&axp313 { + vin1-supply = <®_vcc5v>; + vin2-supply = <®_vcc5v>; + vin3-supply = <®_vcc5v>; +}; + +&ehci1 { + status = "okay"; +}; + +&ohci1 { + status = "okay";
arch/arm64/boot/dts/allwinner/sun50i-h618-longanpi-3h.dts line 76
Quoted 10 lines
arch/arm64/boot/dts/allwinner/sun50i-h618-longanpi-3h.dts new file +10
-0+}; + +&ehci2 { + status = "okay"; +}; + +&ohci2 { + status = "okay"; +}; +
Maybe worth adding a comment here that there is a USB WiFi chip connected to those pins.
Quoted 6 lines
arch/arm64/boot/dts/allwinner/sun50i-h618-longanpi-3h.dts new file +6
-0+&ehci3 { + status = "okay"; +}; + +&ohci3 { + status = "okay";
arch/arm64/boot/dts/allwinner/sun50i-h618-longanpi-3h.dts line 92
Quoted 10 lines
arch/arm64/boot/dts/allwinner/sun50i-h618-longanpi-3h.dts new file +10
-0+}; + +&emac0 { + pinctrl-names = "default"; + pinctrl-0 = <&ext_rgmii_pins>; + phy-mode = "rgmii"; + phy-handle = <&ext_rgmii_phy>; + allwinner,rx-delay-ps = <3100>; + allwinner,tx-delay-ps = <700>; + phy-supply = <®_dldo1>;
If I get the schematic correctly, the PHY is powered from the discrete 3.3V regulator? In fact, the 3V3-DLDO-OUT/1V8-ALDO-OUT pins on the SoM do not seem to be connected, so anything using 3.3V or 1.8V on the board needs to be fed from this regulator, and everything on the SoM is supplied by the AXP?
Quoted 4 lines
arch/arm64/boot/dts/allwinner/sun50i-h618-longanpi-3h.dts new file +4
-0+ status = "okay"; +}; + +&mdio0 {
arch/arm64/boot/dts/allwinner/sun50i-h618-longanpi-3h.dts line 106
Quoted 10 lines
arch/arm64/boot/dts/allwinner/sun50i-h618-longanpi-3h.dts new file +10
-0+ ext_rgmii_phy: ethernet-phy@1 { + compatible = "ethernet-phy-ieee802.3-c22"; + reg = <1>; + }; +}; + +&mmc0 { + bus-width = <4>; + cd-gpios = <&pio 5 6 GPIO_ACTIVE_HIGH>; /* PF6 */ + vmmc-supply = <®_dldo1>;
According to the schematic, the SD card is supplied by the discrete 3.3V regulator on the board.
Quoted 15 lines
arch/arm64/boot/dts/allwinner/sun50i-h618-longanpi-3h.dts new file +15
-0+ status = "okay"; +}; + +&uart0 { + status = "okay"; +}; + +&usbotg { + /* + * PHY0 pins are connected to a USB-C socket, but a role switch + * is not implemented: both CC pins are pulled to GND. + * The VBUS pins power the device, so a fixed peripheral mode + * is the best choice. + * The board can be powered via GPIOs, in this case port0 *can* + * act as a host (with a cable/adapter ignoring CC), as VBUS is
arch/arm64/boot/dts/allwinner/sun50i-h618-longanpi-3h.dts line 131
Quoted 10 lines
arch/arm64/boot/dts/allwinner/sun50i-h618-longanpi-3h.dts new file +10
-0+ * then provided by the GPIOs. Any user of this setup would + * need to adjust the DT accordingly: dr_mode set to "host", + * enabling OHCI0 and EHCI0. + */ + dr_mode = "peripheral"; + status = "okay"; +}; + +&usbphy { + usb1_vbus-supply = <®_vcc5v>;
The same seems to be true for USB2 as well, and the WiFi chip on USB3 is powered by the discrete 3.3V regulator. But I think we don't need these properties at all if it's directly connected to the input and so always powered. Or maybe we should do this anyway, and be it to make it clear where the bus power is coming from?
Cheers,
Andre
P.S. I saw some U-Boot patches on some github. Most of them are merged, but feel free to post the DT (same ones as here) and the defconfig to the U-Boot list as well. You can use "make savedefconfig" when you have configured the board, this will create a file "defconfig" in the build directory that contains the minimal items, this can be directly used as a defconfig.
arch/arm64/boot/dts/allwinner/sun50i-h618-longanpi-3h.dts line 133
Quoted 2 lines
arch/arm64/boot/dts/allwinner/sun50i-h618-longanpi-3h.dts new file +2
-0+ status = "okay"; +};
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Re: [PATCH 2/2] arm64: dts: allwinner: h616: Add Sipeed Longan SoM 3H and Pi 3H board support
Quoted 74 lines · Andre Przywara
On Thu, 28 Dec 2023 22:56:47 +0800
Jisheng Zhang <[email protected]> wrote:Hi,
Quoted 47 lines
The Sipeed Longan SoM 3H is a system on module based on the Allwinner H618 SoC. The SoM features:
- Four ARM Cortex-A53 cores, Mali-G31 MP2 GPU
- 2/4 GiB LPDDR4 DRAM SoMs
- AXP313a PMIC
- eMMCThe Sipeed Longan PI 3H is a development board based on the above SoM. The board features:
- Longan SoM 3H
- Raspberry-Pi-1 compatible GPIO header
- 2 USB 2.0 host port
- 1 USB 2.0 type C port (power supply + OTG)
- MicroSD slot
- 1Gbps Ethernet port (via RTL8211 PHY)
- HDMI port
- WiFi/BT chipAdd the devicetree file describing the currently supported features, namely PMIC, LEDs, UART, SD card, eMMC, USB and Ethernet.
Signed-off-by Jisheng Zhang <[email protected]>--- arch/arm64/boot/dts/allwinner/Makefile | 1 + .../sun50i-h618-longan-module-3h.dtsi | 82 +++++++++++ .../dts/allwinner/sun50i-h618-longanpi-3h.dts | 133 ++++++++++++++++++ 3 files changed, 216 insertions(+) create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h618-longan-module-3h.dtsi create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h618-longanpi-3h.dtsarch/arm64/boot/dts/allwinner/Makefile +1
-0@@ -42,4 +42,5 @@ dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-bigtreetech-cb1-manta.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-bigtreetech-pi.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-orangepi-zero2.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-x96-mate.dtb +dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h618-longanpi-3h.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h618-orangepi-zero3.dtbarch/arm64/boot/dts/allwinner/sun50i-h618-longan-module-3h.dtsi new file +0
-0arch/arm64/boot/dts/allwinner/sun50i-h618-longan-module-3h.dtsi line 6
Quoted 6 lines
arch/arm64/boot/dts/allwinner/sun50i-h618-longan-module-3h.dtsi new file +6
-0@@ -0,0 +1,82 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Copyright (C) Jisheng Zhang <[email protected]> + */ + +/dts-v1/;I don't see how the SoM could be used on its own, without a hosting board. So we don't need the dts version tag in the .dtsi, that would just be double when we are going to compile any actual .dtb.
arch/arm64/boot/dts/allwinner/sun50i-h618-longan-module-3h.dtsi line 12
Quoted 6 lines
arch/arm64/boot/dts/allwinner/sun50i-h618-longan-module-3h.dtsi new file +6
-0+ +#include "sun50i-h616.dtsi" + +/ { + model = "Sipeed Longan Module 3H"; + compatible = "sipeed,longan-module-3h", "allwinner,sun50i-h618";Same here, any model or compatible string would only be overwritten by the board versions, so you don't need those two in the SoM .dtsi. Compare the SoPine and BTT CB1 .dtsi files.
Quoted 10 lines
arch/arm64/boot/dts/allwinner/sun50i-h618-longan-module-3h.dtsi line 17
Quoted 5 lines
arch/arm64/boot/dts/allwinner/sun50i-h618-longan-module-3h.dtsi new file +5
-0+}; + +&mmc2 { + pinctrl-names = "default"; + pinctrl-0 = <&mmc2_pins>;Can you please add the DS pin here? At the moment the sunxi Linux driver doesn't support HS-400, but that can a) change and b) doesn't affect the DT anyway, since that describes the hardware. The connection is definitely there, according to the schematics.
Hi Andre,
Thank you so much for the review and comments, could you please review? Except DS pin, other comments are adopted and updated in v2. DS pin is already there, IIUC, PC0 is emmc DS pin
Thanks
Quoted 262 lines
Quoted 6 lines
arch/arm64/boot/dts/allwinner/sun50i-h618-longan-module-3h.dtsi new file +5
-0+ vmmc-supply = <®_dldo1>; + vqmmc-supply = <®_aldo1>; + bus-width = <8>; + non-removable; + cap-mmc-hw-reset;arch/arm64/boot/dts/allwinner/sun50i-h618-longan-module-3h.dtsi line 32
Quoted 10 lines
arch/arm64/boot/dts/allwinner/sun50i-h618-longan-module-3h.dtsi new file +10
-0+ mmc-ddr-1_8v; + mmc-hs200-1_8v; + status = "okay"; +}; + +&r_i2c { + status = "okay"; + + axp313: pmic@36 { + compatible = "x-powers,axp313a";According to the bindings you need:
interrupt-controller; #interrupt-cells = <1>;Even without the IRQ line connected. dt-validate complains about that.
Actually, do you know of any reason why it is not connected? I see it on the SoM pins, is the idea that any *board* could dedicate a GPIO pin for it, if needed?
arch/arm64/boot/dts/allwinner/sun50i-h618-longan-module-3h.dtsi line 41
Quoted 9 lines
arch/arm64/boot/dts/allwinner/sun50i-h618-longan-module-3h.dtsi new file +9
-0+ reg = <0x36>; + + regulators { + /* Supplies VCC-PLL, so needs to be always on. */ + reg_aldo1: aldo1 { + regulator-always-on; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-name = "vcc1v8";Can you please use "vcc-1v8-pll" instead? Then you don't need the comment.
arch/arm64/boot/dts/allwinner/sun50i-h618-longan-module-3h.dtsi line 49
Quoted 8 lines
arch/arm64/boot/dts/allwinner/sun50i-h618-longan-module-3h.dtsi new file +8
-0+ }; + + /* Supplies VCC-IO, so needs to be always on. */ + reg_dldo1: dldo1 { + regulator-always-on; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + regulator-name = "vcc3v3";Same here, "vcc-3v3-io" is the name we used lately, to avoid the comment.
Quoted 81 lines
arch/arm64/boot/dts/allwinner/sun50i-h618-longan-module-3h.dtsi new file +33
-0+ }; + + reg_dcdc1: dcdc1 { + regulator-always-on; + regulator-min-microvolt = <810000>; + regulator-max-microvolt = <990000>; + regulator-name = "vdd-gpu-sys"; + }; + + reg_dcdc2: dcdc2 { + regulator-always-on; + regulator-min-microvolt = <810000>; + regulator-max-microvolt = <1100000>; + regulator-name = "vdd-cpu"; + }; + + reg_dcdc3: dcdc3 { + regulator-always-on; + regulator-min-microvolt = <1100000>; + regulator-max-microvolt = <1100000>; + regulator-name = "vdd-dram"; + }; + }; + }; +}; + +&pio { + vcc-pc-supply = <®_dldo1>; + vcc-pf-supply = <®_dldo1>; + vcc-pg-supply = <®_aldo1>; + vcc-ph-supply = <®_dldo1>; + vcc-pi-supply = <®_dldo1>; +};arch/arm64/boot/dts/allwinner/sun50i-h618-longanpi-3h.dts new file +42
-0@@ -0,0 +1,133 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Copyright (C) Jisheng Zhang <[email protected]> + */ + +/dts-v1/; + +#include "sun50i-h618-longan-module-3h.dtsi" + +#include <dt-bindings/gpio/gpio.h> +#include <dt-bindings/interrupt-controller/arm-gic.h> +#include <dt-bindings/leds/common.h> + +/ { + model = "Sipeed Longan Pi 3H"; + compatible = "sipeed,longan-pi-3h", "sipeed,longan-module-3h", "allwinner,sun50i-h618"; + + aliases { + ethernet0 = &emac0; + serial0 = &uart0; + }; + + chosen { + stdout-path = "serial0:115200n8"; + }; + + leds { + compatible = "gpio-leds"; + + led-0 { + color = <LED_COLOR_ID_ORANGE>; + function = LED_FUNCTION_INDICATOR; + function-enumerator = <0>; + gpios = <&pio 6 2 GPIO_ACTIVE_LOW>; /* PG2 */ + }; + + led-1 { + color = <LED_COLOR_ID_ORANGE>; + function = LED_FUNCTION_INDICATOR; + function-enumerator = <1>; + gpios = <&pio 6 4 GPIO_ACTIVE_LOW>; /* PG4 */ + };arch/arm64/boot/dts/allwinner/sun50i-h618-longanpi-3h.dts line 52
Quoted 10 lines
arch/arm64/boot/dts/allwinner/sun50i-h618-longanpi-3h.dts new file +10
-0+ }; + + reg_vcc5v: vcc5v { + /* board wide 5V supply directly from the USB-C socket */ + compatible = "regulator-fixed"; + regulator-name = "vcc-5v"; + regulator-min-microvolt = <5000000>; + regulator-max-microvolt = <5000000>; + regulator-always-on; + };According to the schematic, there is a discrete 5V->3.3V regulator, can you please describe this here as well?
Quoted 14 lines
arch/arm64/boot/dts/allwinner/sun50i-h618-longanpi-3h.dts new file +14
-0+}; + +&axp313 { + vin1-supply = <®_vcc5v>; + vin2-supply = <®_vcc5v>; + vin3-supply = <®_vcc5v>; +}; + +&ehci1 { + status = "okay"; +}; + +&ohci1 { + status = "okay";arch/arm64/boot/dts/allwinner/sun50i-h618-longanpi-3h.dts line 76
Quoted 10 lines
arch/arm64/boot/dts/allwinner/sun50i-h618-longanpi-3h.dts new file +10
-0+}; + +&ehci2 { + status = "okay"; +}; + +&ohci2 { + status = "okay"; +}; +Maybe worth adding a comment here that there is a USB WiFi chip connected to those pins.
Quoted 6 lines
arch/arm64/boot/dts/allwinner/sun50i-h618-longanpi-3h.dts new file +6
-0+&ehci3 { + status = "okay"; +}; + +&ohci3 { + status = "okay";arch/arm64/boot/dts/allwinner/sun50i-h618-longanpi-3h.dts line 92
Quoted 10 lines
arch/arm64/boot/dts/allwinner/sun50i-h618-longanpi-3h.dts new file +10
-0+}; + +&emac0 { + pinctrl-names = "default"; + pinctrl-0 = <&ext_rgmii_pins>; + phy-mode = "rgmii"; + phy-handle = <&ext_rgmii_phy>; + allwinner,rx-delay-ps = <3100>; + allwinner,tx-delay-ps = <700>; + phy-supply = <®_dldo1>;If I get the schematic correctly, the PHY is powered from the discrete 3.3V regulator? In fact, the 3V3-DLDO-OUT/1V8-ALDO-OUT pins on the SoM do not seem to be connected, so anything using 3.3V or 1.8V on the board needs to be fed from this regulator, and everything on the SoM is supplied by the AXP?
Quoted 4 lines
arch/arm64/boot/dts/allwinner/sun50i-h618-longanpi-3h.dts new file +4
-0+ status = "okay"; +}; + +&mdio0 {arch/arm64/boot/dts/allwinner/sun50i-h618-longanpi-3h.dts line 106
Quoted 10 lines
arch/arm64/boot/dts/allwinner/sun50i-h618-longanpi-3h.dts new file +10
-0+ ext_rgmii_phy: ethernet-phy@1 { + compatible = "ethernet-phy-ieee802.3-c22"; + reg = <1>; + }; +}; + +&mmc0 { + bus-width = <4>; + cd-gpios = <&pio 5 6 GPIO_ACTIVE_HIGH>; /* PF6 */ + vmmc-supply = <®_dldo1>;According to the schematic, the SD card is supplied by the discrete 3.3V regulator on the board.
Quoted 15 lines
arch/arm64/boot/dts/allwinner/sun50i-h618-longanpi-3h.dts new file +15
-0+ status = "okay"; +}; + +&uart0 { + status = "okay"; +}; + +&usbotg { + /* + * PHY0 pins are connected to a USB-C socket, but a role switch + * is not implemented: both CC pins are pulled to GND. + * The VBUS pins power the device, so a fixed peripheral mode + * is the best choice. + * The board can be powered via GPIOs, in this case port0 *can* + * act as a host (with a cable/adapter ignoring CC), as VBUS isarch/arm64/boot/dts/allwinner/sun50i-h618-longanpi-3h.dts line 131
Quoted 10 lines
arch/arm64/boot/dts/allwinner/sun50i-h618-longanpi-3h.dts new file +10
-0+ * then provided by the GPIOs. Any user of this setup would + * need to adjust the DT accordingly: dr_mode set to "host", + * enabling OHCI0 and EHCI0. + */ + dr_mode = "peripheral"; + status = "okay"; +}; + +&usbphy { + usb1_vbus-supply = <®_vcc5v>;The same seems to be true for USB2 as well, and the WiFi chip on USB3 is powered by the discrete 3.3V regulator. But I think we don't need these properties at all if it's directly connected to the input and so always powered. Or maybe we should do this anyway, and be it to make it clear where the bus power is coming from?
Cheers,
Andre
P.S. I saw some U-Boot patches on some github. Most of them are merged, but feel free to post the DT (same ones as here) and the defconfig to the U-Boot list as well. You can use "make savedefconfig" when you have configured the board, this will create a file "defconfig" in the build directory that contains the minimal items, this can be directly used as a defconfig.Quoted 2 lines
arch/arm64/boot/dts/allwinner/sun50i-h618-longanpi-3h.dts new file +2
-0+ status = "okay"; +};
Re: [PATCH 2/2] arm64: dts: allwinner: h616: Add Sipeed Longan SoM 3H and Pi 3H board support
Hi Jisheng,
Quoted 86 lines · Jisheng Zhang
Quoted 74 lines · Andre Przywara
On Thu, 28 Dec 2023 22:56:47 +0800
Jisheng Zhang <[email protected]> wrote:Hi,
Quoted 47 lines
The Sipeed Longan SoM 3H is a system on module based on the Allwinner H618 SoC. The SoM features:
- Four ARM Cortex-A53 cores, Mali-G31 MP2 GPU
- 2/4 GiB LPDDR4 DRAM SoMs
- AXP313a PMIC
- eMMCThe Sipeed Longan PI 3H is a development board based on the above SoM. The board features:
- Longan SoM 3H
- Raspberry-Pi-1 compatible GPIO header
- 2 USB 2.0 host port
- 1 USB 2.0 type C port (power supply + OTG)
- MicroSD slot
- 1Gbps Ethernet port (via RTL8211 PHY)
- HDMI port
- WiFi/BT chipAdd the devicetree file describing the currently supported features, namely PMIC, LEDs, UART, SD card, eMMC, USB and Ethernet.
Signed-off-by Jisheng Zhang <[email protected]>--- arch/arm64/boot/dts/allwinner/Makefile | 1 + .../sun50i-h618-longan-module-3h.dtsi | 82 +++++++++++ .../dts/allwinner/sun50i-h618-longanpi-3h.dts | 133 ++++++++++++++++++ 3 files changed, 216 insertions(+)create mode 100644
arch/arm64/boot/dts/allwinner/sun50i-h618-longan-module-3h.dtsicreate mode 100644arch/arm64/boot/dts/allwinner/sun50i-h618-longanpi-3h.dtsarch/arm64/boot/dts/allwinner/Makefile +1
-0@@ -42,4 +42,5 @@ dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-bigtreetech-cb1-manta.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-bigtreetech-pi.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-orangepi-zero2.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-x96-mate.dtb +dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h618-longanpi-3h.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h618-orangepi-zero3.dtbarch/arm64/boot/dts/allwinner/sun50i-h618-longan-module-3h.dtsi new file +0
-0arch/arm64/boot/dts/allwinner/sun50i-h618-longan-module-3h.dtsi line 6
Quoted 6 lines
arch/arm64/boot/dts/allwinner/sun50i-h618-longan-module-3h.dtsi new file +6
-0@@ -0,0 +1,82 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Copyright (C) Jisheng Zhang <[email protected]> + */ + +/dts-v1/;I don't see how the SoM could be used on its own, without a hosting board. So we don't need the dts version tag in the .dtsi, that would just be double when we are going to compile any actual .dtb.
arch/arm64/boot/dts/allwinner/sun50i-h618-longan-module-3h.dtsi line 12
Quoted 6 lines
arch/arm64/boot/dts/allwinner/sun50i-h618-longan-module-3h.dtsi new file +6
-0+ +#include "sun50i-h616.dtsi" + +/ { + model = "Sipeed Longan Module 3H"; + compatible = "sipeed,longan-module-3h", "allwinner,sun50i-h618";Same here, any model or compatible string would only be overwritten by the board versions, so you don't need those two in the SoM .dtsi. Compare the SoPine and BTT CB1 .dtsi files.
Quoted 10 lines
arch/arm64/boot/dts/allwinner/sun50i-h618-longan-module-3h.dtsi line 17
Quoted 5 lines
arch/arm64/boot/dts/allwinner/sun50i-h618-longan-module-3h.dtsi new file +5
-0+}; + +&mmc2 { + pinctrl-names = "default"; + pinctrl-0 = <&mmc2_pins>;Can you please add the DS pin here? At the moment the sunxi Linux driver doesn't support HS-400, but that can a) change and b) doesn't affect the DT anyway, since that describes the hardware. The connection is definitely there, according to the schematics.
Quoted 5 lines
Hi Andre,
Thank you so much for the review and comments, could you please review? Except DS pin, other comments are adopted and updated in v2. DS pin is already there, IIUC, PC0 is emmc DS pin
Ah, you are absolutely right, PC0 is part of the mmc2 pin group already! Arguably we should move it out, since it conflicts with SPI0, but only if HS-400 is needed. But we can surely push this off until a board appears that requires both SPI0 and MMC2.
Sorry for the noise!
Cheers,
Andre
Quoted 264 lines
Thanks
Quoted 262 lines
Quoted 6 lines
arch/arm64/boot/dts/allwinner/sun50i-h618-longan-module-3h.dtsi new file +5
-0+ vmmc-supply = <®_dldo1>; + vqmmc-supply = <®_aldo1>; + bus-width = <8>; + non-removable; + cap-mmc-hw-reset;arch/arm64/boot/dts/allwinner/sun50i-h618-longan-module-3h.dtsi line 32
Quoted 10 lines
arch/arm64/boot/dts/allwinner/sun50i-h618-longan-module-3h.dtsi new file +10
-0+ mmc-ddr-1_8v; + mmc-hs200-1_8v; + status = "okay"; +}; + +&r_i2c { + status = "okay"; + + axp313: pmic@36 { + compatible = "x-powers,axp313a";According to the bindings you need:
interrupt-controller; #interrupt-cells = <1>;Even without the IRQ line connected. dt-validate complains about that.
Actually, do you know of any reason why it is not connected? I see it on the SoM pins, is the idea that any *board* could dedicate a GPIO pin for it, if needed?
arch/arm64/boot/dts/allwinner/sun50i-h618-longan-module-3h.dtsi line 41
Quoted 9 lines
arch/arm64/boot/dts/allwinner/sun50i-h618-longan-module-3h.dtsi new file +9
-0+ reg = <0x36>; + + regulators { + /* Supplies VCC-PLL, so needs to be always on. */ + reg_aldo1: aldo1 { + regulator-always-on; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-name = "vcc1v8";Can you please use "vcc-1v8-pll" instead? Then you don't need the comment.
arch/arm64/boot/dts/allwinner/sun50i-h618-longan-module-3h.dtsi line 49
Quoted 8 lines
arch/arm64/boot/dts/allwinner/sun50i-h618-longan-module-3h.dtsi new file +8
-0+ }; + + /* Supplies VCC-IO, so needs to be always on. */ + reg_dldo1: dldo1 { + regulator-always-on; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + regulator-name = "vcc3v3";Same here, "vcc-3v3-io" is the name we used lately, to avoid the comment.
Quoted 81 lines
arch/arm64/boot/dts/allwinner/sun50i-h618-longan-module-3h.dtsi new file +33
-0+ }; + + reg_dcdc1: dcdc1 { + regulator-always-on; + regulator-min-microvolt = <810000>; + regulator-max-microvolt = <990000>; + regulator-name = "vdd-gpu-sys"; + }; + + reg_dcdc2: dcdc2 { + regulator-always-on; + regulator-min-microvolt = <810000>; + regulator-max-microvolt = <1100000>; + regulator-name = "vdd-cpu"; + }; + + reg_dcdc3: dcdc3 { + regulator-always-on; + regulator-min-microvolt = <1100000>; + regulator-max-microvolt = <1100000>; + regulator-name = "vdd-dram"; + }; + }; + }; +}; + +&pio { + vcc-pc-supply = <®_dldo1>; + vcc-pf-supply = <®_dldo1>; + vcc-pg-supply = <®_aldo1>; + vcc-ph-supply = <®_dldo1>; + vcc-pi-supply = <®_dldo1>; +};arch/arm64/boot/dts/allwinner/sun50i-h618-longanpi-3h.dts new file +42
-0@@ -0,0 +1,133 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Copyright (C) Jisheng Zhang <[email protected]> + */ + +/dts-v1/; + +#include "sun50i-h618-longan-module-3h.dtsi" + +#include <dt-bindings/gpio/gpio.h> +#include <dt-bindings/interrupt-controller/arm-gic.h> +#include <dt-bindings/leds/common.h> + +/ { + model = "Sipeed Longan Pi 3H"; + compatible = "sipeed,longan-pi-3h", "sipeed,longan-module-3h", "allwinner,sun50i-h618"; + + aliases { + ethernet0 = &emac0; + serial0 = &uart0; + }; + + chosen { + stdout-path = "serial0:115200n8"; + }; + + leds { + compatible = "gpio-leds"; + + led-0 { + color = <LED_COLOR_ID_ORANGE>; + function = LED_FUNCTION_INDICATOR; + function-enumerator = <0>; + gpios = <&pio 6 2 GPIO_ACTIVE_LOW>; /* PG2 */ + }; + + led-1 { + color = <LED_COLOR_ID_ORANGE>; + function = LED_FUNCTION_INDICATOR; + function-enumerator = <1>; + gpios = <&pio 6 4 GPIO_ACTIVE_LOW>; /* PG4 */ + };arch/arm64/boot/dts/allwinner/sun50i-h618-longanpi-3h.dts line 52
Quoted 10 lines
arch/arm64/boot/dts/allwinner/sun50i-h618-longanpi-3h.dts new file +10
-0+ }; + + reg_vcc5v: vcc5v { + /* board wide 5V supply directly from the USB-C socket */ + compatible = "regulator-fixed"; + regulator-name = "vcc-5v"; + regulator-min-microvolt = <5000000>; + regulator-max-microvolt = <5000000>; + regulator-always-on; + };According to the schematic, there is a discrete 5V->3.3V regulator, can you please describe this here as well?
Quoted 14 lines
arch/arm64/boot/dts/allwinner/sun50i-h618-longanpi-3h.dts new file +14
-0+}; + +&axp313 { + vin1-supply = <®_vcc5v>; + vin2-supply = <®_vcc5v>; + vin3-supply = <®_vcc5v>; +}; + +&ehci1 { + status = "okay"; +}; + +&ohci1 { + status = "okay";arch/arm64/boot/dts/allwinner/sun50i-h618-longanpi-3h.dts line 76
Quoted 10 lines
arch/arm64/boot/dts/allwinner/sun50i-h618-longanpi-3h.dts new file +10
-0+}; + +&ehci2 { + status = "okay"; +}; + +&ohci2 { + status = "okay"; +}; +Maybe worth adding a comment here that there is a USB WiFi chip connected to those pins.
Quoted 6 lines
arch/arm64/boot/dts/allwinner/sun50i-h618-longanpi-3h.dts new file +6
-0+&ehci3 { + status = "okay"; +}; + +&ohci3 { + status = "okay";arch/arm64/boot/dts/allwinner/sun50i-h618-longanpi-3h.dts line 92
Quoted 10 lines
arch/arm64/boot/dts/allwinner/sun50i-h618-longanpi-3h.dts new file +10
-0+}; + +&emac0 { + pinctrl-names = "default"; + pinctrl-0 = <&ext_rgmii_pins>; + phy-mode = "rgmii"; + phy-handle = <&ext_rgmii_phy>; + allwinner,rx-delay-ps = <3100>; + allwinner,tx-delay-ps = <700>; + phy-supply = <®_dldo1>;If I get the schematic correctly, the PHY is powered from the discrete 3.3V regulator? In fact, the 3V3-DLDO-OUT/1V8-ALDO-OUT pins on the SoM do not seem to be connected, so anything using 3.3V or 1.8V on the board needs to be fed from this regulator, and everything on the SoM is supplied by the AXP?
Quoted 4 lines
arch/arm64/boot/dts/allwinner/sun50i-h618-longanpi-3h.dts new file +4
-0+ status = "okay"; +}; + +&mdio0 {arch/arm64/boot/dts/allwinner/sun50i-h618-longanpi-3h.dts line 106
Quoted 10 lines
arch/arm64/boot/dts/allwinner/sun50i-h618-longanpi-3h.dts new file +10
-0+ ext_rgmii_phy: ethernet-phy@1 { + compatible = "ethernet-phy-ieee802.3-c22"; + reg = <1>; + }; +}; + +&mmc0 { + bus-width = <4>; + cd-gpios = <&pio 5 6 GPIO_ACTIVE_HIGH>; /* PF6 */ + vmmc-supply = <®_dldo1>;According to the schematic, the SD card is supplied by the discrete 3.3V regulator on the board.
Quoted 15 lines
arch/arm64/boot/dts/allwinner/sun50i-h618-longanpi-3h.dts new file +15
-0+ status = "okay"; +}; + +&uart0 { + status = "okay"; +}; + +&usbotg { + /* + * PHY0 pins are connected to a USB-C socket, but a role switch + * is not implemented: both CC pins are pulled to GND. + * The VBUS pins power the device, so a fixed peripheral mode + * is the best choice. + * The board can be powered via GPIOs, in this case port0 *can* + * act as a host (with a cable/adapter ignoring CC), as VBUS isarch/arm64/boot/dts/allwinner/sun50i-h618-longanpi-3h.dts line 131
Quoted 10 lines
arch/arm64/boot/dts/allwinner/sun50i-h618-longanpi-3h.dts new file +10
-0+ * then provided by the GPIOs. Any user of this setup would + * need to adjust the DT accordingly: dr_mode set to "host", + * enabling OHCI0 and EHCI0. + */ + dr_mode = "peripheral"; + status = "okay"; +}; + +&usbphy { + usb1_vbus-supply = <®_vcc5v>;The same seems to be true for USB2 as well, and the WiFi chip on USB3 is powered by the discrete 3.3V regulator. But I think we don't need these properties at all if it's directly connected to the input and so always powered. Or maybe we should do this anyway, and be it to make it clear where the bus power is coming from?
Cheers,
Andre
P.S. I saw some U-Boot patches on some github. Most of them are merged, but feel free to post the DT (same ones as here) and the defconfig to the U-Boot list as well. You can use "make savedefconfig" when you have configured the board, this will create a file "defconfig" in the build directory that contains the minimal items, this can be directly used as a defconfig.Quoted 2 lines
arch/arm64/boot/dts/allwinner/sun50i-h618-longanpi-3h.dts new file +2
-0+ status = "okay"; +};
Jernej Škrabec
maintainerRe: [PATCH 2/2] arm64: dts: allwinner: h616: Add Sipeed Longan SoM 3H and Pi 3H board support
In reply to Jisheng ZhangHi Jisheng,
Andre gave you thorough review already, so just one additional comment below.
Dne četrtek, 28. december 2023 ob 15:56:47 CET je Jisheng Zhang napisal(a):
Quoted 60 lines
The Sipeed Longan SoM 3H is a system on module based on the Allwinner H618 SoC. The SoM features:
- Four ARM Cortex-A53 cores, Mali-G31 MP2 GPU
- 2/4 GiB LPDDR4 DRAM SoMs
- AXP313a PMIC
- eMMCThe Sipeed Longan PI 3H is a development board based on the above SoM. The board features:
- Longan SoM 3H
- Raspberry-Pi-1 compatible GPIO header
- 2 USB 2.0 host port
- 1 USB 2.0 type C port (power supply + OTG)
- MicroSD slot
- 1Gbps Ethernet port (via RTL8211 PHY)
- HDMI port
- WiFi/BT chipAdd the devicetree file describing the currently supported features, namely PMIC, LEDs, UART, SD card, eMMC, USB and Ethernet.
Signed-off-by Jisheng Zhang <[email protected]>--- arch/arm64/boot/dts/allwinner/Makefile | 1 + .../sun50i-h618-longan-module-3h.dtsi | 82 +++++++++++ .../dts/allwinner/sun50i-h618-longanpi-3h.dts | 133 ++++++++++++++++++ 3 files changed, 216 insertions(+) create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h618-longan-module-3h.dtsi create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h618-longanpi-3h.dtsarch/arm64/boot/dts/allwinner/Makefile +1
-0@@ -42,4 +42,5 @@ dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-bigtreetech-cb1-manta.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-bigtreetech-pi.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-orangepi-zero2.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-x96-mate.dtb +dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h618-longanpi-3h.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h618-orangepi-zero3.dtbarch/arm64/boot/dts/allwinner/sun50i-h618-longan-module-3h.dtsi new file +13
-0@@ -0,0 +1,82 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Copyright (C) Jisheng Zhang <[email protected]> + */ + +/dts-v1/; + +#include "sun50i-h616.dtsi" + +/ { + model = "Sipeed Longan Module 3H"; + compatible = "sipeed,longan-module-3h", "allwinner,sun50i-h618"; +};
arch/arm64/boot/dts/allwinner/sun50i-h618-longan-module-3h.dtsi line 23
Quoted 10 lines
arch/arm64/boot/dts/allwinner/sun50i-h618-longan-module-3h.dtsi new file +10
-0+ +&mmc2 { + pinctrl-names = "default"; + pinctrl-0 = <&mmc2_pins>; + vmmc-supply = <®_dldo1>; + vqmmc-supply = <®_aldo1>; + bus-width = <8>; + non-removable; + cap-mmc-hw-reset; + mmc-ddr-1_8v;
I think above is superfluous if hs200 is also defined.
Best regards,
Jernej
Quoted 199 lines
arch/arm64/boot/dts/allwinner/sun50i-h618-longan-module-3h.dtsi new file +59
-0+ mmc-hs200-1_8v; + status = "okay"; +}; + +&r_i2c { + status = "okay"; + + axp313: pmic@36 { + compatible = "x-powers,axp313a"; + reg = <0x36>; + + regulators { + /* Supplies VCC-PLL, so needs to be always on. */ + reg_aldo1: aldo1 { + regulator-always-on; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-name = "vcc1v8"; + }; + + /* Supplies VCC-IO, so needs to be always on. */ + reg_dldo1: dldo1 { + regulator-always-on; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + regulator-name = "vcc3v3"; + }; + + reg_dcdc1: dcdc1 { + regulator-always-on; + regulator-min-microvolt = <810000>; + regulator-max-microvolt = <990000>; + regulator-name = "vdd-gpu-sys"; + }; + + reg_dcdc2: dcdc2 { + regulator-always-on; + regulator-min-microvolt = <810000>; + regulator-max-microvolt = <1100000>; + regulator-name = "vdd-cpu"; + }; + + reg_dcdc3: dcdc3 { + regulator-always-on; + regulator-min-microvolt = <1100000>; + regulator-max-microvolt = <1100000>; + regulator-name = "vdd-dram"; + }; + }; + }; +}; + +&pio { + vcc-pc-supply = <®_dldo1>; + vcc-pf-supply = <®_dldo1>; + vcc-pg-supply = <®_aldo1>; + vcc-ph-supply = <®_dldo1>; + vcc-pi-supply = <®_dldo1>; +};arch/arm64/boot/dts/allwinner/sun50i-h618-longanpi-3h.dts new file +133
-0@@ -0,0 +1,133 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Copyright (C) Jisheng Zhang <[email protected]> + */ + +/dts-v1/; + +#include "sun50i-h618-longan-module-3h.dtsi" + +#include <dt-bindings/gpio/gpio.h> +#include <dt-bindings/interrupt-controller/arm-gic.h> +#include <dt-bindings/leds/common.h> + +/ { + model = "Sipeed Longan Pi 3H"; + compatible = "sipeed,longan-pi-3h", "sipeed,longan-module-3h", "allwinner,sun50i-h618"; + + aliases { + ethernet0 = &emac0; + serial0 = &uart0; + }; + + chosen { + stdout-path = "serial0:115200n8"; + }; + + leds { + compatible = "gpio-leds"; + + led-0 { + color = <LED_COLOR_ID_ORANGE>; + function = LED_FUNCTION_INDICATOR; + function-enumerator = <0>; + gpios = <&pio 6 2 GPIO_ACTIVE_LOW>; /* PG2 */ + }; + + led-1 { + color = <LED_COLOR_ID_ORANGE>; + function = LED_FUNCTION_INDICATOR; + function-enumerator = <1>; + gpios = <&pio 6 4 GPIO_ACTIVE_LOW>; /* PG4 */ + }; + }; + + reg_vcc5v: vcc5v { + /* board wide 5V supply directly from the USB-C socket */ + compatible = "regulator-fixed"; + regulator-name = "vcc-5v"; + regulator-min-microvolt = <5000000>; + regulator-max-microvolt = <5000000>; + regulator-always-on; + }; +}; + +&axp313 { + vin1-supply = <®_vcc5v>; + vin2-supply = <®_vcc5v>; + vin3-supply = <®_vcc5v>; +}; + +&ehci1 { + status = "okay"; +}; + +&ohci1 { + status = "okay"; +}; + +&ehci2 { + status = "okay"; +}; + +&ohci2 { + status = "okay"; +}; + +&ehci3 { + status = "okay"; +}; + +&ohci3 { + status = "okay"; +}; + +&emac0 { + pinctrl-names = "default"; + pinctrl-0 = <&ext_rgmii_pins>; + phy-mode = "rgmii"; + phy-handle = <&ext_rgmii_phy>; + allwinner,rx-delay-ps = <3100>; + allwinner,tx-delay-ps = <700>; + phy-supply = <®_dldo1>; + status = "okay"; +}; + +&mdio0 { + ext_rgmii_phy: ethernet-phy@1 { + compatible = "ethernet-phy-ieee802.3-c22"; + reg = <1>; + }; +}; + +&mmc0 { + bus-width = <4>; + cd-gpios = <&pio 5 6 GPIO_ACTIVE_HIGH>; /* PF6 */ + vmmc-supply = <®_dldo1>; + status = "okay"; +}; + +&uart0 { + status = "okay"; +}; + +&usbotg { + /* + * PHY0 pins are connected to a USB-C socket, but a role switch + * is not implemented: both CC pins are pulled to GND. + * The VBUS pins power the device, so a fixed peripheral mode + * is the best choice. + * The board can be powered via GPIOs, in this case port0 *can* + * act as a host (with a cable/adapter ignoring CC), as VBUS is + * then provided by the GPIOs. Any user of this setup would + * need to adjust the DT accordingly: dr_mode set to "host", + * enabling OHCI0 and EHCI0. + */ + dr_mode = "peripheral"; + status = "okay"; +}; + +&usbphy { + usb1_vbus-supply = <®_vcc5v>; + status = "okay"; +};
Re: [PATCH 2/2] arm64: dts: allwinner: h616: Add Sipeed Longan SoM 3H and Pi 3H board support
Quoted 1 line · Jernej Škrabec
Hi Jisheng,
Hi Jernej,
Quoted 69 lines
Andre gave you thorough review already, so just one additional comment below.
Dne četrtek, 28. december 2023 ob 15:56:47 CET je Jisheng Zhang napisal(a):
Quoted 64 lines
The Sipeed Longan SoM 3H is a system on module based on the Allwinner H618 SoC. The SoM features:
- Four ARM Cortex-A53 cores, Mali-G31 MP2 GPU
- 2/4 GiB LPDDR4 DRAM SoMs
- AXP313a PMIC
- eMMCThe Sipeed Longan PI 3H is a development board based on the above SoM. The board features:
- Longan SoM 3H
- Raspberry-Pi-1 compatible GPIO header
- 2 USB 2.0 host port
- 1 USB 2.0 type C port (power supply + OTG)
- MicroSD slot
- 1Gbps Ethernet port (via RTL8211 PHY)
- HDMI port
- WiFi/BT chipAdd the devicetree file describing the currently supported features, namely PMIC, LEDs, UART, SD card, eMMC, USB and Ethernet.
Signed-off-by Jisheng Zhang <[email protected]>--- arch/arm64/boot/dts/allwinner/Makefile | 1 + .../sun50i-h618-longan-module-3h.dtsi | 82 +++++++++++ .../dts/allwinner/sun50i-h618-longanpi-3h.dts | 133 ++++++++++++++++++ 3 files changed, 216 insertions(+) create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h618-longan-module-3h.dtsi create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h618-longanpi-3h.dtsarch/arm64/boot/dts/allwinner/Makefile +1
-0@@ -42,4 +42,5 @@ dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-bigtreetech-cb1-manta.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-bigtreetech-pi.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-orangepi-zero2.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-x96-mate.dtb +dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h618-longanpi-3h.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h618-orangepi-zero3.dtbarch/arm64/boot/dts/allwinner/sun50i-h618-longan-module-3h.dtsi new file +17
-0@@ -0,0 +1,82 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Copyright (C) Jisheng Zhang <[email protected]> + */ + +/dts-v1/; + +#include "sun50i-h616.dtsi" + +/ { + model = "Sipeed Longan Module 3H"; + compatible = "sipeed,longan-module-3h", "allwinner,sun50i-h618"; +}; + +&mmc2 { + pinctrl-names = "default"; + pinctrl-0 = <&mmc2_pins>;
Quoted 8 lines
arch/arm64/boot/dts/allwinner/sun50i-h618-longan-module-3h.dtsi line 23
Quoted 6 lines
arch/arm64/boot/dts/allwinner/sun50i-h618-longan-module-3h.dtsi new file +6
-0+ vmmc-supply = <®_dldo1>; + vqmmc-supply = <®_aldo1>; + bus-width = <8>; + non-removable; + cap-mmc-hw-reset; + mmc-ddr-1_8v;I think above is superfluous if hs200 is also defined.
I read the mmc code again, IMHO, mmc-ddr-1_8v and mmc-hs200-1_8v are for different caps, the former is for MMC_CAP_1_8V_DDR and the later is for MMC_CAP2_HS200_1_8V_SDR, I must admit that mmc-hs200-1_8v does imply mmc-ddr-1_8v in normal host controllers but they are different, and I found other dts files also contain both, so I kept this as is in v2.
Thanks
Quoted 5 lines
Quoted 5 lines
arch/arm64/boot/dts/allwinner/sun50i-h618-longan-module-3h.dtsi new file +4
-0+ mmc-hs200-1_8v; + status = "okay"; +}; +
Jernej Škrabec
maintainerRe: [PATCH 2/2] arm64: dts: allwinner: h616: Add Sipeed Longan SoM 3H and Pi 3H board support
Dne sobota, 03. februar 2024 ob 13:36:42 CET je Jisheng Zhang napisal(a):
Quoted 83 lines · Jernej Škrabec
Quoted 1 line
Hi Jisheng,
Hi Jernej,
Quoted 69 lines
Andre gave you thorough review already, so just one additional comment below.
Dne četrtek, 28. december 2023 ob 15:56:47 CET je Jisheng Zhang napisal(a):
Quoted 64 lines
The Sipeed Longan SoM 3H is a system on module based on the Allwinner H618 SoC. The SoM features:
- Four ARM Cortex-A53 cores, Mali-G31 MP2 GPU
- 2/4 GiB LPDDR4 DRAM SoMs
- AXP313a PMIC
- eMMCThe Sipeed Longan PI 3H is a development board based on the above SoM. The board features:
- Longan SoM 3H
- Raspberry-Pi-1 compatible GPIO header
- 2 USB 2.0 host port
- 1 USB 2.0 type C port (power supply + OTG)
- MicroSD slot
- 1Gbps Ethernet port (via RTL8211 PHY)
- HDMI port
- WiFi/BT chipAdd the devicetree file describing the currently supported features, namely PMIC, LEDs, UART, SD card, eMMC, USB and Ethernet.
Signed-off-by Jisheng Zhang <[email protected]>--- arch/arm64/boot/dts/allwinner/Makefile | 1 + .../sun50i-h618-longan-module-3h.dtsi | 82 +++++++++++ .../dts/allwinner/sun50i-h618-longanpi-3h.dts | 133 ++++++++++++++++++ 3 files changed, 216 insertions(+) create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h618-longan-module-3h.dtsi create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h618-longanpi-3h.dtsarch/arm64/boot/dts/allwinner/Makefile +1
-0@@ -42,4 +42,5 @@ dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-bigtreetech-cb1-manta.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-bigtreetech-pi.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-orangepi-zero2.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h616-x96-mate.dtb +dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h618-longanpi-3h.dtb dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h618-orangepi-zero3.dtbarch/arm64/boot/dts/allwinner/sun50i-h618-longan-module-3h.dtsi new file +17
-0@@ -0,0 +1,82 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Copyright (C) Jisheng Zhang <[email protected]> + */ + +/dts-v1/; + +#include "sun50i-h616.dtsi" + +/ { + model = "Sipeed Longan Module 3H"; + compatible = "sipeed,longan-module-3h", "allwinner,sun50i-h618"; +}; + +&mmc2 { + pinctrl-names = "default"; + pinctrl-0 = <&mmc2_pins>;Quoted 8 lines
arch/arm64/boot/dts/allwinner/sun50i-h618-longan-module-3h.dtsi line 23
Quoted 6 lines
arch/arm64/boot/dts/allwinner/sun50i-h618-longan-module-3h.dtsi new file +6
-0+ vmmc-supply = <®_dldo1>; + vqmmc-supply = <®_aldo1>; + bus-width = <8>; + non-removable; + cap-mmc-hw-reset; + mmc-ddr-1_8v;I think above is superfluous if hs200 is also defined.
Quoted 6 lines
I read the mmc code again, IMHO, mmc-ddr-1_8v and mmc-hs200-1_8v are for different caps, the former is for
MMC_CAP_1_8V_DDRand the later is forMMC_CAP2_HS200_1_8V_SDR, I must admit that mmc-hs200-1_8v does imply mmc-ddr-1_8v in normal host controllers but they are different, and I found other dts files also contain both, so I kept this as is in v2.
Yeah, this was oversight. Most DTs have only second one defined.
Best regards,
Jernej
Quoted 10 lines
Thanks
Quoted 5 lines
Quoted 5 lines
arch/arm64/boot/dts/allwinner/sun50i-h618-longan-module-3h.dtsi new file +4
-0+ mmc-hs200-1_8v; + status = "okay"; +}; +