Skip to contentSkip to conversation

mm-fix-arithmetic-for-max_prop_frac-when-setting-max_ratio.patch removed from -mm tree

merged mm-hotfixes-stable Andrew Morton 1 participant 1 message Dec 29, 2023

lore
Share & tools
lore

Andrew Morton

author tree notice Applied
#0 lore raw

The quilt patch titled
Subject: mm: fix arithmetic for max_prop_frac when setting max_ratio
has been removed from the -mm tree. Its filename was
mm-fix-arithmetic-for-max_prop_frac-when-setting-max_ratio.patch

This patch was dropped because it was merged into the mm-hotfixes-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

------------------------------------------------------
From: Jingbo Xu <[email protected]>
Subject: mm: fix arithmetic for max_prop_frac when setting max_ratio
Date: Tue, 19 Dec 2023 22:25:08 +0800

Since now bdi->max_ratio is part per million, fix the wrong arithmetic for max_prop_frac when setting max_ratio. Otherwise the miscalculated max_prop_frac will affect the incrementing of writeout completion count when max_ratio is not 100%.

Fixes efc3e6ad53ea ("mm: split off __bdi_set_max_ratio() function")
Cc Joseph Qi <[email protected]>
Cc Matthew Wilcox (Oracle) <[email protected]>
Cc Stefan Roesch <[email protected]>

---

 mm/page-writeback.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
mm/page-writeback.c renamed from mm/page-writeback.c~mm-fix-arithmetic-for-max_prop_frac-when-setting-max_ratio +2 -1
@@ -728,7 +728,8 @@ static int __bdi_set_max_ratio(struct ba
 		ret = -EINVAL;
 	} else {
 		bdi->max_ratio = max_ratio;
-		bdi->max_prop_frac = (FPROP_FRAC_BASE * max_ratio) / 100;
+		bdi->max_prop_frac = (FPROP_FRAC_BASE * max_ratio) /
+						(100 * BDI_RATIO_SCALE);
 	}
 	spin_unlock_bh(&bdi_lock);
 

_

Patches currently in -mm which might be from [email protected] are