Skip to contentSkip to conversation

mm-remove-vm_exec-requirement-for-thp-eligibility.patch removed from -mm tree

merged mm-stable Andrew Morton 1 participant 1 message Dec 29, 2023

lore
Share & tools
lore

Andrew Morton

author tree notice Applied
#0 lore raw

The quilt patch titled
Subject: mm: remove VM_EXEC requirement for THP eligibility
has been removed from the -mm tree. Its filename was
mm-remove-vm_exec-requirement-for-thp-eligibility.patch

This patch was dropped because it was merged into the mm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

------------------------------------------------------
From: Fangrui Song <[email protected]>
Subject: mm: remove VM_EXEC requirement for THP eligibility
Date: Tue, 19 Dec 2023 21:41:23 -0800

Commit e6be37b2e7bd ("mm/huge_memory.c: add missing read-only THP checking in transparent_hugepage_enabled()") introduced the VM_EXEC requirement, which is not strictly needed.

lld's default --rosegment option and GNU ld's -z separate-code option (default on Linux/x86 since binutils 2.31) create a read-only PT_LOAD segment without the PF_X flag, which should be eligible for THP.

Certain architectures support medium and large code models, where .lrodata may be placed in a separate read-only PT_LOAD segment, which should be eligible for THP as well.

---

 include/linux/huge_mm.h |    1 -
 1 file changed, 1 deletion(-)
include/linux/huge_mm.h renamed from include/linux/huge_mm.h~mm-remove-vm_exec-requirement-for-thp-eligibility +0 -1
@@ -206,7 +206,6 @@ static inline bool file_thp_enabled(stru
 	inode = vma->vm_file->f_inode;
 
 	return (IS_ENABLED(CONFIG_READ_ONLY_THP_FOR_FS)) &&
-	       (vma->vm_flags & VM_EXEC) &&
 	       !inode_is_open_for_write(inode) && S_ISREG(inode->i_mode);
 }
 

_

Patches currently in -mm which might be from [email protected] are