configs/broadcom_northstar_defconfig: adjust DTS paths
PATCH 1/1 configs/broadcom_northstar_defconfig: adjust DTS paths
From: Rafał Miłecki <[email protected]>
Starting with kernel release v6.5 ARM DTS files are placed in vendor subdirectories (Linux commit 724ba6751532 ("ARM: dts: Move .dts files to vendor sub-directories")).
This fixes:
make[3]: *** No rule to make target 'arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dtb'. Stop. make[2]: *** [Makefile:1384: bcm4708-smartrg-sr400ac.dtb] Error 2
make[3]: *** No rule to make target 'arch/arm/boot/dts/bcm47094-luxul-xwr-3150-v1.dtb'. Stop. make[2]: *** [Makefile:1384: bcm47094-luxul-xwr-3150-v1.dtb] Error 2
--- configs/broadcom_northstar_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
configs/broadcom_northstar_defconfig +1 -1
@@ -5,7 +5,7 @@ BR2_LINUX_KERNEL=y BR2_LINUX_KERNEL_USE_CUSTOM_CONFIG=y BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE="board/broadcom/northstar/linux.config" BR2_LINUX_KERNEL_APPENDED_ZIMAGE=y -BR2_LINUX_KERNEL_INTREE_DTS_NAME="bcm4708-smartrg-sr400ac bcm47094-luxul-xwr-3150-v1" +BR2_LINUX_KERNEL_INTREE_DTS_NAME="broadcom/bcm4708-smartrg-sr400ac broadcom/bcm47094-luxul-xwr-3150-v1" # BR2_TARGET_ROOTFS_TAR is not set BR2_TARGET_ROOTFS_UBI=y BR2_TARGET_ROOTFS_UBI_SUBSIZE=2048
Signature · 6 lines
2.35.3 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Hello Rafał,
Quoted 6 lines · On Tue, 2 Jan 2024 11:42:58 +0100 Rafał Miłecki <[email protected]> wrote:
From: Rafał Miłecki <[email protected]>
Starting with kernel release v6.5 ARM DTS files are placed in vendor subdirectories (Linux commit
724ba6751532("ARM: dts: Move .dts files to vendor sub-directories")).
Quoted 7 lines
This fixes:
make[3]: *** No rule to make target 'arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dtb'. Stop. make[2]: *** [Makefile:1384: bcm4708-smartrg-sr400ac.dtb] Error 2
make[3]: *** No rule to make target 'arch/arm/boot/dts/bcm47094-luxul-xwr-3150-v1.dtb'. Stop. make[2]: *** [Makefile:1384: bcm47094-luxul-xwr-3150-v1.dtb] Error 2Signed-off-by Rafał Miłecki <[email protected]>
Thanks for the patch! I was wondering when it got broken, and this made be realize that this defconfig doesn't follow a best practice that we normally apply to all our defconfigs: the kernel version being built should not be a moving target, but be fixed in the defconfig.
So, I've applied your patch, but could you submit a follow-up patch that sets a fixed kernel version, just like we do in all defconfigs? It also means the kernel headers version of the toolchain should be fixed (again, I encourage you to look at the numerous other defconfigs we have for examples of this).
Thanks a lot!
Thomas
Signature · 7 lines
Thomas Petazzoni, co-owner and CEO, Bootlin Embedded Linux and Kernel engineering and training https://bootlin.com _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Quoted 22 lines · Thomas Petazzoni
Quoted 6 lines · On Tue, 2 Jan 2024 11:42:58 +0100 Rafał Miłecki <[email protected]> wrote:
From: Rafał Miłecki <[email protected]>
Starting with kernel release v6.5 ARM DTS files are placed in vendor subdirectories (Linux commit
724ba6751532("ARM: dts: Move .dts files to vendor sub-directories")).Quoted 7 lines
This fixes:
make[3]: *** No rule to make target 'arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dtb'. Stop. make[2]: *** [Makefile:1384: bcm4708-smartrg-sr400ac.dtb] Error 2
make[3]: *** No rule to make target 'arch/arm/boot/dts/bcm47094-luxul-xwr-3150-v1.dtb'. Stop. make[2]: *** [Makefile:1384: bcm47094-luxul-xwr-3150-v1.dtb] Error 2Signed-off-by Rafał Miłecki <[email protected]>Thanks for the patch! I was wondering when it got broken, and this made be realize that this defconfig doesn't follow a best practice that we normally apply to all our defconfigs: the kernel version being built should not be a moving target, but be fixed in the defconfig.
Quoted 5 lines
So, I've applied your patch, but could you submit a follow-up patch that sets a fixed kernel version, just like we do in all defconfigs? It also means the kernel headers version of the toolchain should be fixed (again, I encourage you to look at the numerous other defconfigs we have for examples of this).
Will do, thank you for pointing it out!
Signature · 5 lines
Rafał Miłecki _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot