Skip to contentSkip to conversation

drm/msm/a7xx: Fix LLC typo

PATCH In review Rob Clark 2 participants 3 messages Jan 2, 2024 – Jan 3, 2024

Subsystems (4)
lore
Share & tools
lore

Rob Clark

author
#0 lore raw

PATCH 1/1 drm/msm/a7xx: Fix LLC typo

From: Rob Clark <[email protected]>

We'd miss actually activating LLC.

---
 drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/msm/adreno/a6xx_gpu.c +1 -1
index a5660d63535b..54dc5eb37f70 100644
@@ -1646,7 +1646,7 @@ static int a6xx_gmu_pm_resume(struct msm_gpu *gpu)
 
 	msm_devfreq_resume(gpu);
 
-	adreno_is_a7xx(adreno_gpu) ? a7xx_llc_activate : a6xx_llc_activate(a6xx_gpu);
+	adreno_is_a7xx(adreno_gpu) ? a7xx_llc_activate(a6xx_gpu) : a6xx_llc_activate(a6xx_gpu);
 
 	return ret;
 }
Signature · 1 line
2.43.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 14 lines · Rob Clark

From: Rob Clark <[email protected]>

We'd miss actually activating LLC.

---
 drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/msm/adreno/a6xx_gpu.c +0 -0
index a5660d63535b..54dc5eb37f70 100644

drivers/gpu/drm/msm/adreno/a6xx_gpu.c static int a6xx_gmu_pm_resume(struct msm_gpu *gpu) · line 1649

Quoted 5 lines
drivers/gpu/drm/msm/adreno/a6xx_gpu.c +1 -1
@@ -1646,7 +1646,7 @@ static int a6xx_gmu_pm_resume(struct msm_gpu *gpu)
 
 	msm_devfreq_resume(gpu);
 
-	adreno_is_a7xx(adreno_gpu) ? a7xx_llc_activate : a6xx_llc_activate(a6xx_gpu);
+	adreno_is_a7xx(adreno_gpu) ? a7xx_llc_activate(a6xx_gpu) : a6xx_llc_activate(a6xx_gpu);

/me cleans glasses

oh..

Konrad

author
#2 lore raw
Quoted 19 lines · Konrad Dybcio
Quoted 17 lines · Rob Clark

From: Rob Clark <[email protected]>

We'd miss actually activating LLC.

---
 drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/msm/adreno/a6xx_gpu.c +0 -0
index a5660d63535b..54dc5eb37f70 100644
@@ -1646,7 +1646,7 @@ static int a6xx_gmu_pm_resume(struct msm_gpu *gpu)
 
      msm_devfreq_resume(gpu);
 
Quoted 8 lines

drivers/gpu/drm/msm/adreno/a6xx_gpu.c static int a6xx_gmu_pm_resume(struct msm_gpu *gpu) · line 1649

Quoted 2 lines
drivers/gpu/drm/msm/adreno/a6xx_gpu.c +1 -1
-     adreno_is_a7xx(adreno_gpu) ? a7xx_llc_activate : a6xx_llc_activate(a6xx_gpu);
+     adreno_is_a7xx(adreno_gpu) ? a7xx_llc_activate(a6xx_gpu) : a6xx_llc_activate(a6xx_gpu);

/me cleans glasses

oh..

I suppose I should also add,

Fixes af66706accdf ("drm/msm/a6xx: Add skeleton A7xx support")
Quoted 1 line

Konrad