Skip to contentSkip to conversation

board/broadcom/northstar: fix building custom images

PATCH In review Rafał Miłecki 2 participants 2 messages Jan 3, 2024 – Jan 13, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 board/broadcom/northstar: fix building custom images

From: Rafał Miłecki <[email protected]>

Custom Northstar images allow installing (flashing) them using vendor UI or CFE bootloader. Change of DTS files paths ("broadcom/" prefix introduction) prevented post script from generating them.

Adjust post-image.sh to deal with new paths.

---
 board/broadcom/northstar/post-image.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
board/broadcom/northstar/post-image.sh +2 -1
index b6150fc539..559ed8bf4b 100755
@@ -27,8 +27,9 @@ build_trx() {
 	rm -f $images/zImage.$device.lzma
 }
 
-devices="$(sed -n 's/^BR2_LINUX_KERNEL_INTREE_DTS_NAME="\([a-z0-9 \-]*\)"$/\1/p' ${BR2_CONFIG})"
+devices="$(sed -n 's/^BR2_LINUX_KERNEL_INTREE_DTS_NAME="\([^"]*\)"$/\1/p' ${BR2_CONFIG})"
 for device in $devices; do
+	device="${device#broadcom/}"
 	case "$device" in
 		"bcm4708-smartrg-sr400ac")
 			build_trx "$1" "$device"
Signature · 6 lines
2.35.3

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw
Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Rafał" == Rafał Miłecki <[email protected]> writes:

From: Rafał Miłecki <[email protected]>
Custom Northstar images allow installing (flashing) them using vendor UI or CFE bootloader. Change of DTS files paths ("broadcom/" prefix introduction) prevented post script from generating them.

Adjust post-image.sh to deal with new paths.

I was a bit confused what this was about, but I guess it is just about the addition of the broadcom/ subdir in kernel 6.5+. I've slightly reworded the commit description and applied, thanks.

Quoted 28 lines
---
 board/broadcom/northstar/post-image.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
board/broadcom/northstar/post-image.sh +2 -1
index b6150fc539..559ed8bf4b 100755
@@ -27,8 +27,9 @@ build_trx() {
 	rm -f $images/zImage.$device.lzma
 }
 
-devices="$(sed -n 's/^BR2_LINUX_KERNEL_INTREE_DTS_NAME="\([a-z0-9 \-]*\)"$/\1/p' ${BR2_CONFIG})"
+devices="$(sed -n 's/^BR2_LINUX_KERNEL_INTREE_DTS_NAME="\([^"]*\)"$/\1/p' ${BR2_CONFIG})"
 for device in $devices; do
+	device="${device#broadcom/}"
 	case "$device" in
 		"bcm4708-smartrg-sr400ac")
 			build_trx "$1" "$device"
Signature · 6 lines
2.35.3

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Signature · 5 lines
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot