Skip to contentSkip to conversation

devtool: modify: fix exception

PATCH New Jamin Lin 1 participant 1 message Jan 3, 2024

lore
Share & tools
lore

Jamin Lin

author
#0 lore raw

PATCH 1/1 devtool: modify: fix exception

Root Cause:
initial_revs is an empty dictionary and do not have "." key.

Traceback (most recent call last):
File "scripts/devtool", line 349, in <module>
ret = main()
File "scripts/devtool", line 336, in main
ret = args.func(args, config, basepath, workspace)
File "scripts/lib/devtool/standard.py", line 922, in modify

    if not initial_revs["."]:

KeyError: '.'

Solution:
check key exists, then get its value.

---
 scripts/lib/devtool/standard.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/lib/devtool/standard.py +1 -1
index 559fd45676..2e56cd3050 100644
@@ -921,7 +921,7 @@ def modify(args, config, basepath, workspace):
                     if line.startswith('*'):
                         (stdout, _) = bb.process.run('git rev-parse devtool-base', cwd=srctree)
                         initial_revs["."] = stdout.rstrip()
-                if not initial_revs["."]:
+                if "." not in initial_revs:
                     # Otherwise, just grab the head revision
                     (stdout, _) = bb.process.run('git rev-parse HEAD', cwd=srctree)
                     initial_revs["."] = stdout.rstrip()
Signature · 1 line
2.25.1