Skip to contentSkip to conversation

softmmu: remove obsolete comment about libvirt timeouts

PATCH In review Daniel P. Berrangé 2 participants 3 messages Jan 3, 2024 – Jan 8, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 softmmu: remove obsolete comment about libvirt timeouts

For a long time now, libvirt has pre-created the monitor connection socket and passed the pre-opened FD into QEMU during startup. Thus libvirt does not have any timeouts waiting for the monitor socket to appear, it is immediately connected.

---
 system/vl.c | 1 -
 1 file changed, 1 deletion(-)
system/vl.c +0 -1
index 6b87bfa32c..1d1508e28f 100644
@@ -1911,7 +1911,6 @@ static bool object_create_early(const char *type)
      * Allocation of large amounts of memory may delay
      * chardev initialization for too long, and trigger timeouts
      * on software that waits for a monitor socket to be created
-     * (e.g. libvirt).
      */
     if (g_str_has_prefix(type, "memory-backend-")) {
         return false;
Signature · 1 line
2.43.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 19 lines · Daniel P. Berrangé

Date: Wed, 3 Jan 2024 12:30:42 +0000
From: "Daniel P. Berrangé" <[email protected]>
Subject: [PATCH] softmmu: remove obsolete comment about libvirt timeouts

For a long time now, libvirt has pre-created the monitor connection socket and passed the pre-opened FD into QEMU during startup. Thus libvirt does not have any timeouts waiting for the monitor socket to appear, it is immediately connected.

---
 system/vl.c | 1 -
 1 file changed, 1 deletion(-)
system/vl.c +0 -0
index 6b87bfa32c..1d1508e28f 100644

system/vl.c static bool object_create_early(const char *type) · line 1914

Quoted 4 lines
system/vl.c +0 -1
@@ -1911,7 +1911,6 @@ static bool object_create_early(const char *type)
      * Allocation of large amounts of memory may delay
      * chardev initialization for too long, and trigger timeouts
      * on software that waits for a monitor socket to be created
-     * (e.g. libvirt).

From the commit message of 6546d0dba6c2 ("vl: Delay initialization of memory backends"), and related bugzilla, I understand the only software Eduardo wanted to describe is libvirt.

Do you know of any other software that has the similar timeout mechanism? If there is no other software, the description of "trigger timeouts on software ..." in the comment could be deleted as well.

Otherwise,

Regards,
Zhao

Quoted 7 lines
system/vl.c +0 -0
      */
     if (g_str_has_prefix(type, "memory-backend-")) {
         return false;
Signature · 1 line
2.43.0
#2 lore raw
Quoted 29 lines · Zhao Liu
Quoted 19 lines · Daniel P. Berrangé

Date: Wed, 3 Jan 2024 12:30:42 +0000
From: "Daniel P. Berrangé" <[email protected]>
Subject: [PATCH] softmmu: remove obsolete comment about libvirt timeouts

For a long time now, libvirt has pre-created the monitor connection socket and passed the pre-opened FD into QEMU during startup. Thus libvirt does not have any timeouts waiting for the monitor socket to appear, it is immediately connected.

---
 system/vl.c | 1 -
 1 file changed, 1 deletion(-)
system/vl.c +0 -0
index 6b87bfa32c..1d1508e28f 100644

system/vl.c static bool object_create_early(const char *type) · line 1914

Quoted 4 lines
system/vl.c +0 -1
@@ -1911,7 +1911,6 @@ static bool object_create_early(const char *type)
      * Allocation of large amounts of memory may delay
      * chardev initialization for too long, and trigger timeouts
      * on software that waits for a monitor socket to be created
-     * (e.g. libvirt).

From the commit message of 6546d0dba6c2 ("vl: Delay initialization of memory backends"), and related bugzilla, I understand the only software Eduardo wanted to describe is libvirt.

Quoted 3 lines

Do you know of any other software that has the similar timeout mechanism? If there is no other software, the description of "trigger timeouts on software ..." in the comment could be deleted as well.

I haven't checked any other users recently, but waiting for the monitor socket with a timeout has been a common usage pattern, so I expect there are other users still besides libvirt which do this.

Quoted 15 lines

Otherwise,

Regards,
Zhao

Quoted 7 lines
system/vl.c +0 -0
      */
     if (g_str_has_prefix(type, "memory-backend-")) {
         return false;
Signature · 1 line
2.43.0

With regards,
Daniel

Signature · 3 lines
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|