Skip to contentSkip to conversation

execve: argument list space enlargement

PATCH In review [email protected] 3 participants 3 messages Jan 3, 2024 – Jan 11, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 execve: argument list space enlargement

From: Alex Shi <[email protected]>

Wechat using too long gcc parameters, then get a strace complain:
execve(...) = -1 E2BIG (Argument list too long)
Have to increase the parameter space for this, stack has enough space for this enlargement.

To: [email protected]
To: [email protected]
To: Kees Cook <[email protected]>
To: Eric Biederman <[email protected]>

---
 include/uapi/linux/binfmts.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/uapi/linux/binfmts.h +1 -1
index c6f9450efc12..717f6cafe8dd 100644
@@ -12,7 +12,7 @@ struct pt_regs;
  * prevent the kernel from being unduly impacted by misaddressed pointers.
  * MAX_ARG_STRINGS is chosen to fit in a signed 32-bit integer.
  */
-#define MAX_ARG_STRLEN (PAGE_SIZE * 32)
+#define MAX_ARG_STRLEN (PAGE_SIZE * 128)
 #define MAX_ARG_STRINGS 0x7FFFFFFF
 
 /* sizeof(linux_binprm->buf) */
Signature · 1 line
2.43.0
#1 lore raw

From: [email protected]

Quoted 8 lines

Sent: 03 January 2024 13:07

From: Alex Shi <[email protected]>

Wechat using too long gcc parameters, then get a strace complain:
execve(...) = -1 E2BIG (Argument list too long)
Have to increase the parameter space for this, stack has enough space for this enlargement.

They should fix their build so that it doesn't explode. It'll probably speed up the compiles as well since the very long argv[] almost certainly comes from a lot of -I dir options and they slow down the compile.

if they are -Dvar[=val] then '-include file' can be used instead.

David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)

#2 lore raw
In reply to [email protected]
Quoted 6 lines · On Wed, Jan 03, 2024 at 09:07:22PM +0800, [email protected] wrote:

From: Alex Shi <[email protected]>

Wechat using too long gcc parameters, then get a strace complain:
execve(...) = -1 E2BIG (Argument list too long)
Have to increase the parameter space for this, stack has enough space for this enlargement.

This is the second request recently[1] to expand the argument list size, but I remain somewhat unconvinced this needs fixing on the kernel side.

[1] https://lore.kernel.org/lkml/202310170957.DF7F7FE9FA@keescook/

If we do change it, though, as I mention in the thread above, I'd prefer to leave the UAPI alone and just detach the kernel internals from that hard-coded limit.

-Kees

Quoted 27 lines

To: [email protected]
To: [email protected]
To: Kees Cook <[email protected]>
To: Eric Biederman <[email protected]>

---
 include/uapi/linux/binfmts.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/uapi/linux/binfmts.h +1 -1
index c6f9450efc12..717f6cafe8dd 100644
@@ -12,7 +12,7 @@ struct pt_regs;
  * prevent the kernel from being unduly impacted by misaddressed pointers.
  * MAX_ARG_STRINGS is chosen to fit in a signed 32-bit integer.
  */
-#define MAX_ARG_STRLEN (PAGE_SIZE * 32)
+#define MAX_ARG_STRLEN (PAGE_SIZE * 128)
 #define MAX_ARG_STRINGS 0x7FFFFFFF
 
 /* sizeof(linux_binprm->buf) */
Signature · 1 line
2.43.0
Signature · 1 line
Kees Cook