Skip to contentSkip to conversation

drm/i915: Disable DSB in Xe KMD

PATCH Superseded José Roberto de Souza 3 participants 4 messages Jan 3, 2024 – Jan 4, 2024

Subsystems (3)

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 drm/i915: Disable DSB in Xe KMD

Often getting DBS overflows when starting Xorg or Wayland compositors when running Xe KMD.
Issue was reported but nothing was done, so disabling DSB as whole until properly fixed in Xe KMD.

v2:
- move check to HAS_DSB(Jani)

---
 drivers/gpu/drm/i915/display/intel_display_device.h | 5 +++++
 1 file changed, 5 insertions(+)
drivers/gpu/drm/i915/display/intel_display_device.h +5 -0
index fe42688137863..faa49aced46a5 100644
@@ -45,7 +45,12 @@ struct drm_printer;
 #define HAS_DP_MST(i915)		(DISPLAY_INFO(i915)->has_dp_mst)
 #define HAS_DP20(i915)			(IS_DG2(i915) || DISPLAY_VER(i915) >= 14)
 #define HAS_DPT(i915)			(DISPLAY_VER(i915) >= 13)
+#ifdef I915
 #define HAS_DSB(i915)			(DISPLAY_INFO(i915)->has_dsb)
+#else
+/* TODO: DSB is broken in Xe KMD, so disabling it until fixed */
+#define HAS_DSB(i915)			(false)
+#endif
 #define HAS_DSC(__i915)			(DISPLAY_RUNTIME_INFO(__i915)->has_dsc)
 #define HAS_FBC(i915)			(DISPLAY_RUNTIME_INFO(i915)->fbc_mask != 0)
 #define HAS_FPGA_DBG_UNCLAIMED(i915)	(DISPLAY_INFO(i915)->has_fpga_dbg)
Signature · 1 line
2.43.0
#1 lore raw

✗ Fi.CI.SPARSE: warning for drm/i915: Disable DSB in Xe KMD (rev2)

== Series Details ==

== Series Details ==

Series: drm/i915: Disable DSB in Xe KMD (rev2)
URL : https://patchwork.freedesktop.org/series/128163/
State : warning

== Summary ==

Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.

#2 lore raw

✗ Fi.CI.BAT: failure for drm/i915: Disable DSB in Xe KMD (rev2)

In reply to José Roberto de Souza
== Series Details ==

== Series Details ==

Series: drm/i915: Disable DSB in Xe KMD (rev2)
URL : https://patchwork.freedesktop.org/series/128163/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_14073 -> Patchwork_128163v2
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_128163v2 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes
introduced in Patchwork_128163v2, please notify your bug team ([email protected]) to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128163v2/index.html

Participating hosts (39 -> 26)
------------------------------

Missing (13): bat-mtlp-8 bat-dg2-8 fi-cfl-guc fi-apl-guc fi-snb-2520m fi-ilk-650 fi-kbl-guc fi-elk-e7500 bat-rpls-3 fi-pnv-d510 fi-cfl-8109u bat-jsl-3 fi-skl-6600u

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_128163v2:

### IGT changes ###

#### Possible regressions ####

* igt@i915_selftest@live@gt_timelines:
- fi-kbl-7567u: [PASS][1] -> [TIMEOUT][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14073/fi-kbl-7567u/igt@i915_selftest@live@gt_timelines.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128163v2/fi-kbl-7567u/igt@i915_selftest@live@gt_timelines.html

* igt@i915_suspend@basic-s2idle-without-i915:
- fi-kbl-7567u: [PASS][3] -> [WARN][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14073/fi-kbl-7567u/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128163v2/fi-kbl-7567u/igt@[email protected]

Known issues
------------

Here are the changes found in Patchwork_128163v2 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1:
- bat-rplp-1: [PASS][5] -> [ABORT][6] ([i915#8668])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14073/bat-rplp-1/igt@kms_pipe_crc_basic@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128163v2/bat-rplp-1/igt@kms_pipe_crc_basic@[email protected]

#### Possible fixes ####

* igt@kms_pm_rpm@basic-rte:
- bat-rpls-2: [ABORT][7] ([i915#8668] / [i915#9368] / [i915#9897]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14073/bat-rpls-2/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128163v2/bat-rpls-2/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[i915#8668]: https://gitlab.freedesktop.org/drm/intel/issues/8668
[i915#9368]: https://gitlab.freedesktop.org/drm/intel/issues/9368
[i915#9897]: https://gitlab.freedesktop.org/drm/intel/issues/9897

Build changes
-------------

* Linux: CI_DRM_14073 -> Patchwork_128163v2

CI-20190529: 20190529
CI_DRM_14073: 4ff460bc8efdc2ed2d0a388ecaf1555c9de28b04 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7655: ddf7cf40a00caa7d02f3729e1e50f78f102463d9 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_128163v2: 4ff460bc8efdc2ed2d0a388ecaf1555c9de28b04 @ git://anongit.freedesktop.org/gfx-ci/linux

### Linux commits

0646d7c34743 drm/i915: Disable DSB in Xe KMD

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_128163v2/index.html

#3 lore raw
In reply to José Roberto de Souza
Quoted 7 lines · José Roberto de Souza

Often getting DBS overflows when starting Xorg or Wayland compositors when running Xe KMD.
Issue was reported but nothing was done, so disabling DSB as whole until properly fixed in Xe KMD.

v2:
- move check to HAS_DSB(Jani)

I was thinking of something like

drivers/gpu/drm/i915/display/intel_dsb.c +4 -0
index 482c28b5c2de..a6c7122fd671 100644
@@ -453,6 +453,10 @@ struct intel_dsb *intel_dsb_prepare(const struct intel_crtc_state *crtc_state,
 	if (!HAS_DSB(i915))
 		return NULL;
 
+	/* TODO: DSB is broken in Xe KMD, so disabling it until fixed */
+	if (!IS_ENABLED(I915))
+		return NULL;
+
 	dsb = kzalloc(sizeof(*dsb), GFP_KERNEL);
 	if (!dsb)
 		goto out;
Quoted 29 lines
---
 drivers/gpu/drm/i915/display/intel_display_device.h | 5 +++++
 1 file changed, 5 insertions(+)
drivers/gpu/drm/i915/display/intel_display_device.h +5 -0
index fe42688137863..faa49aced46a5 100644
@@ -45,7 +45,12 @@ struct drm_printer;
 #define HAS_DP_MST(i915)		(DISPLAY_INFO(i915)->has_dp_mst)
 #define HAS_DP20(i915)			(IS_DG2(i915) || DISPLAY_VER(i915) >= 14)
 #define HAS_DPT(i915)			(DISPLAY_VER(i915) >= 13)
+#ifdef I915
 #define HAS_DSB(i915)			(DISPLAY_INFO(i915)->has_dsb)
+#else
+/* TODO: DSB is broken in Xe KMD, so disabling it until fixed */
+#define HAS_DSB(i915)			(false)
+#endif
 #define HAS_DSC(__i915)			(DISPLAY_RUNTIME_INFO(__i915)->has_dsc)
 #define HAS_FBC(i915)			(DISPLAY_RUNTIME_INFO(i915)->fbc_mask != 0)
 #define HAS_FPGA_DBG_UNCLAIMED(i915)	(DISPLAY_INFO(i915)->has_fpga_dbg)
Signature · 1 line
Jani Nikula, Intel