Skip to contentSkip to conversation

tests/intel/kms_dsc: add new constraint

PATCH Superseded Swati Sharma 3 participants 4 messages Jan 5, 2024

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tests/intel/kms_dsc: add new constraint

If output max bpc is less than min dsc bpc (8) which is supported by intel driver, don't execute test.

---
 tests/intel/kms_dsc.c | 4 ++++
 1 file changed, 4 insertions(+)
tests/intel/kms_dsc.c +4 -0
index 3433e0907..8ea15f4d2 100644
@@ -63,6 +63,7 @@ IGT_TEST_DESCRIPTION("Test to validate display stream compression");
 
 #define LEN		20
 #define DEFAULT_BPC	0
+#define MIN_DSC_BPC	8
 
 #define TEST_DSC_BASIC		(0<<0)
 #define TEST_DSC_BPC		(1<<0)
@@ -283,6 +284,9 @@ static void test_dsc(data_t *data, uint32_t test_type, int bpc,
 		      check_gen11_dp_constraint(data->drm_fd, data->output, data->pipe)))
 			continue;
 
+		if (igt_get_output_max_bpc(data->drm_fd, output->name) < MIN_DSC_BPC)
+			continue;
+
 		if ((test_type & TEST_DSC_OUTPUT_FORMAT) &&
 		    (!is_dsc_output_format_supported(data->drm_fd, data->disp_ver,
 						     data->output, data->output_format)))
Signature · 1 line
2.25.1
#1 lore raw

✓ CI.xeBAT: success for tests/intel/kms_dsc: add new constraint

== Series Details ==

== Series Details ==

Series: tests/intel/kms_dsc: add new constraint
URL : https://patchwork.freedesktop.org/series/128239/
State : success

== Summary ==

CI Bug Log - changes from XEIGT_7656_BAT -> XEIGTPW_10477_BAT
====================================================

Summary
-------

**SUCCESS**

No regressions found.

Participating hosts (3 -> 4)
------------------------------

Additional (1): bat-pvc-2

Known issues
------------

Here are the changes found in XEIGTPW_10477_BAT that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@kms_addfb_basic@addfb25-x-tiled-legacy:
- bat-pvc-2: NOTRUN -> [SKIP][1] ([i915#6077]) +30 other tests skip
[1]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10477/bat-pvc-2/igt@[email protected]

* igt@kms_cursor_legacy@basic-flip-after-cursor-atomic:
- bat-pvc-2: NOTRUN -> [SKIP][2] ([Intel XE#1024] / [Intel XE#782]) +5 other tests skip
[2]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10477/bat-pvc-2/igt@[email protected]

* igt@kms_dsc@dsc-basic:
- bat-pvc-2: NOTRUN -> [SKIP][3] ([Intel XE#1024] / [Intel XE#784])
[3]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10477/bat-pvc-2/igt@[email protected]

* igt@kms_flip@basic-flip-vs-wf_vblank:
- bat-pvc-2: NOTRUN -> [SKIP][4] ([Intel XE#1024] / [Intel XE#947]) +3 other tests skip
[4]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10477/bat-pvc-2/igt@kms_flip@basic-flip-vs-wf_vblank.html

* igt@kms_flip@basic-flip-vs-wf_vblank@d-dp3:
- bat-dg2-oem2: [PASS][5] -> [FAIL][6] ([Intel XE#480])
[5]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7656/bat-dg2-oem2/igt@kms_flip@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10477/bat-dg2-oem2/igt@kms_flip@[email protected]

* igt@kms_force_connector_basic@force-connector-state:
- bat-pvc-2: NOTRUN -> [SKIP][7] ([Intel XE#540]) +3 other tests skip
[7]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10477/bat-pvc-2/igt@[email protected]

* igt@kms_frontbuffer_tracking@basic:
- bat-pvc-2: NOTRUN -> [SKIP][8] ([Intel XE#1024] / [Intel XE#783])
[8]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10477/bat-pvc-2/igt@[email protected]

* igt@kms_pipe_crc_basic@nonblocking-crc:
- bat-pvc-2: NOTRUN -> [SKIP][9] ([Intel XE#829]) +6 other tests skip
[9]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10477/bat-pvc-2/igt@[email protected]

* igt@kms_prop_blob@basic:
- bat-pvc-2: NOTRUN -> [SKIP][10] ([Intel XE#780])
[10]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10477/bat-pvc-2/igt@[email protected]

* igt@xe_evict@evict-beng-small-external:
- bat-pvc-2: NOTRUN -> [FAIL][11] ([Intel XE#1000]) +3 other tests fail
[11]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10477/bat-pvc-2/igt@[email protected]

* igt@xe_evict@evict-small-external-cm:
- bat-pvc-2: NOTRUN -> [DMESG-FAIL][12] ([Intel XE#482]) +3 other tests dmesg-fail
[12]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10477/bat-pvc-2/igt@[email protected]

* igt@xe_evict_ccs@evict-overcommit-parallel-nofree-samefd:
- bat-pvc-2: NOTRUN -> [INCOMPLETE][13] ([Intel XE#392])
[13]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10477/bat-pvc-2/igt@[email protected]

* igt@xe_huc_copy@huc_copy:
- bat-pvc-2: NOTRUN -> [SKIP][14] ([Intel XE#255])
[14]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10477/bat-pvc-2/igt@xe_huc_copy@huc_copy.html

* igt@xe_intel_bb@render:
- bat-pvc-2: NOTRUN -> [SKIP][15] ([Intel XE#532])
[15]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10477/bat-pvc-2/igt@[email protected]

* igt@xe_module_load@load:
- bat-pvc-2: NOTRUN -> [SKIP][16] ([Intel XE#378])
[16]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10477/bat-pvc-2/igt@[email protected]

* igt@xe_pat@pat-index-xe2:
- bat-pvc-2: NOTRUN -> [SKIP][17] ([Intel XE#977]) +1 other test skip
[17]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10477/bat-pvc-2/igt@[email protected]

* igt@xe_pat@pat-index-xelpg:
- bat-pvc-2: NOTRUN -> [SKIP][18] ([Intel XE#979])
[18]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10477/bat-pvc-2/igt@[email protected]

* igt@xe_pm_residency@gt-c6-on-idle:
- bat-pvc-2: NOTRUN -> [SKIP][19] ([Intel XE#531])
[19]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10477/bat-pvc-2/igt@[email protected]

* igt@xe_prime_self_import@basic-with_one_bo:
- bat-pvc-2: NOTRUN -> [FAIL][20] ([Intel XE#999]) +1 other test fail
[20]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10477/bat-pvc-2/igt@xe_prime_self_import@basic-with_one_bo.html

#### Possible fixes ####

* igt@kms_flip@basic-flip-vs-wf_vblank@c-dp3:
- bat-dg2-oem2: [FAIL][21] ([Intel XE#480]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7656/bat-dg2-oem2/igt@kms_flip@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10477/bat-dg2-oem2/igt@kms_flip@[email protected]

* igt@kms_flip@basic-flip-vs-wf_vblank@c-edp1:
- bat-adlp-7: [FAIL][23] ([Intel XE#480]) -> [PASS][24] +1 other test pass
[23]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7656/bat-adlp-7/igt@kms_flip@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10477/bat-adlp-7/igt@kms_flip@[email protected]

* igt@xe_create@create-execqueues-leak:
- bat-atsm-2: [FAIL][25] ([Intel XE#1099]) -> [PASS][26] +1 other test pass
[25]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7656/bat-atsm-2/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10477/bat-atsm-2/igt@[email protected]

* igt@xe_prime_self_import@basic-with_fd_dup:
- bat-atsm-2: [FAIL][27] ([Intel XE#999]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7656/bat-atsm-2/igt@xe_prime_self_import@basic-with_fd_dup.html
[28]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10477/bat-atsm-2/igt@xe_prime_self_import@basic-with_fd_dup.html

#### Warnings ####

* igt@kms_dsc@dsc-basic:
- bat-adlp-7: [FAIL][29] ([Intel XE#1066]) -> [SKIP][30] ([Intel XE#455])
[29]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7656/bat-adlp-7/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10477/bat-adlp-7/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[Intel XE#1000]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1000
[Intel XE#1021]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1021
[Intel XE#1024]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1024
[Intel XE#1066]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1066
[Intel XE#1099]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1099
[Intel XE#255]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/255
[Intel XE#378]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/378
[Intel XE#392]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/392
[Intel XE#455]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/455
[Intel XE#480]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/480
[Intel XE#482]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/482
[Intel XE#531]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/531
[Intel XE#532]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/532
[Intel XE#540]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/540
[Intel XE#780]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/780
[Intel XE#782]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/782
[Intel XE#783]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/783
[Intel XE#784]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/784
[Intel XE#829]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/829
[Intel XE#947]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/947
[Intel XE#976]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/976
[Intel XE#977]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/977
[Intel XE#979]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/979
[Intel XE#999]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/999
[i915#6077]: https://gitlab.freedesktop.org/drm/intel/issues/6077

Build changes
-------------

* IGT: IGT_7656 -> IGTPW_10477

IGTPW_10477: 10477
IGT_7656: 149297384db8cab03928c12b37ae1bb61089bdad @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
xe-598-7b3b98d034784b125bad7aca46f9e7a3cfcde45a: 7b3b98d034784b125bad7aca46f9e7a3cfcde45a

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10477/index.html

#2 lore raw

✗ Fi.CI.BAT: failure for tests/intel/kms_dsc: add new constraint

In reply to Swati Sharma
== Series Details ==

== Series Details ==

Series: tests/intel/kms_dsc: add new constraint
URL : https://patchwork.freedesktop.org/series/128239/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_14080 -> IGTPW_10477
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_10477 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes
introduced in IGTPW_10477, please notify your bug team ([email protected]) to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10477/index.html

Participating hosts (39 -> 38)
------------------------------

Additional (1): fi-bsw-n3050
Missing (2): bat-mtlp-8 fi-snb-2520m

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_10477:

### IGT changes ###

#### Possible regressions ####

* igt@i915_selftest@live@hangcheck:
- fi-skl-guc: [PASS][1] -> [DMESG-FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14080/fi-skl-guc/igt@i915_selftest@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10477/fi-skl-guc/igt@i915_selftest@[email protected]

Known issues
------------

Here are the changes found in IGTPW_10477 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_lmem_swapping@random-engines:
- fi-bsw-n3050: NOTRUN -> [SKIP][3] ([fdo#109271]) +15 other tests skip
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10477/fi-bsw-n3050/igt@[email protected]

* igt@kms_pm_backlight@basic-brightness@edp-1:
- bat-rplp-1: NOTRUN -> [ABORT][4] ([i915#8668])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10477/bat-rplp-1/igt@kms_pm_backlight@[email protected]

#### Possible fixes ####

* igt@i915_selftest@live@gt_engines:
- {bat-adls-6}: [TIMEOUT][5] -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14080/bat-adls-6/igt@i915_selftest@live@gt_engines.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10477/bat-adls-6/igt@i915_selftest@live@gt_engines.html

* igt@i915_selftest@live@workarounds:
- bat-dg2-11: [DMESG-FAIL][7] ([i915#9500]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14080/bat-dg2-11/igt@i915_selftest@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10477/bat-dg2-11/igt@i915_selftest@[email protected]

* igt@i915_suspend@basic-s2idle-without-i915:
- {bat-adls-6}: [WARN][9] -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14080/bat-adls-6/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10477/bat-adls-6/igt@[email protected]

* igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1:
- bat-rplp-1: [ABORT][11] ([i915#8668]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14080/bat-rplp-1/igt@kms_pipe_crc_basic@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10477/bat-rplp-1/igt@kms_pipe_crc_basic@[email protected]

* igt@kms_pm_rpm@basic-rte:
- bat-rpls-2: [ABORT][13] ([i915#8668] / [i915#9368] / [i915#9897]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14080/bat-rpls-2/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10477/bat-rpls-2/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#5591]: https://gitlab.freedesktop.org/drm/intel/issues/5591
[i915#8668]: https://gitlab.freedesktop.org/drm/intel/issues/8668
[i915#9368]: https://gitlab.freedesktop.org/drm/intel/issues/9368
[i915#9500]: https://gitlab.freedesktop.org/drm/intel/issues/9500
[i915#9897]: https://gitlab.freedesktop.org/drm/intel/issues/9897

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_7656 -> IGTPW_10477

CI-20190529: 20190529
CI_DRM_14080: d7426b5fc261046501ca418fe0e69ad1d6ba59be @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_10477: 10477
IGT_7656: 149297384db8cab03928c12b37ae1bb61089bdad @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10477/index.html

#3 lore raw
In reply to Swati Sharma
Quoted 22 lines · Swati Sharma

If output max bpc is less than min dsc bpc (8) which is supported by intel driver, don't execute test.

---
  tests/intel/kms_dsc.c | 4 ++++
  1 file changed, 4 insertions(+)
tests/intel/kms_dsc.c +1 -0
index 3433e0907..8ea15f4d2 100644
@@ -63,6 +63,7 @@ IGT_TEST_DESCRIPTION("Test to validate display stream compression");
 
  #define LEN		20
  #define DEFAULT_BPC	0
+#define MIN_DSC_BPC	8
 
  #define TEST_DSC_BASIC		(0<<0)
  #define TEST_DSC_BPC		(1<<0)

tests/intel/kms_dsc.c static void test_dsc(data_t *data, uint32_t test_type, int bpc, · line 288

Quoted 5 lines
tests/intel/kms_dsc.c +2 -0
@@ -283,6 +284,9 @@ static void test_dsc(data_t *data, uint32_t test_type, int bpc,
  		      check_gen11_dp_constraint(data->drm_fd, data->output, data->pipe)))
  			continue;
 
+		if (igt_get_output_max_bpc(data->drm_fd, output->name) < MIN_DSC_BPC)
+			continue;

Makes sense. Perhaps add this as part of above check and simplify:

if (!is_dsc_supported_by_sink() ||

!check_gen11_dp_constraint(data->drm_fd, data->output, data->pipe) ||

igt_get_output_max_bpc(data->drm_fd, output->name) < MIN_DSC_BPC))

continue;

Regards,

Ankit

Quoted 4 lines
tests/intel/kms_dsc.c +1 -0
+
  		if ((test_type & TEST_DSC_OUTPUT_FORMAT) &&
  		    (!is_dsc_output_format_supported(data->drm_fd, data->disp_ver,
  						     data->output, data->output_format)))