Skip to contentSkip to conversation

build: make missing rst2man non-fatal

PATCH New James Prestwood 1 participant 1 message Jan 5, 2024 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 build: make missing rst2man non-fatal

The configure.ac script does not fail to configure if rst2man is missing but instead sets RUN_RST2MAN depending on if its available, i.e. makes it an optional requirement. But then in Makefile.am if RUN_RST2MAN is not set it fails fatally and will not continue with the build.

Instead remove the false return so the build can continue. Another option would be to put a hard requirement on rst2man and not allow configure to proceed, but based on the existing logic it did not seem like this was the original intent.

---
 Makefile.am | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Makefile.am +1 -1
index b634b730..c8a59f50 100644
@@ -725,7 +725,7 @@ RST2MAN_PROCESS = $(AM_V_GEN)$(MKDIR_P) $(dir $@) && \
 			--no-generator --no-datestamp $< $@
 else
 RST2MAN_PROCESS = $(AM_V_GEN)test -f $@ || \
-		{ echo "Generated manual page $@ does not exist"; false; }
+		{ echo "Generated manual page $@ does not exist"; }
 endif
 
 %.service: %.service.in Makefile
Signature · 1 line
2.34.1