Skip to contentSkip to conversation

acpi/drivers: add DMI exception for ASUS Vivobook E1504GA and E1504GAB to resource.c

PATCH Applied Ben Mayo 2 participants 2 messages Jan 7, 2024 – Jan 9, 2024 ACPI

lore
Share & tools
lore

Ben Mayo

author
#0 lore raw

PATCH 1/1 acpi/drivers: add DMI exception for ASUS Vivobook E1504GA and E1504GAB to resource.c

Asus Vivobook E1504GA and E1504GAB notebooks are affected by bug #216158 (DSDT specifies the kbd IRQ as level active-low and using the override changes this to rising edge, stopping the keyboard from working). Users of these notebooks do not have a working keyboard unless they add their DMI information to the struct irq1_level_low_skip_override array in resource.c and compile a custom kernel. This patch will add support for these computers to the linux kernel without requiring the end-user to recompile the kernel.

---
 drivers/acpi/resource.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
drivers/acpi/resource.c +14 -0
index 9bd9f79cd409..eb34d201b65f 100644
@@ -482,6 +482,20 @@ static const struct dmi_system_id irq1_level_low_skip_override[] = {
 			DMI_MATCH(DMI_BOARD_NAME, "B2502CBA"),
 		},
 	},
+	{
+		/* Asus Vivobook E1504GA */
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+			DMI_MATCH(DMI_BOARD_NAME, "E1504GA"),
+		},
+	},
+	{
+		/* Asus Vivobook E1504GAB */
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+			DMI_MATCH(DMI_BOARD_NAME, "E1504GAB"),
+		},
+	},
 	{
 		/* LG Electronics 17U70P */
 		.matches = {
Signature · 1 line
2.43.0
maintainer Applied
#1 lore raw
Quoted 31 lines · Ben Mayo

Asus Vivobook E1504GA and E1504GAB notebooks are affected by bug #216158 (DSDT specifies the kbd IRQ as level active-low and using the override changes this to rising edge, stopping the keyboard from working). Users of these notebooks do not have a working keyboard unless they add their DMI information to the struct irq1_level_low_skip_override array in resource.c and compile a custom kernel. This patch will add support for these computers to the linux kernel without requiring the end-user to recompile the kernel.

---
 drivers/acpi/resource.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
drivers/acpi/resource.c +8 -0
index 9bd9f79cd409..eb34d201b65f 100644
@@ -482,6 +482,20 @@ static const struct dmi_system_id irq1_level_low_skip_override[] = {
                        DMI_MATCH(DMI_BOARD_NAME, "B2502CBA"),
                },
        },
+       {
+               /* Asus Vivobook E1504GA */
+               .matches = {
+                       DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+                       DMI_MATCH(DMI_BOARD_NAME, "E1504GA"),
+               },
+       },
+       {

drivers/acpi/resource.c static const struct dmi_system_id irq1_level_low_skip_override[] = {

Quoted 10 lines
drivers/acpi/resource.c +6 -1
+               /* Asus Vivobook E1504GAB */
+               .matches = {
+                       DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+                       DMI_MATCH(DMI_BOARD_NAME, "E1504GAB"),
+               },
+       },
        {
                /* LG Electronics 17U70P */
                .matches = {
--

Applied as 6.8-rc1 material with some edits in the subject and changelog (a Link: tag pointing to the bug in question added in particular).

Thanks!