Simple panel improvements
cover Simple panel improvements
Simplify platform data pass to simple DSI panels by direct asigning in udevice_id struct.
Support EDID searching in case device tree provides no specific timings or device has different panels (like paz00).
Svyatoslav Ryhel (2):
video: simple_panel: simplify platform data pass
video: simple_panel: add EDID support
drivers/video/Kconfig | 2 + drivers/video/simple_panel.c | 87 +++++++++++++++++++++++++----------- 2 files changed, 63 insertions(+), 26 deletions(-)
Signature · 1 line
2.40.1
PATCH 1/2 video: simple_panel: simplify platform data pass
Pass MIPI DSI platform data to simple DSI panel directly from driver data on panel probe.
--- drivers/video/simple_panel.c | 36 ++++++++++++------------------------ 1 file changed, 12 insertions(+), 24 deletions(-)
drivers/video/simple_panel.c +12 -24
@@ -19,19 +19,6 @@ struct simple_panel_priv {struct gpio_desc enable; }; -/* List of supported DSI panels */ -enum { -PANEL_NON_DSI , -PANASONIC_VVX10F004B00 , -}; - -static const struct mipi_dsi_panel_plat panasonic_vvx10f004b00 = { - .mode_flags =MIPI_DSI_MODE_VIDEO |MIPI_DSI_MODE_VIDEO_SYNC_PULSE | -MIPI_DSI_CLOCK_NON_CONTINUOUS , - .format =MIPI_DSI_FMT_RGB888 , - .lanes =4 , -}; -static int simple_panel_enable_backlight (struct udevice *dev) {struct simple_panel_priv *priv =dev_get_priv (dev);
@@ -111,7 +98,8 @@ static int simple_panel_probe(struct udevice *dev) {struct simple_panel_priv *priv =dev_get_priv (dev);struct mipi_dsi_panel_plat *plat =dev_get_plat (dev); -const u32 dsi_data =dev_get_driver_data (dev); +struct mipi_dsi_panel_plat *dsi_data = + (struct mipi_dsi_panel_plat *)dev_get_driver_data (dev);int ret; ret =regulator_set_enable_if_allowed (priv->reg, true);
@@ -121,15 +109,8 @@ static int simple_panel_probe(struct udevice *dev)return ret; } -switch (dsi_data) { -case PANASONIC_VVX10F004B00 : -memcpy (plat, &panasonic_vvx10f004b00, -sizeof (panasonic_vvx10f004b00)); -break ; -case PANEL_NON_DSI : -default : -break ; - } +if (dsi_data) +memcpy (plat, dsi_data,sizeof (struct mipi_dsi_panel_plat ));return 0 ; }
@@ -140,6 +121,13 @@ static const struct panel_ops simple_panel_ops = { .get_display_timing = simple_panel_get_display_timing, }; +static const struct mipi_dsi_panel_plat panasonic_vvx10f004b00 = { + .mode_flags =MIPI_DSI_MODE_VIDEO |MIPI_DSI_MODE_VIDEO_SYNC_PULSE | +MIPI_DSI_CLOCK_NON_CONTINUOUS , + .format =MIPI_DSI_FMT_RGB888 , + .lanes =4 , +}; +static const struct udevice_id simple_panel_ids[] = { { .compatible ="simple-panel" }, { .compatible ="auo,b133xtn01" },
@@ -150,7 +138,7 @@ static const struct udevice_id simple_panel_ids[] = { { .compatible = "sharp,lq123p1jx31" }, { .compatible = "boe,nv101wxmn51" }, { .compatible = "panasonic,vvx10f004b00", - .data = PANASONIC_VVX10F004B00 }, + .data = (ulong)&panasonic_vvx10f004b00 }, { } };
Signature · 1 line
2.40.1
PATCH 2/2 video: simple_panel: add EDID support
In reply to Svyatoslav RyhelSupport timing parsing from EDID if panel device tree node provides DDC i2c bus instead of timings node.
--- drivers/video/Kconfig | 2 ++ drivers/video/simple_panel.c | 51 ++++++++++++++++++++++++++++++++++-- 2 files changed, 51 insertions(+), 2 deletions(-)
drivers/video/Kconfig +2 -0
@@ -240,6 +240,7 @@ config PANEL config SIMPLE_PANEL bool "Enable simple panel support" depends on PANEL && BACKLIGHT && DM_GPIO + select I2C_EDID default y help This turns on a simple panel driver that enables a compatible
@@ -1105,6 +1106,7 @@ config SPL_PANEL config SPL_SIMPLE_PANEL bool "Enable simple panel support at SPL" depends on SPL_PANEL && SPL_BACKLIGHT && SPL_DM_GPIO + select I2C_EDID default y help This turns on a simple panel driver that enables a compatible
drivers/video/simple_panel.c +49 -2
70 lines not on this page · raw message
Signature · 1 line
2.40.1
Quoted 6 lines · On Mon, 8 Jan 2024 18:44:59 +0200 Svyatoslav Ryhel [email protected] wrote:
Simplify platform data pass to simple DSI panels by direct asigning in
udevice_idstruct.Support EDID searching in case device tree provides no specific timings or device has different panels (like paz00).
Quoted 7 lines
Svyatoslav Ryhel (2):
video:simple_panel: simplify platform data pass
video:simple_panel: add EDID supportdrivers/video/Kconfig | 2 + drivers/video/simple_panel.c | 87 +++++++++++++++++++++++++----------- 2 files changed, 63 insertions(+), 26 deletions(-)
Series applied to u-boot-video. Fixed dm_i2c_* build errors with patch 2.
--
Anatolij